diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-11-26 16:26:20 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-11-26 16:26:20 -0500 |
commit | a922c497fade0250123b86d7535838c9a8d3b0af (patch) | |
tree | 58d60290dab73537d294c8a81dbef091279dc01a /components/script/dom/workerglobalscope.rs | |
parent | 8e0aa68aaafd96abc589f185f7f863f96c553e26 (diff) | |
parent | 50a7111eb65155fc7a0bdb1646c4a2e0ebdd8f90 (diff) | |
download | servo-a922c497fade0250123b86d7535838c9a8d3b0af.tar.gz servo-a922c497fade0250123b86d7535838c9a8d3b0af.zip |
Auto merge of #24758 - gterzian:impl_timer_task_source, r=nox
Implement timer-task-source, time-out service worker
<!-- Please describe your changes on the following line: -->
Implements the timer task-source, and folds the IPC glue-code into a single route set by the globalscope.
Also switches service worker to using a dedicated "time-out" mechanism, which previously relied on the timer mechanism(and I think didn't actually implement script timers).
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #24747 (GitHub issue number if applicable)
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/workerglobalscope.rs')
-rw-r--r-- | components/script/dom/workerglobalscope.rs | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/components/script/dom/workerglobalscope.rs b/components/script/dom/workerglobalscope.rs index 7e55cbfc046..e943b6b0ef4 100644 --- a/components/script/dom/workerglobalscope.rs +++ b/components/script/dom/workerglobalscope.rs @@ -34,6 +34,7 @@ use crate::task_source::networking::NetworkingTaskSource; use crate::task_source::performance_timeline::PerformanceTimelineTaskSource; use crate::task_source::port_message::PortMessageQueue; use crate::task_source::remote_event::RemoteEventTaskSource; +use crate::task_source::timer::TimerTaskSource; use crate::task_source::websocket::WebsocketTaskSource; use crate::timers::{IsInterval, TimerCallback}; use crossbeam_channel::Receiver; @@ -50,7 +51,6 @@ use net_traits::request::{ }; use net_traits::IpcSend; use script_traits::WorkerGlobalScopeInit; -use script_traits::{TimerEvent, TimerEventId}; use servo_url::{MutableOrigin, ServoUrl}; use std::cell::Ref; use std::default::Default; @@ -120,7 +120,6 @@ impl WorkerGlobalScope { worker_url: ServoUrl, runtime: Runtime, from_devtools_receiver: Receiver<DevtoolScriptControlMsg>, - timer_event_chan: IpcSender<TimerEvent>, closing: Option<Arc<AtomicBool>>, ) -> Self { // Install a pipeline-namespace in the current thread. @@ -134,7 +133,6 @@ impl WorkerGlobalScope { init.script_to_constellation_chan, init.scheduler_chan, init.resource_threads, - timer_event_chan, MutableOrigin::new(init.origin), runtime.microtask_queue.clone(), init.is_headless, @@ -437,6 +435,10 @@ impl WorkerGlobalScope { PortMessageQueue(self.script_chan(), self.pipeline_id()) } + pub fn timer_task_source(&self) -> TimerTaskSource { + TimerTaskSource(self.script_chan(), self.pipeline_id()) + } + pub fn remote_event_task_source(&self) -> RemoteEventTaskSource { RemoteEventTaskSource(self.script_chan(), self.pipeline_id()) } @@ -466,10 +468,6 @@ impl WorkerGlobalScope { } } - pub fn handle_fire_timer(&self, timer_id: TimerEventId) { - self.upcast::<GlobalScope>().fire_timer(timer_id); - } - pub fn close(&self) { if let Some(ref closing) = self.closing { closing.store(true, Ordering::SeqCst); |