diff options
| author | bors-servo <servo-ops@mozilla.com> | 2020-05-05 04:40:51 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-05 04:40:51 -0400 |
| commit | 5e44327325cdc92dffa40b92394e8b2b68df97e0 (patch) | |
| tree | 15c4b022f218ea9a8d0f14262520cc7fd477b713 /components/script/dom/window.rs | |
| parent | 173bfadaa75d35e88bb5f51fbff56ab9caaae552 (diff) | |
| parent | 86a5cf75aa4b67ded34eaecc0b3eda3d78e47b24 (diff) | |
| download | servo-5e44327325cdc92dffa40b92394e8b2b68df97e0.tar.gz servo-5e44327325cdc92dffa40b92394e8b2b68df97e0.zip | |
Auto merge of #26410 - utsavoza:ugo/issue-26287/04-05-2020, r=ferjm
Update window.open() to return fallible result
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes partially fix #26287
- [x] There are tests for these changes
Diffstat (limited to 'components/script/dom/window.rs')
| -rw-r--r-- | components/script/dom/window.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/script/dom/window.rs b/components/script/dom/window.rs index ccb4b8dfb48..93019cf913d 100644 --- a/components/script/dom/window.rs +++ b/components/script/dom/window.rs @@ -661,7 +661,7 @@ impl WindowMethods for Window { url: USVString, target: DOMString, features: DOMString, - ) -> Option<DomRoot<WindowProxy>> { + ) -> Fallible<Option<DomRoot<WindowProxy>>> { self.window_proxy().open(url, target, features) } |