api: Flatten and simplify Servo preferences (#34966)

Flatten and simplify Servo's preferences code. In addition, have both
preferences and options passed in as arguments to `Servo::new()` and
make sure not to use the globally set preferences in `servoshell` (as
much as possible now).

Instead of a complex procedural macro to generate preferences, just
expose a very simple derive macro that adds string based getters and
setters.

- All command-line parsing is moved to servoshell.
- There is no longer the concept of a missing preference.
- Preferences no longer have to be part of the resources bundle because
  they now have reasonable default values.
- servoshell specific preferences are no longer part of the preferences
  exposed by the Servo API.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/components/script/dom/webxr/xrsystem.rs b/components/script/dom/webxr/xrsystem.rs
index 82736d540e9..f5f50ab93f1 100644
--- a/components/script/dom/webxr/xrsystem.rs
+++ b/components/script/dom/webxr/xrsystem.rs
@@ -168,7 +168,7 @@ impl XRSystemMethods<crate::DomTypeHolder> for XRSystem {
 
         if mode != XRSessionMode::Inline {
             if !ScriptThread::is_user_interacting() {
-                if pref!(dom.webxr.unsafe_assume_user_intent) {
+                if pref!(dom_webxr_unsafe_assume_user_intent) {
                     warn!("The dom.webxr.unsafe-assume-user-intent preference assumes user intent to enter WebXR.");
                 } else {
                     promise.reject_error(Error::Security);
@@ -232,7 +232,7 @@ impl XRSystemMethods<crate::DomTypeHolder> for XRSystem {
         let init = SessionInit {
             required_features,
             optional_features,
-            first_person_observer_view: pref!(dom.webxr.first_person_observer_view),
+            first_person_observer_view: pref!(dom_webxr_first_person_observer_view),
         };
 
         let mut trusted = Some(TrustedPromise::new(promise.clone()));