diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2020-01-06 13:52:26 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-01-06 13:52:26 -0500 |
commit | fd2950e903aab2c6d56d537a71a2a25ccd0307e5 (patch) | |
tree | 4d68e4a476aac166169f803a3a27547b2535c81b /components/script/dom/webgltexture.rs | |
parent | 8b6c1e759438f21e2072ce36eb97130dd7d0e182 (diff) | |
parent | 036e8dabe2d38e21348766d1a5cda99381b015f8 (diff) | |
download | servo-fd2950e903aab2c6d56d537a71a2a25ccd0307e5.tar.gz servo-fd2950e903aab2c6d56d537a71a2a25ccd0307e5.zip |
Auto merge of #25424 - pshaughn:labelfixes, r=Manishearth
Make labelable element .labels a live list in tree order
This is not the highest-performance solution possible but it's visibly spec-aligned in a way a faster-performing implementation would be harder to verify, and I don't expect label-getting to deal with more than a few nodes at once in practice.
I added a macro by analogy with some of the existing make_XXX_getter! macros; I will change it if it doesn't seem right.
Remaining test failures are because keygen, shadow DOM, and ElementInternals are unimplemented. Shadow DOM should already be handled by the existing code when it is implemented, and keygen should just be able to add a labels_node_list and use the macro like the other labelable elements. ElementInternals labels are slightly different and might need another NodeList case.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes fix #25391
<!-- Either: -->
- [X] There are tests for these changes, although there's room for more (see https://github.com/web-platform-tests/wpt/issues/21028)
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/webgltexture.rs')
0 files changed, 0 insertions, 0 deletions