diff options
| author | Emilio Cobos Álvarez <me@emiliocobos.me> | 2016-04-19 13:11:28 +0200 |
|---|---|---|
| committer | Emilio Cobos Álvarez <me@emiliocobos.me> | 2016-04-19 13:27:19 +0200 |
| commit | 6a15c2f245a32677edd76dd0e1dedbd404132bd9 (patch) | |
| tree | 467a6f8f61ef691e729c00dc738e2cac07492683 /components/script/dom/webglshader.rs | |
| parent | f470ad0d884f50247f4846a8271e67616ffc7354 (diff) | |
| download | servo-6a15c2f245a32677edd76dd0e1dedbd404132bd9.tar.gz servo-6a15c2f245a32677edd76dd0e1dedbd404132bd9.zip | |
webgl: Remove active_uniform related validation.
It's broken for uniform arrays, since uniform.id() stops being the index
then.
We need to add a more complex integration with angle for this to ever
be correct.
Unfortunately the ANGLE part that we should touch is C++, and it has
destructors, so we need to hook destructors there, and I can't do it
right now.
Diffstat (limited to 'components/script/dom/webglshader.rs')
| -rw-r--r-- | components/script/dom/webglshader.rs | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/components/script/dom/webglshader.rs b/components/script/dom/webglshader.rs index 495417065d7..eb930a69f13 100644 --- a/components/script/dom/webglshader.rs +++ b/components/script/dom/webglshader.rs @@ -116,6 +116,11 @@ impl WebGLShader { } *self.info_log.borrow_mut() = Some(validator.info_log()); + // TODO(emilio): More data (like uniform data) should be collected + // here to properly validate uniforms. + // + // This requires a more complex interface with ANGLE, using C++ + // bindings and being extremely cautious about destructing things. } } |