diff options
author | Richard Dushime <45734838+richarddushime@users.noreply.github.com> | 2025-04-02 16:50:56 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-04-02 14:50:56 +0000 |
commit | 60baa8ce1104d81d1146a9595bf402cd1cc669d8 (patch) | |
tree | ea27c05bcb5d7694b5b8c9a0355194faf080463b /components/script/dom/vttregion.rs | |
parent | 2ce306f45049229383266f1d1193e577b096fa12 (diff) | |
download | servo-60baa8ce1104d81d1146a9595bf402cd1cc669d8.tar.gz servo-60baa8ce1104d81d1146a9595bf402cd1cc669d8.zip |
Use Window in new methods instead of GlobalScope for interfaces with … (#36133)
…Window-only constructors
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by
`[X]` when the step is complete, and replace `___` with appropriate
data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #36118 (GitHub issue number if applicable)
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
<!-- Also, please make sure that "Allow edits from maintainers" checkbox
is checked, so that we can help you if you get stuck somewhere along the
way.-->
<!-- Pull requests that do not address these steps are welcome, but they
will require additional verification as part of the review process. -->
---------
Signed-off-by: richarddushime <mudaherarich@gmail.com>
Signed-off-by: Richard Dushime <45734838+richarddushime@users.noreply.github.com>
Diffstat (limited to 'components/script/dom/vttregion.rs')
-rw-r--r-- | components/script/dom/vttregion.rs | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/components/script/dom/vttregion.rs b/components/script/dom/vttregion.rs index ee80210ee23..cb3ff0eb1f3 100644 --- a/components/script/dom/vttregion.rs +++ b/components/script/dom/vttregion.rs @@ -11,10 +11,9 @@ use crate::dom::bindings::cell::DomRefCell; use crate::dom::bindings::codegen::Bindings::VTTRegionBinding::{ScrollSetting, VTTRegionMethods}; use crate::dom::bindings::error::{Error, ErrorResult, Fallible}; use crate::dom::bindings::num::Finite; -use crate::dom::bindings::reflector::{DomGlobal, Reflector, reflect_dom_object_with_proto}; +use crate::dom::bindings::reflector::{Reflector, reflect_dom_object_with_proto}; use crate::dom::bindings::root::DomRoot; use crate::dom::bindings::str::DOMString; -use crate::dom::globalscope::GlobalScope; use crate::dom::window::Window; use crate::script_runtime::CanGc; @@ -46,8 +45,8 @@ impl VTTRegion { } } - fn new(global: &GlobalScope, proto: Option<HandleObject>, can_gc: CanGc) -> DomRoot<Self> { - reflect_dom_object_with_proto(Box::new(Self::new_inherited()), global, proto, can_gc) + fn new(window: &Window, proto: Option<HandleObject>, can_gc: CanGc) -> DomRoot<Self> { + reflect_dom_object_with_proto(Box::new(Self::new_inherited()), window, proto, can_gc) } } @@ -58,7 +57,7 @@ impl VTTRegionMethods<crate::DomTypeHolder> for VTTRegion { proto: Option<HandleObject>, can_gc: CanGc, ) -> Fallible<DomRoot<Self>> { - Ok(VTTRegion::new(&window.global(), proto, can_gc)) + Ok(VTTRegion::new(window, proto, can_gc)) } // https://w3c.github.io/webvtt/#dom-vttregion-id |