diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2020-01-16 23:47:07 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-01-16 23:47:07 -0500 |
commit | d3b37ead0a969b6c8e90676d37057e7b53ee8dd9 (patch) | |
tree | 1a9ebc1093d0586adaca073d092a1d6c5dd45eba /components/script/dom/vrdisplayevent.rs | |
parent | 0e9d89cecc3983422eb28831155bbc354c03fe16 (diff) | |
parent | 0650fc319905ecd018ee0f6e059f9f40589e10b6 (diff) | |
download | servo-d3b37ead0a969b6c8e90676d37057e7b53ee8dd9.tar.gz servo-d3b37ead0a969b6c8e90676d37057e7b53ee8dd9.zip |
Auto merge of #25538 - szeged:mmatyas__webgl_fns_uniforms_p2, r=jdm
Add support for WebGL2 uniform array operations
Adds support for the WebGL2 overloads of `uniform[1234][if]v`.
<!-- Please describe your changes on the following line: -->
WebGL2 adds two optional parameters for the `uniform[1234][if]v` functions to allow specifying input data ranges. However, because they have the same name and overlapping parameters, the Codegen cannot make a difference between their GL1 and 2 variants. As a workaround, I've added the new parameters to the WebGL1 side, which which isn't strictly what the spec says, but shouldn't break things either. (Note: Firefox devs also run into this issue: [[1](https://searchfox.org/mozilla-central/source/dom/webidl/WebGLRenderingContext.webidl#794), [2](https://bugzilla.mozilla.org/show_bug.cgi?id=1324543)]).
cc @jdm @zakorgy @imiklos
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/vrdisplayevent.rs')
0 files changed, 0 insertions, 0 deletions