diff options
author | Richard Dushime <45734838+richarddushime@users.noreply.github.com> | 2025-04-02 16:50:56 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-04-02 14:50:56 +0000 |
commit | 60baa8ce1104d81d1146a9595bf402cd1cc669d8 (patch) | |
tree | ea27c05bcb5d7694b5b8c9a0355194faf080463b /components/script/dom/rtctrackevent.rs | |
parent | 2ce306f45049229383266f1d1193e577b096fa12 (diff) | |
download | servo-60baa8ce1104d81d1146a9595bf402cd1cc669d8.tar.gz servo-60baa8ce1104d81d1146a9595bf402cd1cc669d8.zip |
Use Window in new methods instead of GlobalScope for interfaces with … (#36133)
…Window-only constructors
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by
`[X]` when the step is complete, and replace `___` with appropriate
data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #36118 (GitHub issue number if applicable)
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
<!-- Also, please make sure that "Allow edits from maintainers" checkbox
is checked, so that we can help you if you get stuck somewhere along the
way.-->
<!-- Pull requests that do not address these steps are welcome, but they
will require additional verification as part of the review process. -->
---------
Signed-off-by: richarddushime <mudaherarich@gmail.com>
Signed-off-by: Richard Dushime <45734838+richarddushime@users.noreply.github.com>
Diffstat (limited to 'components/script/dom/rtctrackevent.rs')
-rw-r--r-- | components/script/dom/rtctrackevent.rs | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/components/script/dom/rtctrackevent.rs b/components/script/dom/rtctrackevent.rs index dbb76928c49..a378c7250d2 100644 --- a/components/script/dom/rtctrackevent.rs +++ b/components/script/dom/rtctrackevent.rs @@ -10,11 +10,10 @@ use crate::dom::bindings::codegen::Bindings::EventBinding::Event_Binding::EventM use crate::dom::bindings::codegen::Bindings::RTCTrackEventBinding::{self, RTCTrackEventMethods}; use crate::dom::bindings::error::Fallible; use crate::dom::bindings::inheritance::Castable; -use crate::dom::bindings::reflector::{DomGlobal, reflect_dom_object_with_proto}; +use crate::dom::bindings::reflector::reflect_dom_object_with_proto; use crate::dom::bindings::root::{Dom, DomRoot}; use crate::dom::bindings::str::DOMString; use crate::dom::event::Event; -use crate::dom::globalscope::GlobalScope; use crate::dom::mediastreamtrack::MediaStreamTrack; use crate::dom::window::Window; use crate::script_runtime::CanGc; @@ -35,18 +34,18 @@ impl RTCTrackEvent { } pub(crate) fn new( - global: &GlobalScope, + window: &Window, type_: Atom, bubbles: bool, cancelable: bool, track: &MediaStreamTrack, can_gc: CanGc, ) -> DomRoot<RTCTrackEvent> { - Self::new_with_proto(global, None, type_, bubbles, cancelable, track, can_gc) + Self::new_with_proto(window, None, type_, bubbles, cancelable, track, can_gc) } fn new_with_proto( - global: &GlobalScope, + window: &Window, proto: Option<HandleObject>, type_: Atom, bubbles: bool, @@ -56,7 +55,7 @@ impl RTCTrackEvent { ) -> DomRoot<RTCTrackEvent> { let trackevent = reflect_dom_object_with_proto( Box::new(RTCTrackEvent::new_inherited(track)), - global, + window, proto, can_gc, ); @@ -78,7 +77,7 @@ impl RTCTrackEventMethods<crate::DomTypeHolder> for RTCTrackEvent { init: &RTCTrackEventBinding::RTCTrackEventInit, ) -> Fallible<DomRoot<RTCTrackEvent>> { Ok(RTCTrackEvent::new_with_proto( - &window.global(), + window, proto, Atom::from(type_), init.parent.bubbles, |