diff options
| author | Smitty <me@iter.ca> | 2024-02-05 09:30:53 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-05 14:30:53 +0000 |
| commit | 50c930866be9410e0e9234206683d28463a55ede (patch) | |
| tree | b5db5c7de7fac2514f07c792d516bd976f3539cc /components/script/dom/performanceobserver.rs | |
| parent | 4758ffabcabe901fd17c11d4eeafb7e35eb9cc12 (diff) | |
| download | servo-50c930866be9410e0e9234206683d28463a55ede.tar.gz servo-50c930866be9410e0e9234206683d28463a55ede.zip | |
Make console methods take `any` instead of `string` (#31241)
* Make console methods use `any` for the message
Match the Console spec by allowing any value to be passed to console
methods, instead of just values that can be converted to a string.
Signed-off-by: syvb <me@iter.ca>
* Add test for console logging a Symbol
Signed-off-by: syvb <me@iter.ca>
* Implement object stringification for logs
Signed-off-by: syvb <me@iter.ca>
* Address review comments
Signed-off-by: syvb <me@iter.ca>
* Make time/timeEnd accept DOMString to match spec
* Update WPT results for layout 2013
---------
Signed-off-by: syvb <me@iter.ca>
Diffstat (limited to 'components/script/dom/performanceobserver.rs')
| -rw-r--r-- | components/script/dom/performanceobserver.rs | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/components/script/dom/performanceobserver.rs b/components/script/dom/performanceobserver.rs index cda2248f3e8..c87fedcd843 100644 --- a/components/script/dom/performanceobserver.rs +++ b/components/script/dom/performanceobserver.rs @@ -191,11 +191,9 @@ impl PerformanceObserverMethods for PerformanceObserver { // Step 6.3 if entry_types.is_empty() { - Console::Warn( + Console::internal_warn( &*self.global(), - vec![DOMString::from( - "No valid entry type provided to observe().", - )], + DOMString::from("No valid entry type provided to observe()."), ); return Ok(()); } @@ -210,11 +208,9 @@ impl PerformanceObserverMethods for PerformanceObserver { } else if let Some(entry_type) = &options.type_ { // Step 7.2 if !VALID_ENTRY_TYPES.contains(&entry_type.as_ref()) { - Console::Warn( + Console::internal_warn( &*self.global(), - vec![DOMString::from( - "No valid entry type provided to observe().", - )], + DOMString::from("No valid entry type provided to observe()."), ); return Ok(()); } |