aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/htmlulistelement.rs
diff options
context:
space:
mode:
authorelomscansio <163124154+elomscansio@users.noreply.github.com>2025-04-07 00:26:15 +0100
committerGitHub <noreply@github.com>2025-04-06 23:26:15 +0000
commit1f558a0d49d32bec3ad1006903bed069773d0861 (patch)
tree90998ba309fc5a480f5467dc9eac2436c7e7fb50 /components/script/dom/htmlulistelement.rs
parent0caa271176d4670eb06bedd05cdffb24df08fc4f (diff)
downloadservo-1f558a0d49d32bec3ad1006903bed069773d0861.tar.gz
servo-1f558a0d49d32bec3ad1006903bed069773d0861.zip
Fix radio group validity update when removing or selecting an input (#36252)
This PR fixes an issue where radio inputs in the same group failed to correctly update their `validity.valueMissing` state when: - A **checked radio button was removed** from the DOM. - A **different radio button was selected** by user interaction. This behavior caused mismatches with how browsers like Firefox handle radio group validation. --- ### Changes in This PR #### Radio group revalidation on DOM removal - Updated `unbind_from_tree()` to revalidate other radio buttons in the same group when a checked input is removed. - Uses `UnbindContext::parent` as the DOM root to ensure the correct context is used during traversal. #### New helper: `find_related_radios()` - Encapsulates logic for finding other inputs in the same group. - Used during both removal and attribute changes for consistency. #### Validation on `checked`/`value` updates - Introduced `update_related_validity_states()` to revalidate all group members when a radio's `checked` or `value` is changed. #### Web Platform Test (WPT) coverage - Created a new WPT file: `radio-group-valueMissing.html`. - Tests follow recommended `test()` pattern: - **Precondition**: Assert initial `valueMissing`. - **Action**: Remove or select a radio. - **Postcondition**: Assert expected `valueMissing`. #### Manifest updated - The WPT manifest now includes the new test. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #36110 <!-- Either: --> - [X] There are tests for these changes Signed-off-by: Emmanuel Elom <elomemmanuel007@gmail.com>
Diffstat (limited to 'components/script/dom/htmlulistelement.rs')
0 files changed, 0 insertions, 0 deletions