aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/htmltextareaelement.rs
diff options
context:
space:
mode:
authorbors-servo <metajack+bors@gmail.com>2015-03-10 07:51:50 -0600
committerbors-servo <metajack+bors@gmail.com>2015-03-10 07:51:50 -0600
commitd31e80f89490afe4863574c062f34b2a0df43bae (patch)
tree98dadb54d54b2b8e4efd97a53ec76fefd02b0a08 /components/script/dom/htmltextareaelement.rs
parentfd1bb49a65dd998c8ef9890a1576aaf62ddfdba1 (diff)
parent08ac0766eda2340008642e86799ea2cb1ef6e59f (diff)
downloadservo-d31e80f89490afe4863574c062f34b2a0df43bae.tar.gz
servo-d31e80f89490afe4863574c062f34b2a0df43bae.zip
auto merge of #5182 : zslayton/servo/master, r=jdm
Opening this PR to invite feedback. Of the many `match` statement candidates for conversion to `if let`, several included `if` guards. Since `if let` doesn't support this syntax, I used nested if statements. If this is undesirable, say the word and I can revert those cases to `match`.
Diffstat (limited to 'components/script/dom/htmltextareaelement.rs')
-rw-r--r--components/script/dom/htmltextareaelement.rs34
1 files changed, 12 insertions, 22 deletions
diff --git a/components/script/dom/htmltextareaelement.rs b/components/script/dom/htmltextareaelement.rs
index ed7fb71a954..0e7b6de2642 100644
--- a/components/script/dom/htmltextareaelement.rs
+++ b/components/script/dom/htmltextareaelement.rs
@@ -224,9 +224,8 @@ impl<'a> VirtualMethods for JSRef<'a, HTMLTextAreaElement> {
}
fn after_set_attr(&self, attr: JSRef<Attr>) {
- match self.super_type() {
- Some(ref s) => s.after_set_attr(attr),
- _ => ()
+ if let Some(ref s) = self.super_type() {
+ s.after_set_attr(attr);
}
match attr.local_name() {
@@ -252,9 +251,8 @@ impl<'a> VirtualMethods for JSRef<'a, HTMLTextAreaElement> {
}
fn before_remove_attr(&self, attr: JSRef<Attr>) {
- match self.super_type() {
- Some(ref s) => s.before_remove_attr(attr),
- _ => ()
+ if let Some(ref s) = self.super_type() {
+ s.before_remove_attr(attr);
}
match attr.local_name() {
@@ -275,9 +273,8 @@ impl<'a> VirtualMethods for JSRef<'a, HTMLTextAreaElement> {
}
fn bind_to_tree(&self, tree_in_doc: bool) {
- match self.super_type() {
- Some(ref s) => s.bind_to_tree(tree_in_doc),
- _ => (),
+ if let Some(ref s) = self.super_type() {
+ s.bind_to_tree(tree_in_doc);
}
let node: JSRef<Node> = NodeCast::from_ref(*self);
@@ -293,9 +290,8 @@ impl<'a> VirtualMethods for JSRef<'a, HTMLTextAreaElement> {
}
fn unbind_from_tree(&self, tree_in_doc: bool) {
- match self.super_type() {
- Some(ref s) => s.unbind_from_tree(tree_in_doc),
- _ => (),
+ if let Some(ref s) = self.super_type() {
+ s.unbind_from_tree(tree_in_doc);
}
let node: JSRef<Node> = NodeCast::from_ref(*self);
@@ -307,11 +303,8 @@ impl<'a> VirtualMethods for JSRef<'a, HTMLTextAreaElement> {
}
fn child_inserted(&self, child: JSRef<Node>) {
- match self.super_type() {
- Some(s) => {
- s.child_inserted(child);
- }
- _ => (),
+ if let Some(s) = self.super_type() {
+ s.child_inserted(child);
}
if child.is_text() && !self.value_changed.get() {
@@ -321,11 +314,8 @@ impl<'a> VirtualMethods for JSRef<'a, HTMLTextAreaElement> {
// copied and modified from htmlinputelement.rs
fn handle_event(&self, event: JSRef<Event>) {
- match self.super_type() {
- Some(s) => {
- s.handle_event(event);
- }
- _ => (),
+ if let Some(s) = self.super_type() {
+ s.handle_event(event);
}
if "click" == event.Type().as_slice() && !event.DefaultPrevented() {