aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/htmlscriptelement.rs
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2018-04-19 15:11:20 -0400
committerGitHub <noreply@github.com>2018-04-19 15:11:20 -0400
commit319de3b0fe54d630109d78452773555022d04227 (patch)
tree6ed0d3281861d814d837389f70bc365461a95988 /components/script/dom/htmlscriptelement.rs
parent3c5f0a85debcb2fc7417137e2ea3a991fb6c5549 (diff)
parent61b4a891bb188835842683800d6e97cecfd81609 (diff)
downloadservo-319de3b0fe54d630109d78452773555022d04227.tar.gz
servo-319de3b0fe54d630109d78452773555022d04227.zip
Auto merge of #20578 - kwonoj:refactor-bluetooth-manager, r=paulrouget
refactor(bluetooth): removes direct ui invocation from bluetooth thread <!-- Please describe your changes on the following line: --> Relates to #20429. This PR is mostly blocked by https://github.com/servo/servo/pull/20480, cause both are nearly identical change in crux and based on review of prior changes this PR need to be updated. Just didn't want assigned issue hanging without visible progresses, so prepped PR to followup further. (mostly copy-paste from pair PR) Probably point of review / need to be updated are 1. Communication between components Currently it's wired as like below: ``` +----------------+ +---------------+ +---------+ | | constellationMsg | | embedderMsg | | | bluetooth_thread +----------------->+ constellation +------------->+ browser | | | | | | | +-----+----------+ +---------------+ +----+----+ ^ | +-------------------------------------------------------------------+ device: String ``` - is this feasible approach? - does organization of message / fn (where to put consteallation / embedder msg & fns) are legit? 2. Invoking tfd in a separate thread - This was mainly to align behavior to previous implentation, where tfd was invoked inside of filemanager_thread so does not block main. It may possibly just let block instead. and of course, a lot of other codes need to follow better practices. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [ ] `./mach build-geckolib` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20429 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20578) <!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/htmlscriptelement.rs')
0 files changed, 0 insertions, 0 deletions