aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/htmlcollection.rs
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2016-08-31 04:10:42 -0500
committerGitHub <noreply@github.com>2016-08-31 04:10:42 -0500
commit3649a356c8ddd04d3beebff9978b1bffa407c307 (patch)
tree45a29e22d90107d905317674ed0b35aaa04f87db /components/script/dom/htmlcollection.rs
parentacb47007ba9494c73272494efe9ebd2c05e4c014 (diff)
parent7dfb336be8dae1e2be9b898c374b6715e2a00ac7 (diff)
downloadservo-3649a356c8ddd04d3beebff9978b1bffa407c307.tar.gz
servo-3649a356c8ddd04d3beebff9978b1bffa407c307.zip
Auto merge of #13100 - nox:better-getters, r=Ms2ger
Use Option<T> to return from getters <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13100) <!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/htmlcollection.rs')
-rw-r--r--components/script/dom/htmlcollection.rs12
1 files changed, 4 insertions, 8 deletions
diff --git a/components/script/dom/htmlcollection.rs b/components/script/dom/htmlcollection.rs
index 95134556bc0..2f226590719 100644
--- a/components/script/dom/htmlcollection.rs
+++ b/components/script/dom/htmlcollection.rs
@@ -317,17 +317,13 @@ impl HTMLCollectionMethods for HTMLCollection {
}
// https://dom.spec.whatwg.org/#dom-htmlcollection-item
- fn IndexedGetter(&self, index: u32, found: &mut bool) -> Option<Root<Element>> {
- let maybe_elem = self.Item(index);
- *found = maybe_elem.is_some();
- maybe_elem
+ fn IndexedGetter(&self, index: u32) -> Option<Root<Element>> {
+ self.Item(index)
}
// check-tidy: no specs after this line
- fn NamedGetter(&self, name: DOMString, found: &mut bool) -> Option<Root<Element>> {
- let maybe_elem = self.NamedItem(name);
- *found = maybe_elem.is_some();
- maybe_elem
+ fn NamedGetter(&self, name: DOMString) -> Option<Root<Element>> {
+ self.NamedItem(name)
}
// https://dom.spec.whatwg.org/#interface-htmlcollection