diff options
author | Cameron Zwarich <zwarich@mozilla.com> | 2014-09-19 19:57:50 -0700 |
---|---|---|
committer | Cameron Zwarich <zwarich@mozilla.com> | 2014-09-20 11:54:11 -0700 |
commit | d768ee77adab5e5f53b7fb978c07ddbb798e8954 (patch) | |
tree | ec960fb625e8f3c1717e79e8aa27ccb93336c637 /components/script/dom/htmlanchorelement.rs | |
parent | 2c8d51a37c84fb5de531d00c45de9c0020930b11 (diff) | |
download | servo-d768ee77adab5e5f53b7fb978c07ddbb798e8954.tar.gz servo-d768ee77adab5e5f53b7fb978c07ddbb798e8954.zip |
Convert various helper traits from &JSRef to JSRef
I converted them all with a few exceptions:
- Methods that were used by trait objects, since trait objects don't
work with `self` methods.
- Methods that take an &'b JSRef<'a, T> and return an &'b. In reality,
many (all?) could return an &'a instead, but this isn't allowed by the
Deref trait.
- Methods that internally rely on the same issue with Deref.
- I left out the traits involved in layout entirely, even though not all
of their methods suffer from one of the above problems.
There will probably be solutions to all of these problems in the future.
Diffstat (limited to 'components/script/dom/htmlanchorelement.rs')
-rw-r--r-- | components/script/dom/htmlanchorelement.rs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/components/script/dom/htmlanchorelement.rs b/components/script/dom/htmlanchorelement.rs index 728b9c07fb6..6414c7d0c3c 100644 --- a/components/script/dom/htmlanchorelement.rs +++ b/components/script/dom/htmlanchorelement.rs @@ -50,19 +50,19 @@ impl HTMLAnchorElement { } trait PrivateHTMLAnchorElementHelpers { - fn handle_event_impl(&self, event: JSRef<Event>); + fn handle_event_impl(self, event: JSRef<Event>); } impl<'a> PrivateHTMLAnchorElementHelpers for JSRef<'a, HTMLAnchorElement> { - fn handle_event_impl(&self, event: JSRef<Event>) { + fn handle_event_impl(self, event: JSRef<Event>) { if "click" == event.Type().as_slice() && !event.DefaultPrevented() { - let element: JSRef<Element> = ElementCast::from_ref(*self); + let element: JSRef<Element> = ElementCast::from_ref(self); let attr = element.get_attribute(Null, "href").root(); match attr { Some(ref href) => { let value = href.Value(); debug!("clicked on link to {:s}", value); - let node: JSRef<Node> = NodeCast::from_ref(*self); + let node: JSRef<Node> = NodeCast::from_ref(self); let doc = node.owner_doc().root(); doc.load_anchor_href(value); } |