diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-02-14 19:25:49 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-02-14 19:25:49 -0800 |
commit | f3bacf84f47e12ef50cfd8ddd0aad613fe7e2a05 (patch) | |
tree | e91f34e09d07c978fbb3df4f752a974617c612d5 /components/script/dom/eventtarget.rs | |
parent | cc99d9400aa43673e8ce52c01607c62c1dfd118a (diff) | |
parent | 8f4282ef76bb0a2309657a542c8da733640201f2 (diff) | |
download | servo-f3bacf84f47e12ef50cfd8ddd0aad613fe7e2a05.tar.gz servo-f3bacf84f47e12ef50cfd8ddd0aad613fe7e2a05.zip |
Auto merge of #15539 - AdmiralCoco:reject_outofrange_transition_values, r=emilio
Add rejection of out-of-range values for single-timing-functions
<!-- Please describe your changes on the following line: -->
This PR fixes #15344, checking for the `cubic-bezier p1x/p2x` and `steps` first value after parsing.
There are unit tests that check for parsing of invalid values - I was not sure if there was a more suitable place, so I created a file (name subject to change).
Q: I found this [test suite](https://github.com/servo/servo/blob/master/tests/unit/style/properties/serialization.rs#L592), and noticed that the `p2x` value is out of range, but the test does not fail - is this because there is no check when calling the function itself?
Thanks!
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15344
<!-- Either: -->
- [X] There are tests for these changes
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15539)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/eventtarget.rs')
0 files changed, 0 insertions, 0 deletions