diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-11-12 14:29:20 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-11-12 14:29:20 -0500 |
commit | bd0ae59ca9b49c0cdfd343fca95c5f5d8cb6c279 (patch) | |
tree | 01a763b0a0d57b072b1ac18aac0198bb7a42d111 /components/script/dom/blob.rs | |
parent | 641c732281064280da9f370d942de7fb9807ee21 (diff) | |
parent | af158de5042fddf24c49627d45de05d269827119 (diff) | |
download | servo-bd0ae59ca9b49c0cdfd343fca95c5f5d8cb6c279.tar.gz servo-bd0ae59ca9b49c0cdfd343fca95c5f5d8cb6c279.zip |
Auto merge of #24576 - jaymodi98:iframe-srcdoc, r=jdm
Implement srcdoc support for iframes
<!-- Please describe your changes on the following line: -->
This PR contains changes related to adding srcdoc attribute parsing support for iframes in Servo. The following changes have been made:
- uncomment the [srcdoc](https://github.com/servo/servo/blob/f63b404e0cbf30380c4043700861110d06e548bb/components/script/dom/webidls/HTMLIFrameElement.webidl#L10-L11) WebIDL attribute, and implement the attribute getter.
- add a field to [LoadData](https://github.com/servo/servo/blob/e6b271d32981ad95442c029bf72bd35efc88f9c5/components/script_traits/lib.rs#L137-L164) for storing the srcdoc contents when loading a srcdoc iframe.
- (partially) implemented a new `page_load_about_srcdoc` method to `script_thread.rs` which loads the special `about:srcdoc` URL [per the specification](https://html.spec.whatwg.org/multipage/iframe-embed-object.html#process-the-iframe-attributes) and takes the srcdoc contents as an argument
- call this new method from [handle_new_layout](https://github.com/servo/servo/blob/e6b271d32981ad95442c029bf72bd35efc88f9c5/components/script/script_thread.rs#L2409-L2412) when it's detected that a srcdoc iframe is being loaded
- (partially) in [attribute_mutated](https://github.com/servo/servo/blob/e6b271d32981ad95442c029bf72bd35efc88f9c5/components/script/dom/htmliframeelement.rs#L560), ensure that changing the `srcdoc` attribute of an iframe element [follows the specification](https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-iframe-element:the-iframe-element-9).
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes are a part of fix #4767 (GitHub issue number if applicable)
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom/blob.rs')
0 files changed, 0 insertions, 0 deletions