diff options
author | Josh Matthews <josh@joshmatthews.net> | 2024-08-22 07:42:36 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-08-22 11:42:36 +0000 |
commit | 60ef6bc46125d34e492a4294622e2791f3c619b5 (patch) | |
tree | 8bc8a90f3a4647a7d6565065a8d73bd1b8f29d3d /components/script/dom/biquadfilternode.rs | |
parent | 9a1051c9170abc8e40c43b2a6be712a3ff4b523f (diff) | |
download | servo-60ef6bc46125d34e492a4294622e2791f3c619b5.tar.gz servo-60ef6bc46125d34e492a4294622e2791f3c619b5.zip |
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Propagate CanGc from reflect_dom_object_with_proto.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Mark DOM constructors as GC operations.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/biquadfilternode.rs')
-rw-r--r-- | components/script/dom/biquadfilternode.rs | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/components/script/dom/biquadfilternode.rs b/components/script/dom/biquadfilternode.rs index 385b002277a..face84bea74 100644 --- a/components/script/dom/biquadfilternode.rs +++ b/components/script/dom/biquadfilternode.rs @@ -27,6 +27,7 @@ use crate::dom::bindings::error::Fallible; use crate::dom::bindings::reflector::reflect_dom_object_with_proto; use crate::dom::bindings::root::{Dom, DomRoot}; use crate::dom::window::Window; +use crate::script_runtime::CanGc; #[dom_struct] pub struct BiquadFilterNode { @@ -117,7 +118,7 @@ impl BiquadFilterNode { context: &BaseAudioContext, options: &BiquadFilterOptions, ) -> Fallible<DomRoot<BiquadFilterNode>> { - Self::new_with_proto(window, None, context, options) + Self::new_with_proto(window, None, context, options, CanGc::note()) } #[allow(crown::unrooted_must_root)] @@ -126,19 +127,26 @@ impl BiquadFilterNode { proto: Option<HandleObject>, context: &BaseAudioContext, options: &BiquadFilterOptions, + can_gc: CanGc, ) -> Fallible<DomRoot<BiquadFilterNode>> { let node = BiquadFilterNode::new_inherited(window, context, options)?; - Ok(reflect_dom_object_with_proto(Box::new(node), window, proto)) + Ok(reflect_dom_object_with_proto( + Box::new(node), + window, + proto, + can_gc, + )) } #[allow(non_snake_case)] pub fn Constructor( window: &Window, proto: Option<HandleObject>, + can_gc: CanGc, context: &BaseAudioContext, options: &BiquadFilterOptions, ) -> Fallible<DomRoot<BiquadFilterNode>> { - BiquadFilterNode::new_with_proto(window, proto, context, options) + BiquadFilterNode::new_with_proto(window, proto, context, options, can_gc) } } |