diff options
author | Nathan Froyd <froydnj@gmail.com> | 2015-10-27 14:14:11 -0400 |
---|---|---|
committer | Nathan Froyd <froydnj@gmail.com> | 2015-10-27 18:08:35 -0400 |
commit | c82b6ce8431e1379b7bd4689c2aadadbdc65c8b7 (patch) | |
tree | 48d55373d6d3952898b29c63937cab200676e437 /components/script/dom/bindings/utils.rs | |
parent | 3d39646c8e89c304cbae0c2490f2b82e47ccb7c5 (diff) | |
download | servo-c82b6ce8431e1379b7bd4689c2aadadbdc65c8b7.tar.gz servo-c82b6ce8431e1379b7bd4689c2aadadbdc65c8b7.zip |
move reserved slot setting for DOM globals
Moving this slot setting prior to initializing standard classes and
other initialization tasks means that we can effectively use JS_GC_ZEAL.
Fixes #6057.
Diffstat (limited to 'components/script/dom/bindings/utils.rs')
-rw-r--r-- | components/script/dom/bindings/utils.rs | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/components/script/dom/bindings/utils.rs b/components/script/dom/bindings/utils.rs index 27fdb3efa9c..45a06674cfc 100644 --- a/components/script/dom/bindings/utils.rs +++ b/components/script/dom/bindings/utils.rs @@ -9,7 +9,7 @@ use dom::bindings::codegen::PrototypeList; use dom::bindings::codegen::PrototypeList::MAX_PROTO_CHAIN_LENGTH; use dom::bindings::conversions::native_from_handleobject; use dom::bindings::conversions::private_from_proto_check; -use dom::bindings::conversions::{is_dom_class, jsstring_to_str}; +use dom::bindings::conversions::{is_dom_class, jsstring_to_str, DOM_OBJECT_SLOT}; use dom::bindings::error::throw_type_error; use dom::bindings::error::{Error, ErrorResult, Fallible, throw_invalid_this}; use dom::bindings::global::GlobalRef; @@ -625,6 +625,7 @@ pub fn has_property_on_prototype(cx: *mut JSContext, proxy: HandleObject, /// Create a DOM global object with the given class. pub fn create_dom_global(cx: *mut JSContext, class: *const JSClass, + private: *const libc::c_void, trace: JSTraceOp) -> *mut JSObject { unsafe { @@ -640,6 +641,7 @@ pub fn create_dom_global(cx: *mut JSContext, class: *const JSClass, return ptr::null_mut(); } let _ac = JSAutoCompartment::new(cx, obj.ptr); + JS_SetReservedSlot(obj.ptr, DOM_OBJECT_SLOT, PrivateValue(private)); JS_InitStandardClasses(cx, obj.handle()); initialize_global(obj.ptr); JS_FireOnNewGlobalObject(cx, obj.handle()); |