When converting a non-finite float, throw the TypeError from the FromJSValConvertible implementation.

This removes some unnecessary custom code in the codegen and makes this
implementation follow the convention of having thrown an exception when
returning Err() from FromJSValConvertible.

1 files changed, 6 insertions, 17 deletions

diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py
index b828ccb74bd..adebf601568 100644
--- a/components/script/dom/bindings/codegen/CodegenRust.py
+++ b/components/script/dom/bindings/codegen/CodegenRust.py
@@ -887,23 +887,12 @@ def getJSToNativeConversionInfo(type, descriptorProvider, failureCode=None,
     if type.nullable():
         declType = CGWrapper(declType, pre="Option<", post=">")
 
-    template = ""
-    if type.isFloat() and not type.isUnrestricted():
-        template = (
-            "match FromJSValConvertible::from_jsval(cx, ${val}, ()) {\n"
-            "    Ok(v) => v,\n"
-            "    Err(_) => {\n"
-            "       throw_type_error(cx, \"this argument is not a finite floating-point value\");\n"
-            "       %s\n"
-            "    }\n"
-            "}" % exceptionCode)
-    else:
-        #XXXjdm support conversionBehavior here
-        template = (
-            "match FromJSValConvertible::from_jsval(cx, ${val}, ()) {\n"
-            "    Ok(v) => v,\n"
-            "    Err(_) => { %s }\n"
-            "}" % exceptionCode)
+    #XXXjdm support conversionBehavior here
+    template = (
+        "match FromJSValConvertible::from_jsval(cx, ${val}, ()) {\n"
+        "    Ok(v) => v,\n"
+        "    Err(_) => { %s }\n"
+        "}" % exceptionCode)
 
     if defaultValue is not None:
         if isinstance(defaultValue, IDLNullValue):