diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2020-02-24 17:25:02 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-02-24 17:25:02 -0500 |
| commit | 0884884796d90833a71b6526d4771bfdd45c6e57 (patch) | |
| tree | 553ae6326639125b53b51da9df4e48a8e710d474 /components/script/dom/bindings/codegen | |
| parent | 876f455901e18d9cb43daa83c9f96a35b8e458be (diff) | |
| parent | 1449bac0e19bfafbb14a71c3bb246ad28ddbf8e8 (diff) | |
| download | servo-0884884796d90833a71b6526d4771bfdd45c6e57.tar.gz servo-0884884796d90833a71b6526d4771bfdd45c6e57.zip | |
Auto merge of #25345 - jdm:drop-cleanup, r=asajeffrey
Avoid accessing global objects from DOM destructors
This removes all instances that I could find of DOM objects accessing `self.global()` in code that runs as part of a Drop method. This is unsafe because the GC could destroy objects in any order when doing a big sweep. Instead, these types should store the data they need as members so they can run in isolation without accessing the rest of the GC graph as part of their destructors.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25258 and fix #23986
- [x] There are tests for these changes
Diffstat (limited to 'components/script/dom/bindings/codegen')
0 files changed, 0 insertions, 0 deletions