diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-09-30 14:47:18 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-09-30 14:47:18 -0400 |
commit | ebd59ef4f40852f64cbf14bd5cd2fcc7e6431b7d (patch) | |
tree | 80768fe2ca5c9ea2b2dc31f14fe0ba9e8e801bb6 /components/script/dom/bindings/codegen/parser/tests | |
parent | 45b68ecbfc08738fd731383f6369725eef598105 (diff) | |
parent | 81b7f046bfbc9b51a4a2b81e4640f39c03255223 (diff) | |
download | servo-ebd59ef4f40852f64cbf14bd5cd2fcc7e6431b7d.tar.gz servo-ebd59ef4f40852f64cbf14bd5cd2fcc7e6431b7d.zip |
Auto merge of #24319 - servo:webidl-lint, r=jdm
Remove redundant webidl_must_inherit compiler plugin lint
At first I was considering moving it to a procedural macro (source-level information should be sufficient), and started by trying to reproduce the error case by changing `htmldivelement.rs` to use `Element` instead of `HTMLElement` as the first field.
The output was:
```rust
error[E0308]: mismatched types
--> /home/simon/servo2/target/debug/build/script-4caa244faca7d10f/out/Bindings/HTMLDivElementBinding.rs:665:31
|
665 | let _: &HTMLElement = self.as_parent();
| ^^^^^^^^^^^^^^^^ expected struct `dom::htmlelement::HTMLElement`, found struct `dom::element::Element`
|
= note: expected type `&dom::htmlelement::HTMLElement`
found type `&dom::element::Element`
```
This line number is inside a generated method called `__assert_parent_type`. As far as I can tell, any case where this lint would error is already caught by such methods. The lint is therefore redundant and can safely be removed.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24319)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/bindings/codegen/parser/tests')
0 files changed, 0 insertions, 0 deletions