aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/bindings/codegen/GlobalGen.py
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2019-09-24 13:40:38 -0400
committerGitHub <noreply@github.com>2019-09-24 13:40:38 -0400
commit5ab2d4ea835374c2ca88f5d9b50100669f142273 (patch)
treefb45f093a4874bfcb99ce75cec898f18c6496afe /components/script/dom/bindings/codegen/GlobalGen.py
parentb68e00069a1ac0b55baf37c70a241fea0c7d81fc (diff)
parentd0c64d347d1b8c42af2a4d5e30a68867af871834 (diff)
downloadservo-5ab2d4ea835374c2ca88f5d9b50100669f142273.tar.gz
servo-5ab2d4ea835374c2ca88f5d9b50100669f142273.zip
Auto merge of #24217 - tdelacour:ISSUE-23995, r=jdm
ISSUE-23995: lazily generate UniqueIds for Nodes <!-- Please describe your changes on the following line: --> Updated `Node` so that its `unique_id` is only generated when `unique_id()` is called. This getter now also has assumed the responsibility for saving the `id` to the global hashset on `ScriptThread`. Felt like I was fighting the borrow-checker a little bit on this one. Definitely a good learning experience for me, but the result strikes me as a little messy? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23995 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24217) <!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom/bindings/codegen/GlobalGen.py')
0 files changed, 0 insertions, 0 deletions