aboutsummaryrefslogtreecommitdiffstats
path: root/components/layout_2020/geom.rs
diff options
context:
space:
mode:
authorMartin Robinson <mrobinson@igalia.com>2024-04-21 22:09:49 +0200
committerGitHub <noreply@github.com>2024-04-21 20:09:49 +0000
commita7838ae7ccb5e2d8b02f047ce9e5263195b366ab (patch)
tree6a8f1ef7e658afbdec5841ee27ccee55a05acde5 /components/layout_2020/geom.rs
parentfa92b0f65f5cbc016474eae16ef5c387edd27f89 (diff)
downloadservo-a7838ae7ccb5e2d8b02f047ce9e5263195b366ab.tar.gz
servo-a7838ae7ccb5e2d8b02f047ce9e5263195b366ab.zip
layout: Have `TextRun::glyph_run_is_preserved_newline` take into account `TextRunSegment` offset (#32119)
A `TextRun` is composed of `TextRunSegment`s that are composed of `GlyphRun`s. `TextRun::glyph_run_is_preserved_newline` is indexing into the `TextRun` text, but the `GlyphRun` indexes that it uses are relative to the `TextRunSegment` offset. Before the code was using the offset without incorporating the `TextRunSegment` offset. This led to miscalculation of preserved newline location while processing text content. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/layout_2020/geom.rs')
0 files changed, 0 insertions, 0 deletions