diff options
author | atbrakhi <atbrakhi@igalia.com> | 2025-04-21 17:43:56 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-04-21 15:43:56 +0000 |
commit | 15301df799564724f88588aa7ab8d435b28c1110 (patch) | |
tree | 134a8dd5d9e632cb09c3f8b8541467f484fea779 /components/layout_2020/cell.rs | |
parent | 9a14ad8535efa05b185b46c59e03d127dd6149ad (diff) | |
download | servo-15301df799564724f88588aa7ab8d435b28c1110.tar.gz servo-15301df799564724f88588aa7ab8d435b28c1110.zip |
DevTools: `worker_id` shoud be `id` & thread for workers should be `thread` (#36631)
This is part of https://github.com/servo/servo/pull/36562, where I
discovered that we are sending thread as `context` and `id` for worker
is called `worked_id`. In this PR, I have renamed the `worker_id` to
`id` and thread is sent as `thread` and not context. These chages were
tested in #36562
Some logs for context(this logs are from firefox instance)
`worker_id` should be `id`
```
{"_from": "server1.conn0.watcher35", "message": {"from": "server1.conn0.watcher35", "target": {"actor": "server1.conn0.watcher34.process7//workerTarget21/workerTarget5", "consoleActor": "server1.conn0.watcher34.process7//workerTarget21/console2", "id": "f454ea34-c76a-4b6e-a079-43ee3128881e", "name": "", "objectsManagerActor": "server1.conn0.watcher34.process7//workerTarget21/objects-manager4", "relatedDocumentInnerWindowId": 15032385539, "targetType": "worker", "threadActor": "server1.conn0.watcher34.process7//workerTarget21/thread1", "tracerActor": "server1.conn0.watcher34.process7//workerTarget21/tracer3", "traits": {"supportsTopLevelTargetFlag": false}, "type": 0, "url": "http://localhost:8000/Documents/codespace/servo/worker.js"}, "type": "target-available-form"}}
```
Thread should be `thread` and not `context`
```
{"_from": "server1.conn0.watcher35", "message": {"from": "server1.conn0.watcher35", "target": {"actor": "server1.conn0.watcher34.process7//workerTarget21/workerTarget5", "consoleActor": "server1.conn0.watcher34.process7//workerTarget21/console2", "id": "f454ea34-c76a-4b6e-a079-43ee3128881e", "name": "", "objectsManagerActor": "server1.conn0.watcher34.process7//workerTarget21/objects-manager4", "relatedDocumentInnerWindowId": 15032385539, "targetType": "worker", "threadActor": "server1.conn0.watcher34.process7//workerTarget21/thread1", "tracerActor": "server1.conn0.watcher34.process7//workerTarget21/tracer3", "traits": {"supportsTopLevelTargetFlag": false}, "type": 0, "url": "http://localhost:8000/Documents/codespace/servo/worker.js"}, "type": "target-available-form"}}
```
- [x] ./mach build -d does not report any errors
- [x] ./mach test-tidy does not report any errors
- [x] These changes partially implement
https://github.com/servo/servo/issues/36027
Signed-off-by: atbrakhi <atbrakhi@igalia.com>
Diffstat (limited to 'components/layout_2020/cell.rs')
0 files changed, 0 insertions, 0 deletions