Auto merge of #22133 - servo:extern-crate, r=SimonSapin

Use 2018-edition idioms in crates that use that edition

The first commit is almost entirely mechanical, created by running `cargo fix --edition-idioms` and relevant crates. I undid the change of adding an anonymous lifetime parameter in types that have implicit lifetimes parameters, for example replacing `&mut Formatter` with `&mut Formatter<'_>`, because I don’t like it. The remaining changes are, in many places:

* Add `dyn` to trait object types, for example `Rc<gl::Gl>` to `Rc<dyn gl::Gl>`. This change also works in the 2015 edition.
* Remove `extern crate` where is it made unneeded by changes to the import/module system.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22133)
<!-- Reviewable:end -->

1 files changed, 0 insertions, 59 deletions

diff --git a/components/gfx/lib.rs b/components/gfx/lib.rs
index 442a9c8ae3a..24dbcde26cb 100644
--- a/components/gfx/lib.rs
+++ b/components/gfx/lib.rs
@@ -4,75 +4,16 @@
 
 #![deny(unsafe_code)]
 
-extern crate app_units;
 #[macro_use]
 extern crate bitflags;
-
-// Mac OS-specific library dependencies
-#[cfg(target_os = "macos")]
-extern crate byteorder;
-#[cfg(target_os = "macos")]
-extern crate core_foundation;
-#[cfg(target_os = "macos")]
-extern crate core_graphics;
-#[cfg(target_os = "macos")]
-extern crate core_text;
-
-// Windows-specific library dependencies
-#[cfg(target_os = "windows")]
-extern crate dwrote;
-
-extern crate euclid;
-extern crate fnv;
-
-#[cfg(target_os = "linux")]
-extern crate fontconfig;
-extern crate fontsan;
-#[cfg(any(target_os = "linux", target_os = "android"))]
-extern crate freetype;
-extern crate gfx_traits;
-
-// Eventually we would like the shaper to be pluggable, as many operating systems have their own
-// shapers. For now, however, this is a hard dependency.
-extern crate harfbuzz_sys as harfbuzz;
-
-extern crate ipc_channel;
 #[macro_use]
 extern crate lazy_static;
-#[cfg(any(target_os = "linux", target_os = "android"))]
-extern crate libc;
 #[macro_use]
 extern crate log;
-#[cfg_attr(target_os = "windows", macro_use)]
-extern crate malloc_size_of;
-extern crate net_traits;
-extern crate ordered_float;
-#[cfg(all(
-    feature = "unstable",
-    any(target_feature = "sse2", target_feature = "neon")
-))]
-extern crate packed_simd;
-extern crate range;
 #[macro_use]
 extern crate serde;
-#[cfg(any(target_os = "linux", target_os = "android"))]
-extern crate servo_allocator;
-extern crate servo_arc;
 #[macro_use]
 extern crate servo_atoms;
-extern crate servo_url;
-extern crate smallvec;
-extern crate style;
-extern crate time;
-#[cfg(target_os = "windows")]
-extern crate truetype;
-extern crate ucd;
-extern crate unicode_bidi;
-extern crate unicode_script;
-extern crate webrender_api;
-extern crate xi_unicode;
-#[cfg(target_os = "android")]
-extern crate xml5ever;
 
 // Fonts
 #[macro_use]