api: Flatten and simplify Servo preferences (#34966)

Flatten and simplify Servo's preferences code. In addition, have both
preferences and options passed in as arguments to `Servo::new()` and
make sure not to use the globally set preferences in `servoshell` (as
much as possible now).

Instead of a complex procedural macro to generate preferences, just
expose a very simple derive macro that adds string based getters and
setters.

- All command-line parsing is moved to servoshell.
- There is no longer the concept of a missing preference.
- Preferences no longer have to be part of the resources bundle because
  they now have reasonable default values.
- servoshell specific preferences are no longer part of the preferences
  exposed by the Servo API.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/components/fonts/system_font_service.rs b/components/fonts/system_font_service.rs
index 42acc5ab85b..b29eca6b86c 100644
--- a/components/fonts/system_font_service.rs
+++ b/components/fonts/system_font_service.rs
@@ -323,10 +323,10 @@ impl SystemFontService {
             .get_or_init(|| {
                 // First check whether the font is set in the preferences.
                 let family_name = match generic {
-                    GenericFontFamily::None => pref!(fonts.default),
-                    GenericFontFamily::Serif => pref!(fonts.serif),
-                    GenericFontFamily::SansSerif => pref!(fonts.sans_serif),
-                    GenericFontFamily::Monospace => pref!(fonts.monospace),
+                    GenericFontFamily::None => pref!(fonts_default),
+                    GenericFontFamily::Serif => pref!(fonts_serif),
+                    GenericFontFamily::SansSerif => pref!(fonts_sans_serif),
+                    GenericFontFamily::Monospace => pref!(fonts_monospace),
                     _ => String::new(),
                 };