diff options
author | bors-servo <infra@servo.org> | 2023-05-13 05:48:04 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-05-13 05:48:04 +0200 |
commit | 45dd2764af657948aa2124473e562ead5622b33c (patch) | |
tree | a75e701059b6556e86dd9267c0cb5538428a7bf4 /components/canvas | |
parent | 84982ff1ffa3de0dc45aef9e996c4b1c5c9b57e7 (diff) | |
parent | 80087f31c885692569a8ba235327efd055b7e565 (diff) | |
download | servo-45dd2764af657948aa2124473e562ead5622b33c.tar.gz servo-45dd2764af657948aa2124473e562ead5622b33c.zip |
Auto merge of #29733 - mukilan:workaround-gstreamer-dylib-issue, r=mrobinson
Workaround bug in gstreamer binaries
The official gstreamer .pkg distribution should contain 'relocatable' dylibs, but as discovered in #29732, some dylibs have absolute links to liblzma.5.dylib ("/usr/local/opt/xz/lib/liblzma.5.dylib")
Since /opt/homebrew is the default install location on Apple Silicion, this will cause the packaging & build steps to fail, even if 'xz' package is installed via homebrew.
This is a temporary fix until upstream fixes the bug and makes the package truly 'relocatable'. Users
with non-default homebrew prefixes will still have the issue.
Thanks to @atbrakhi for helping me debug and test the patch on her mac.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #29732 (GitHub issue number if applicable)
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they fix the broken build process.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/canvas')
0 files changed, 0 insertions, 0 deletions