aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEmilio Cobos Álvarez <emilio@crisal.io>2017-05-23 15:49:46 +0200
committerEmilio Cobos Álvarez <emilio@crisal.io>2017-05-23 15:52:48 +0200
commitfa93d820413224fffe759999ade98897846a202e (patch)
tree78544ad87f6f4e6f3a87e80b0b11fd48abd80c9c
parente24d96cdd04fb40c0681a6ba46476ba04607f573 (diff)
downloadservo-fa93d820413224fffe759999ade98897846a202e.tar.gz
servo-fa93d820413224fffe759999ade98897846a202e.zip
style: Reject non-positive resolution values in media queries.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1366961 See: https://github.com/w3c/csswg-drafts/issues/1454
-rw-r--r--components/style/gecko/media_queries.rs4
1 files changed, 4 insertions, 0 deletions
diff --git a/components/style/gecko/media_queries.rs b/components/style/gecko/media_queries.rs
index 2444338f174..ff08fcc0813 100644
--- a/components/style/gecko/media_queries.rs
+++ b/components/style/gecko/media_queries.rs
@@ -181,6 +181,10 @@ impl Resolution {
_ => return Err(()),
};
+ if value <= 0. {
+ return Err(())
+ }
+
Ok(match_ignore_ascii_case! { &unit,
"dpi" => Resolution::Dpi(value),
"dppx" => Resolution::Dppx(value),