Auto merge of #8505 - frewsxcv:html-table-cell-element-bgcolor-idl-attribute, r=Ms2ger

Implement 'bgcolor' IDL attribute for 'HTMLTableCellElement'

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8505)
<!-- Reviewable:end -->

4 files changed, 7 insertions, 268 deletions

diff --git a/components/script/dom/htmltablecellelement.rs b/components/script/dom/htmltablecellelement.rs
index f9754dc9a5b..88730779ce2 100644
--- a/components/script/dom/htmltablecellelement.rs
+++ b/components/script/dom/htmltablecellelement.rs
@@ -50,6 +50,12 @@ impl HTMLTableCellElementMethods for HTMLTableCellElement {
     // https://html.spec.whatwg.org/multipage/#dom-tdth-colspan
     make_uint_setter!(SetColSpan, "colspan", DEFAULT_COLSPAN);
 
+    // https://html.spec.whatwg.org/multipage/#dom-tdth-bgcolor
+    make_getter!(BgColor);
+
+    // https://html.spec.whatwg.org/multipage/#dom-tdth-bgcolor
+    make_legacy_color_setter!(SetBgColor, "bgcolor");
+
     // https://html.spec.whatwg.org/multipage/#dom-tdth-cellindex
     fn CellIndex(&self) -> i32 {
         let self_node = self.upcast::<Node>();
diff --git a/components/script/dom/webidls/HTMLTableCellElement.webidl b/components/script/dom/webidls/HTMLTableCellElement.webidl
index 7db825376c4..b259d9ff6a3 100644
--- a/components/script/dom/webidls/HTMLTableCellElement.webidl
+++ b/components/script/dom/webidls/HTMLTableCellElement.webidl
@@ -26,5 +26,5 @@ partial interface HTMLTableCellElement {
   //         attribute boolean noWrap;
   //         attribute DOMString vAlign;
 
-  //[TreatNullAs=EmptyString] attribute DOMString bgColor;
+  [TreatNullAs=EmptyString] attribute DOMString bgColor;
 };
diff --git a/tests/wpt/metadata/html/dom/interfaces.html.ini b/tests/wpt/metadata/html/dom/interfaces.html.ini
index 58989e8e793..d6b47d19710 100644
--- a/tests/wpt/metadata/html/dom/interfaces.html.ini
+++ b/tests/wpt/metadata/html/dom/interfaces.html.ini
@@ -4713,9 +4713,6 @@
   [HTMLTableCellElement interface: document.createElement("td") must inherit property "vAlign" with the proper type (11)]
     expected: FAIL
 
-  [HTMLTableCellElement interface: document.createElement("td") must inherit property "bgColor" with the proper type (12)]
-    expected: FAIL
-
   [HTMLTableHeaderCellElement interface: existence and properties of interface object]
     expected: FAIL
 
@@ -4773,9 +4770,6 @@
   [HTMLTableCellElement interface: document.createElement("th") must inherit property "vAlign" with the proper type (11)]
     expected: FAIL
 
-  [HTMLTableCellElement interface: document.createElement("th") must inherit property "bgColor" with the proper type (12)]
-    expected: FAIL
-
   [HTMLTableCellElement interface: existence and properties of interface object]
     expected: FAIL
 
@@ -4809,9 +4803,6 @@
   [HTMLTableCellElement interface: attribute vAlign]
     expected: FAIL
 
-  [HTMLTableCellElement interface: attribute bgColor]
-    expected: FAIL
-
   [HTMLFormElement interface: existence and properties of interface object]
     expected: FAIL
 
diff --git a/tests/wpt/metadata/html/dom/reflection-tabular.html.ini b/tests/wpt/metadata/html/dom/reflection-tabular.html.ini
index 162619b69df..d811878a489 100644
--- a/tests/wpt/metadata/html/dom/reflection-tabular.html.ini
+++ b/tests/wpt/metadata/html/dom/reflection-tabular.html.ini
@@ -12345,135 +12345,6 @@
   [td.vAlign: IDL set to object "test-valueOf" followed by IDL get]
     expected: FAIL
 
-  [td.bgColor: typeof IDL attribute]
-    expected: FAIL
-
-  [td.bgColor: IDL get with DOM attribute unset]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to "" followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f  foo " followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to undefined followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to 7 followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to 1.5 followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to true followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to false followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to object "[object Object\]" followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to NaN followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to Infinity followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to -Infinity followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to "\\0" followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to null followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to object "test-toString" followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: setAttribute() to object "test-valueOf" followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: IDL set to "" followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f  foo " followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to undefined followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to undefined followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: IDL set to 7 followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to 7 followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: IDL set to 1.5 followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to 1.5 followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: IDL set to true followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to true followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: IDL set to false followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to false followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: IDL set to object "[object Object\]" followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to object "[object Object\]" followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: IDL set to NaN followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to NaN followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: IDL set to Infinity followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to Infinity followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: IDL set to -Infinity followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to -Infinity followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: IDL set to "\\0" followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to null followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to null followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: IDL set to object "test-toString" followed by getAttribute()]
-    expected: FAIL
-
-  [td.bgColor: IDL set to object "test-toString" followed by IDL get]
-    expected: FAIL
-
-  [td.bgColor: IDL set to object "test-valueOf" followed by IDL get]
-    expected: FAIL
-
   [td.abbr: typeof IDL attribute]
     expected: FAIL
 
@@ -14529,135 +14400,6 @@
   [th.vAlign: IDL set to object "test-valueOf" followed by IDL get]
     expected: FAIL
 
-  [th.bgColor: typeof IDL attribute]
-    expected: FAIL
-
-  [th.bgColor: IDL get with DOM attribute unset]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to "" followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f  foo " followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to undefined followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to 7 followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to 1.5 followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to true followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to false followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to object "[object Object\]" followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to NaN followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to Infinity followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to -Infinity followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to "\\0" followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to null followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to object "test-toString" followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: setAttribute() to object "test-valueOf" followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: IDL set to "" followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f  foo " followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to undefined followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to undefined followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: IDL set to 7 followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to 7 followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: IDL set to 1.5 followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to 1.5 followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: IDL set to true followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to true followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: IDL set to false followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to false followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: IDL set to object "[object Object\]" followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to object "[object Object\]" followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: IDL set to NaN followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to NaN followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: IDL set to Infinity followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to Infinity followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: IDL set to -Infinity followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to -Infinity followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: IDL set to "\\0" followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to null followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to null followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: IDL set to object "test-toString" followed by getAttribute()]
-    expected: FAIL
-
-  [th.bgColor: IDL set to object "test-toString" followed by IDL get]
-    expected: FAIL
-
-  [th.bgColor: IDL set to object "test-valueOf" followed by IDL get]
-    expected: FAIL
-
   [th.scope: typeof IDL attribute]
     expected: FAIL