diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-04-05 10:51:09 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-04-05 10:51:09 -0400 |
commit | e7b65c42c42bcf4c7e68822108cf5e0989bf72c6 (patch) | |
tree | 83132912b43f6a12a4445c886cd3d4cb1902fe43 | |
parent | 5defd51ba7ffa76dda9c6ab3bca7104eb968df07 (diff) | |
parent | e88858388a250738153202666a90fae157d09ca0 (diff) | |
download | servo-e7b65c42c42bcf4c7e68822108cf5e0989bf72c6.tar.gz servo-e7b65c42c42bcf4c7e68822108cf5e0989bf72c6.zip |
Auto merge of #23143 - CYBAI:remove-compound-microtasks, r=jdm
Remove compound microtasks
We handled compound microtasks as microtasks so, basically, we only need
to remove the naming of `compound`.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23140
- [x] These changes do not require tests because the updated spec is more about editorial.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23143)
<!-- Reviewable:end -->
-rw-r--r-- | components/script/dom/mutationobserver.rs | 10 | ||||
-rw-r--r-- | components/script/script_thread.rs | 16 |
2 files changed, 11 insertions, 15 deletions
diff --git a/components/script/dom/mutationobserver.rs b/components/script/dom/mutationobserver.rs index 4829be6a122..b25f99d0861 100644 --- a/components/script/dom/mutationobserver.rs +++ b/components/script/dom/mutationobserver.rs @@ -90,13 +90,13 @@ impl MutationObserver { } /// <https://dom.spec.whatwg.org/#queue-a-mutation-observer-compound-microtask> - pub fn queue_mutation_observer_compound_microtask() { + pub fn queue_mutation_observer_microtask() { // Step 1 - if ScriptThread::is_mutation_observer_compound_microtask_queued() { + if ScriptThread::is_mutation_observer_microtask_queued() { return; } // Step 2 - ScriptThread::set_mutation_observer_compound_microtask_queued(true); + ScriptThread::set_mutation_observer_microtask_queued(true); // Step 3 ScriptThread::enqueue_microtask(Microtask::NotifyMutationObservers); } @@ -104,7 +104,7 @@ impl MutationObserver { /// <https://dom.spec.whatwg.org/#notify-mutation-observers> pub fn notify_mutation_observers() { // Step 1 - ScriptThread::set_mutation_observer_compound_microtask_queued(false); + ScriptThread::set_mutation_observer_microtask_queued(false); // Step 2 let notify_list = ScriptThread::get_mutation_observers(); // TODO: steps 3-4 (slots) @@ -239,7 +239,7 @@ impl MutationObserver { } // Step 5 - MutationObserver::queue_mutation_observer_compound_microtask(); + MutationObserver::queue_mutation_observer_microtask(); } } diff --git a/components/script/script_thread.rs b/components/script/script_thread.rs index 78b7a8606b0..28a9a52566f 100644 --- a/components/script/script_thread.rs +++ b/components/script/script_thread.rs @@ -615,7 +615,7 @@ pub struct ScriptThread { microtask_queue: Rc<MicrotaskQueue>, /// Microtask Queue for adding support for mutation observer microtasks - mutation_observer_compound_microtask_queued: Cell<bool>, + mutation_observer_microtask_queued: Cell<bool>, /// The unit of related similar-origin browsing contexts' list of MutationObserver objects mutation_observers: DomRefCell<Vec<Dom<MutationObserver>>>, @@ -767,21 +767,17 @@ impl ScriptThread { }) } - pub fn set_mutation_observer_compound_microtask_queued(value: bool) { + pub fn set_mutation_observer_microtask_queued(value: bool) { SCRIPT_THREAD_ROOT.with(|root| { let script_thread = unsafe { &*root.get().unwrap() }; - script_thread - .mutation_observer_compound_microtask_queued - .set(value); + script_thread.mutation_observer_microtask_queued.set(value); }) } - pub fn is_mutation_observer_compound_microtask_queued() -> bool { + pub fn is_mutation_observer_microtask_queued() -> bool { SCRIPT_THREAD_ROOT.with(|root| { let script_thread = unsafe { &*root.get().unwrap() }; - return script_thread - .mutation_observer_compound_microtask_queued - .get(); + return script_thread.mutation_observer_microtask_queued.get(); }) } @@ -1145,7 +1141,7 @@ impl ScriptThread { microtask_queue: Default::default(), - mutation_observer_compound_microtask_queued: Default::default(), + mutation_observer_microtask_queued: Default::default(), mutation_observers: Default::default(), |