diff options
| author | Mukilan Thiyagarajan <mukilan@igalia.com> | 2024-10-26 14:27:10 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-10-26 08:57:10 +0000 |
| commit | 831a65917a1ffa3f24fcc67ea0955a9d15d7d449 (patch) | |
| tree | 3aee922bb48173ed30b49ec0e72dee8744437c9d | |
| parent | 5d4b5514aa339d115d0ac9e1131eb7bef1d99a0b (diff) | |
| download | servo-831a65917a1ffa3f24fcc67ea0955a9d15d7d449.tar.gz servo-831a65917a1ffa3f24fcc67ea0955a9d15d7d449.zip | |
ci: pin python to 3.12 for mac workflows (#34022)
wptrunner breaks macos builds because it doesn't work well with 3.13 due
to two issues:
1. The current version (10.3.0) of the 'pillow' dependency of wptrunner
breaks with >=3.13 and needs to be upgraded.
2. Python 3.13 has removed the 'cgi' module which was deprecated in 3.11
and has no direct replacement. There are two files in wptrunner that
use the cgi module and one of them is the vendored 'html5lib'.
As a quick fix, pin the Python version on MacOS runner until
web-platform-tests/wpt#48585 is addressed.
Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
| -rw-r--r-- | .github/workflows/mac-wpt.yml | 5 | ||||
| -rw-r--r-- | .github/workflows/mac.yml | 5 |
2 files changed, 10 insertions, 0 deletions
diff --git a/.github/workflows/mac-wpt.yml b/.github/workflows/mac-wpt.yml index 9e0e5da91c5..74a1e1439fe 100644 --- a/.github/workflows/mac-wpt.yml +++ b/.github/workflows/mac-wpt.yml @@ -41,6 +41,11 @@ jobs: - uses: actions/download-artifact@v4 with: name: ${{ inputs.profile }}-binary-macos + # Python 3.13 breaks wptrunner, so pin the version until + # web-platform-tests/wpt#48585 is fixed. + - uses: actions/setup-python@v5 + with: + python-version: '3.12' - name: Prep test environment run: | gtar -xzf target.tar.gz diff --git a/.github/workflows/mac.yml b/.github/workflows/mac.yml index fa67139a107..cf9939efe4e 100644 --- a/.github/workflows/mac.yml +++ b/.github/workflows/mac.yml @@ -77,6 +77,11 @@ jobs: if: github.event_name == 'pull_request_target' with: ref: ${{ github.event.pull_request.head.sha }} + # Python 3.13 breaks wptrunner, so pin the version until + # web-platform-tests/wpt#48585 is fixed. + - uses: actions/setup-python@v5 + with: + python-version: '3.12' - name: Run sccache-cache uses: mozilla-actions/sccache-action@v0.0.6 - name: Install crown |