diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-07-21 00:22:47 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-07-21 00:22:47 -0400 |
commit | 4128a3893662c61a19b9316cd19eab7533518453 (patch) | |
tree | bc0db6886822b935a64b6c9c9e6cfedf6a77fdc9 | |
parent | 510ffde3f18d02f19be1e90baa903239922a8e49 (diff) | |
parent | c04d32da13aa92d63084d4c2837676752eb9d646 (diff) | |
download | servo-4128a3893662c61a19b9316cd19eab7533518453.tar.gz servo-4128a3893662c61a19b9316cd19eab7533518453.zip |
Auto merge of #23819 - larsbergstrom:update_windows_readme, r=jdm
Fix Python and gstreamer instructions for Windows
<!-- Please describe your changes on the following line: -->
Improved the README.md to address missing information for bootstrapping a Windows build.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x ] `./mach build -d` does not report any errors
- [x ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x ] These changes do not require tests because README changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23819)
<!-- Reviewable:end -->
-rw-r--r-- | README.md | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/README.md b/README.md index 47c8c99213e..3703cf90e3c 100644 --- a/README.md +++ b/README.md @@ -209,9 +209,12 @@ export LIBCLANG_PATH=$(llvm-config --prefix)/lib64 ``` #### On Windows (MSVC) -1. Install Python for Windows (https://www.python.org/downloads/release/python-2716/). The Windows x86-64 MSI installer is fine. +1. Install Python 2.7 for Windows (https://www.python.org/downloads/release/python-2716/). The Windows x86-64 MSI installer is fine. This is required for the build system execution and many dependencies. + You should change the installation to install the "Add python.exe to Path" feature. +2. Install Python 3.7 for Windows (https://www.python.org/downloads/release/python-374/). The Windows x86-64 MSI installer is fine. This is required in order to build the JavaScript engine, SpiderMonkey. + 2. Install virtualenv. In a normal Windows Shell (cmd.exe or "Command Prompt" from the start menu), do: @@ -222,6 +225,8 @@ pip install virtualenv 3. Install the most recent [GStreamer](https://gstreamer.freedesktop.org/data/pkg/windows/) development package following [these instructions](https://github.com/sdroege/gstreamer-rs#gstreamer-binaries-1). You will also need to add `C:\gstreamer\1.0\x86_64\lib` to your `LIB` environment variable. +Note that you should ensure that _all_ components are installed from gstreamer, as we require many of the optional libraries that are not installed by default. + 4. Install Git for Windows (https://git-scm.com/download/win). DO allow it to add git.exe to the PATH (default settings for the installer are fine). |