diff options
| author | CHANG FU CHIAO <zector1030@gmail.com> | 2016-08-27 11:14:10 +0800 |
|---|---|---|
| committer | CHANG FU CHIAO <zector1030@gmail.com> | 2016-08-27 13:43:43 +0800 |
| commit | 1dcc8e69fec5bda0e48d213a8dd25ff24bfc955f (patch) | |
| tree | 4413e1bd61563a212e251b3100b43bf2f286099d | |
| parent | fe1225b4ba5b89bb7e22ea827edbc40d44a5d4d6 (diff) | |
| download | servo-1dcc8e69fec5bda0e48d213a8dd25ff24bfc955f.tar.gz servo-1dcc8e69fec5bda0e48d213a8dd25ff24bfc955f.zip | |
FIX TreeherderClient deprecated param
According to warning from TreeherderClient(),
the parameters `host` and `protocol` are deprecated.
Then use `server_url` instead.
| -rw-r--r-- | etc/ci/performance/README.md | 2 | ||||
| -rw-r--r-- | etc/ci/performance/submit_to_perfherder.py | 5 |
2 files changed, 3 insertions, 4 deletions
diff --git a/etc/ci/performance/README.md b/etc/ci/performance/README.md index 6aad4063768..fe7a7bec809 100644 --- a/etc/ci/performance/README.md +++ b/etc/ci/performance/README.md @@ -12,7 +12,7 @@ Servo Page Load Time Test * Clone this repo * Download [tp5n.zip](http://people.mozilla.org/~jmaher/taloszips/zips/tp5n.zip), extract it to `page_load_test/tp5n` * Run `prepare_manifest.sh` to transform the tp5n manifest to our format -* Install the Python3 `treeherder-client` package. For example, to install it in a virtualenv: `python3 -m virtualenv venv; source venv/bin/activate; pip install treeherder-client` +* Install the Python3 `treeherder-client` package. For example, to install it in a virtualenv: `python3 -m virtualenv venv; source venv/bin/activate; pip install "treeherder-client>=3.0.0"` * Setup your Treeherder client ID and secret as environment variables `TREEHERDER_CLIENT_ID` and `TREEHERDER_CLIENT_SECRET` ## Build Servo diff --git a/etc/ci/performance/submit_to_perfherder.py b/etc/ci/performance/submit_to_perfherder.py index e8f0f267c15..be2709ceea7 100644 --- a/etc/ci/performance/submit_to_perfherder.py +++ b/etc/ci/performance/submit_to_perfherder.py @@ -317,8 +317,7 @@ def submit(perf_data, failures, revision, summary, engine): 'secret': os.environ['TREEHERDER_CLIENT_SECRET'] } - client = TreeherderClient(protocol='https', - host='treeherder.allizom.org', + client = TreeherderClient(server_url='https://treeherder.mozilla.org', client_id=cred['client_id'], secret=cred['secret']) @@ -331,7 +330,7 @@ def submit(perf_data, failures, revision, summary, engine): def main(): parser = argparse.ArgumentParser( description=("Submit Servo performance data to Perfherder. " - "Remember to set your Treeherder credentail as environment" + "Remember to set your Treeherder credential as environment" " variable \'TREEHERDER_CLIENT_ID\' and " "\'TREEHERDER_CLIENT_SECRET\'")) parser.add_argument("perf_json", |