diff options
author | Martin Robinson <mrobinson@igalia.com> | 2024-09-05 11:50:09 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-09-05 18:50:09 +0000 |
commit | 312cf0df08e8a5044d286734bfdf3d6f0caff8dd (patch) | |
tree | b84b61412d85cc3b36640ab0d96510ceda0c189f /.gitignore | |
parent | 35baf056f6feb9eccfe36854da88d4fc454b654d (diff) | |
download | servo-312cf0df08e8a5044d286734bfdf3d6f0caff8dd.tar.gz servo-312cf0df08e8a5044d286734bfdf3d6f0caff8dd.zip |
script: Create a `CrossProcessInstant` to enable serializable monotonic time (#33282)
Up until now, Servo was using a very old version of time to get a
cross-process monotonic timestamp (using `time::precise_time_ns()`).
This change replaces the usage of old time with a new serializable
monotonic time called `CrossProcessInstant` and uses it where `u64`
timestamps were stored before. The standard library doesn't provide this
functionality because it isn't something you can do reliably on all
platforms. The idea is that we do our best and then fall back
gracefully.
This is a big change, because Servo was using `u64` timestamps all over
the place some as raw values taken from `time::precise_time_ns()` and
some as relative offsets from the "navigation start," which is a concept
similar to DOM's `timeOrigin` (but not exactly the same). It's very
difficult to fix this situation without fixing it everywhere as the
`Instant` concept is supposed to be opaque. The good thing is that this
change clears up all ambiguity when passing times as a `time::Duration`
is unit agnostic and a `CrossProcessInstant` represents an absolute
moment in time.
The `time` version of `Duration` is used because it can both be negative
and is also serializable.
Good things:
- No need too pass around `time` and `time_precise` any longer.
`CrossProcessInstant` is also precise and monotonic.
- The distinction between a time that is unset or at `0` (at some kind
of timer epoch) is now gone.
There still a lot of work to do to clean up timing, but this is the
first step. In general, I've tried to preserve existing behavior, even
when not spec compliant, as much as possible. I plan to submit followup
PRs fixing some of the issues I've noticed.
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions