1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
|
<?php
use MediaWiki\MainConfigNames;
use MediaWiki\Request\FauxRequest;
use MediaWiki\Tests\Unit\Permissions\MockAuthorityTrait;
use MediaWiki\Title\Title;
use Wikimedia\TestingAccessWrapper;
/**
* Test class for SpecialRecentchanges class
*
* @group Database
*
* @covers SpecialRecentChanges
* @covers ChangesListSpecialPage
*/
class SpecialRecentchangesTest extends AbstractChangesListSpecialPageTestCase {
use MockAuthorityTrait;
protected function getPage(): SpecialRecentChanges {
return new SpecialRecentChanges(
$this->getServiceContainer()->getWatchedItemStore(),
$this->getServiceContainer()->getMessageCache(),
$this->getServiceContainer()->getUserOptionsLookup()
);
}
/**
* @return TestingAccessWrapper
*/
protected function getPageAccessWrapper() {
return TestingAccessWrapper::newFromObject( $this->getPage() );
}
// Below providers should only be for features specific to
// RecentChanges. Otherwise, it should go in ChangesListSpecialPageTest
public function provideParseParameters() {
return [
[ 'limit=123', [ 'limit' => '123' ] ],
[ '234', [ 'limit' => '234' ] ],
[ 'days=3', [ 'days' => '3' ] ],
[ 'days=0.25', [ 'days' => '0.25' ] ],
[ 'namespace=5', [ 'namespace' => '5' ] ],
[ 'namespace=5|3', [ 'namespace' => '5|3' ] ],
[ 'tagfilter=foo', [ 'tagfilter' => 'foo' ] ],
[ 'tagfilter=foo;bar', [ 'tagfilter' => 'foo;bar' ] ],
];
}
public function validateOptionsProvider() {
return [
[
// hidebots=1 is default for Special:RecentChanges
[ 'hideanons' => 1, 'hideliu' => 1 ],
true,
[ 'hideliu' => 1 ],
false,
],
];
}
public function testAddWatchlistJoins() {
// Edit a test page so that it shows up in RC.
$testPage = $this->getExistingTestPage( 'Test page' );
$this->editPage( $testPage, 'Test content', '' );
// Set up RC.
$context = new RequestContext;
$context->setTitle( Title::newFromText( __METHOD__ ) );
$context->setUser( $this->getTestUser()->getUser() );
$context->setRequest( new FauxRequest );
// Confirm that the test page is in RC.
$rc1 = $this->getPage();
$rc1->setContext( $context );
$rc1->execute( null );
$this->assertStringContainsString( 'Test page', $rc1->getOutput()->getHTML() );
$this->assertStringContainsString( 'mw-changeslist-line-not-watched', $rc1->getOutput()->getHTML() );
// Watch the page, and check that it's now watched in RC.
$watchedItemStore = $this->getServiceContainer()->getWatchedItemStore();
$watchedItemStore->addWatch( $context->getUser(), $testPage );
$rc2 = $this->getPage();
$rc2->setContext( $context );
$rc2->execute( null );
$this->assertStringContainsString( 'Test page', $rc2->getOutput()->getHTML() );
$this->assertStringContainsString( 'mw-changeslist-line-watched', $rc2->getOutput()->getHTML() );
// Force a past expiry date on the watchlist item.
$db = wfGetDB( DB_PRIMARY );
$queryConds = [ 'wl_namespace' => $testPage->getNamespace(), 'wl_title' => $testPage->getDBkey() ];
$watchedItemId = $db->selectField( 'watchlist', 'wl_id', $queryConds, __METHOD__ );
$db->newUpdateQueryBuilder()
->update( 'watchlist_expiry' )
->set( [ 'we_expiry' => $db->timestamp( '20200101000000' ) ] )
->where( [ 'we_item' => $watchedItemId ] )
->caller( __METHOD__ )->execute();
// Check that the page is still in RC, but that it's no longer watched.
$rc3 = $this->getPage();
$rc3->setContext( $context );
$rc3->execute( null );
$this->assertStringContainsString( 'Test page', $rc3->getOutput()->getHTML() );
$this->assertStringContainsString( 'mw-changeslist-line-not-watched', $rc3->getOutput()->getHTML() );
}
public function testExperienceLevelFilter() {
// Edit a test page so that it shows up in RC.
$testPage = $this->getExistingTestPage( 'Experience page' );
$this->editPage( $testPage, 'Registered content',
'registered summary', NS_MAIN, $this->getTestUser()->getUser() );
$this->editPage( $testPage, 'Anon content',
'anon summary', NS_MAIN, $this->mockAnonUltimateAuthority() );
// Set up RC.
$context = new RequestContext;
$context->setTitle( Title::newFromText( __METHOD__ ) );
$context->setUser( $this->getTestUser()->getUser() );
$context->setRequest( new FauxRequest );
// Confirm that the test page is in RC.
[ $html ] = ( new SpecialPageExecutor() )->executeSpecialPage(
$this->getPage(),
'',
new FauxRequest()
);
$this->assertStringContainsString( 'Experience page', $html );
// newcomer
$req = new FauxRequest();
$req->setVal( 'userExpLevel', 'newcomer' );
[ $html ] = ( new SpecialPageExecutor() )->executeSpecialPage(
$this->getPage(),
'',
$req
);
$this->assertStringContainsString( 'registered summary', $html );
// anon
$req = new FauxRequest();
$req->setVal( 'userExpLevel', 'unregistered' );
[ $html ] = ( new SpecialPageExecutor() )->executeSpecialPage(
$this->getPage(),
'',
$req
);
$this->assertStringContainsString( 'anon summary', $html );
$this->assertStringNotContainsString( 'registered summary', $html );
// registered
$req = new FauxRequest();
$req->setVal( 'userExpLevel', 'registered' );
[ $html ] = ( new SpecialPageExecutor() )->executeSpecialPage(
$this->getPage(),
'',
$req
);
$this->assertStringContainsString( 'registered summary', $html );
$this->assertStringNotContainsString( 'anon summary', $html );
}
/**
* This integration test just tries to run the isDenseFilter() queries, to
* check for syntax errors etc. It doesn't verify the logic.
*/
public function testIsDenseTagFilter() {
$this->tablesUsed[] = 'change_tag_def';
$this->tablesUsed[] = 'change_tag';
ChangeTags::defineTag( 'rc-test-tag' );
$req = new FauxRequest();
$req->setVal( 'tagfilter', 'rc-test-tag' );
$page = $this->getPage();
// Make sure thresholds are passed
$page->denseRcSizeThreshold = 0;
$this->overrideConfigValue( MainConfigNames::MiserMode, true );
( new SpecialPageExecutor() )->executeSpecialPage( $page, '', $req );
$this->assertTrue( true );
}
public static function provideDenseTagFilter() {
return [
[ false ],
[ true ]
];
}
/**
* This integration test injects the return value of isDenseFilter(),
* verifying the correctness of the resulting STRAIGHT_JOIN.
*
* @dataProvider provideDenseTagFilter
*/
public function testDenseTagFilter( $dense ) {
$this->tablesUsed[] = 'change_tag_def';
$this->tablesUsed[] = 'change_tag';
ChangeTags::defineTag( 'rc-test-tag' );
$req = new FauxRequest();
$req->setVal( 'tagfilter', 'rc-test-tag' );
$page = new class (
$dense,
$this->getServiceContainer()->getWatchedItemStore(),
$this->getServiceContainer()->getMessageCache(),
$this->getServiceContainer()->getUserOptionsLookup()
) extends SpecialRecentChanges {
private $dense;
public function __construct(
$dense,
WatchedItemStoreInterface $watchedItemStore = null,
MessageCache $messageCache = null,
\MediaWiki\User\UserOptionsLookup $userOptionsLookup = null
) {
parent::__construct( $watchedItemStore, $messageCache, $userOptionsLookup );
$this->dense = $dense;
}
protected function isDenseTagFilter( $tagIds, $limit ) {
return $this->dense;
}
};
( new SpecialPageExecutor() )->executeSpecialPage( $page, '', $req );
$this->assertTrue( true );
}
}
|
