1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
|
<?php
use MediaWiki\Shell\Command;
use MediaWiki\Shell\Shell;
use Shellbox\Shellbox;
/**
* @covers \MediaWiki\Shell\Command
* @group Shell
*/
class CommandTest extends PHPUnit\Framework\TestCase {
use MediaWikiCoversValidator;
private function requirePosix() {
if ( wfIsWindows() ) {
$this->markTestSkipped( 'This test requires a POSIX environment.' );
}
}
private function createCommand() {
return new Command( Shellbox::createUnboxedExecutor() );
}
/**
* @dataProvider provideExecute
*/
public function testExecute( $command, $args, $expectedExitCode, $expectedOutput ) {
$command = $this->getPhpCommand( $command );
$result = $command
->params( $args )
->execute();
$this->assertSame( $expectedExitCode, $result->getExitCode() );
$this->assertSame( $expectedOutput, $result->getStdout() );
}
public function provideExecute() {
return [
'success status' => [ 'success_status.php', [], 0, '' ],
'failure status' => [ 'failure_status.php', [], 1, '' ],
'output' => [ 'echo_args.php', [ 'x', '>', 'y' ], 0, 'x > y' ],
];
}
public function testEnvironment() {
$command = $this->getPhpCommand( 'echo_env.php' );
$result = $command
->params( [ 'FOO' ] )
->environment( [ 'FOO' => 'bar' ] )
->execute();
$this->assertSame( "bar", $result->getStdout() );
}
public function testStdout() {
$command = $this->getPhpCommand( 'echo_args.php' );
$result = $command
->unsafeParams( 'ThisIsStderr', '1>&2' )
->execute();
$this->assertStringNotContainsString( 'ThisIsStderr', $result->getStdout() );
$this->assertEquals( "ThisIsStderr", $result->getStderr() );
}
public function testStdoutRedirection() {
// The double redirection doesn't work on Windows
$this->requirePosix();
$command = $this->createCommand();
$result = $command
->params( 'bash', '-c', 'echo ThisIsStderr 1>&2' )
->includeStderr( true )
->execute();
$this->assertEquals( "ThisIsStderr\n", $result->getStdout() );
$this->assertSame( '', $result->getStderr() );
}
public function testOutput() {
$command = $this->getPhpCommand(
'stdout_stderr.php',
[ 'correct stdout' ]
);
$result = $command->execute();
$this->assertSame( 'correct stdout', $result->getStdout() );
$this->assertSame( '', $result->getStderr() );
$command = $this->getPhpCommand(
'stdout_stderr.php',
[ 'correct stdout ', 'correct stderr ' ]
);
$result = $command
->includeStderr()
->execute();
$this->assertRegExp( '/correct stdout/m', $result->getStdout() );
$this->assertRegExp( '/correct stderr/m', $result->getStdout() );
$this->assertSame( '', $result->getStderr() );
$command = $this->getPhpCommand(
'stdout_stderr.php',
[ 'correct stdout', 'correct stderr' ]
);
$result = $command
->execute();
$this->assertSame( 'correct stdout', $result->getStdout() );
$this->assertSame( 'correct stderr', $result->getStderr() );
}
/**
* Test that null values are skipped by params() and unsafeParams()
*/
public function testNullsAreSkipped() {
$command = $this->createCommand();
$command->params( 'echo', 'a', null, 'b' );
$command->unsafeParams( 'c', null, 'd' );
if ( wfIsWindows() ) {
$this->assertEquals( '"echo" "a" "b" c d', $command->getCommandString() );
} else {
$this->assertEquals( "'echo' 'a' 'b' c d", $command->getCommandString() );
}
}
public function testT69870() {
// Testing for Bug T69870
// wfShellExec() cuts off stdout at multiples of 8192 bytes.
// hangs on Windows, see Bug T199989, non-blocking pipes
$this->requirePosix();
// Test several times because it involves a race condition that may randomly succeed or fail
for ( $i = 0; $i < 10; $i++ ) {
$command = $this->getPhpCommand( 'echo_333333_stars.php' );
$output = $command
->execute()
->getStdout();
$this->assertEquals( 333333, strlen( $output ) );
}
}
public function testLogStderr() {
$logger = new TestLogger( true, static function ( $message, $level, $context ) {
return $level === Psr\Log\LogLevel::ERROR ? '1' : null;
}, true );
$command = $this->getPhpCommand( 'echo_args.php' );
$command->setLogger( $logger );
$command->unsafeParams( 'ThisIsStderr', '1>&2' );
$command->execute();
$this->assertSame( [], $logger->getBuffer() );
$command = $this->getPhpCommand( 'echo_args.php' );
$command->setLogger( $logger );
$command->logStderr();
$command->unsafeParams( 'ThisIsStderr', '1>&2' );
$command->execute();
$this->assertCount( 1, $logger->getBuffer() );
$this->assertSame( trim( $logger->getBuffer()[0][2]['error'] ), 'ThisIsStderr' );
}
public function testInput() {
// hangs on Windows, see Bug T199989, non-blocking pipes
$this->requirePosix();
$command = $this->getPhpCommand( 'echo_stdin.php' );
$command->input( 'abc' );
$result = $command->execute();
$this->assertSame( 'abc', $result->getStdout() );
// now try it with something that does not fit into a single block
$command = $this->getPhpCommand( 'echo_stdin.php' );
$command->input( str_repeat( '!', 1000000 ) );
$result = $command->execute();
$this->assertSame( 1000000, strlen( $result->getStdout() ) );
// And try it with empty input
$command = $this->getPhpCommand( 'echo_stdin.php' );
$command->input( '' );
$result = $command->execute();
$this->assertSame( '', $result->getStdout() );
}
/**
* Ensure that it's possible to disable the default shell restrictions
* @see T257278
*/
public function testDisablingRestrictions() {
$command = $this->createCommand();
// As CommandFactory does for the firejail case:
$command->restrict( Shell::RESTRICT_DEFAULT );
// Disable restrictions
$command->restrict( Shell::RESTRICT_NONE );
$this->assertFalse( $command->getPrivateUserNamespace() );
$this->assertFalse( $command->getFirejailDefaultSeccomp() );
$this->assertFalse( $command->getNoNewPrivs() );
$this->assertFalse( $command->getPrivateDev() );
$this->assertFalse( $command->getDisableNetwork() );
$this->assertSame( [], $command->getDisabledSyscalls() );
$this->assertTrue( $command->getDisableSandbox() );
}
/**
* Creates a command that will execute one of the PHP test scripts by its
* file name, using the current PHP_BIN binary.
*
* NOTE: the PHP test scripts are located in the sub directory
* "bin".
*
* @param string $fileName a file name in the "bin" sub-directory
* @param array $args an array of arguments to pass to the PHP script
*
* @return Command a command instance pointing to the right script
*/
private function getPhpCommand( $fileName, array $args = [] ) {
$command = new Command( Shellbox::createUnboxedExecutor() );
$params = [
PHP_BINARY,
__DIR__
. DIRECTORY_SEPARATOR
. 'bin'
. DIRECTORY_SEPARATOR
. $fileName
];
$params = array_merge( $params, $args );
$command->params( $params );
$command->limits( [ 'memory' => 0 ] );
return $command;
}
}
|
