1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
|
<?php
use MediaWiki\MainConfigNames;
use MediaWiki\Preferences\SignatureValidator;
use MediaWiki\Registration\ExtensionRegistry;
use Wikimedia\TestingAccessWrapper;
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
*/
/**
* @group Preferences
* @group Database
*/
class SignatureValidatorTest extends MediaWikiIntegrationTestCase {
private $validator;
protected function setUp(): void {
parent::setUp();
$this->overrideConfigValue( MainConfigNames::ParsoidSettings, [
'linting' => true
] );
// For testing SignatureAllowedLintErrors in ::testValidateSignature
$this->overrideConfigValue( MainConfigNames::SignatureAllowedLintErrors, [
// No allowed lint errors in default set up
] );
// For testing hidden category support in ::testValidateSignature
$this->overrideConfigValue( 'LinterCategories', [
// No hidden categories in default set up
] );
$extReg = $this->createMock( ExtensionRegistry::class );
$extReg->method( 'isLoaded' )->willReturnCallback( static function ( string $which ) {
return $which == 'Linter';
} );
$this->setService( 'ExtensionRegistry', $extReg );
$this->validator = $this->getSignatureValidator();
}
/**
* Get a basic SignatureValidator for testing with.
* @return SignatureValidator
*/
protected function getSignatureValidator() {
$services = $this->getServiceContainer();
$lang = $services->getLanguageFactory()->getLanguage( 'en' );
$user = $services->getUserFactory()->newFromName( 'SignatureValidatorTest' );
$validator = $services->getSignatureValidatorFactory()->newSignatureValidator(
$user,
null,
ParserOptions::newFromUserAndLang( $user, $lang )
);
return TestingAccessWrapper::newFromObject( $validator );
}
/**
* @covers \MediaWiki\Preferences\SignatureValidator::applyPreSaveTransform()
* @dataProvider provideApplyPreSaveTransform
*/
public function testApplyPreSaveTransform( $signature, $expected ) {
$pstSig = $this->validator->applyPreSaveTransform( $signature );
$this->assertSame( $expected, $pstSig );
}
public static function provideApplyPreSaveTransform() {
return [
'Pipe trick' =>
[ '[[test|]]', '[[test|test]]' ],
'One level substitution' =>
[ '{{subst:uc:whatever}}', 'WHATEVER' ],
'Hidden nested substitution' =>
[ '{{subst:uc:{}}{{subst:uc:{subst:uc:}}}{{subst:uc:}}}', false ],
'Hidden nested signature' =>
[ '{{subst:uc:~~}}{{subst:uc:~~}}', false ],
];
}
/**
* @covers \MediaWiki\Preferences\SignatureValidator::checkUserLinks()
* @dataProvider provideCheckUserLinks
*/
public function testCheckUserLinks( $signature, $expected ) {
$isValid = $this->validator->checkUserLinks( $signature );
$this->assertSame( $expected, $isValid );
}
public static function provideCheckUserLinks() {
return [
'Perfect' =>
[ '[[User:SignatureValidatorTest|Signature]] ([[User talk:SignatureValidatorTest|talk]])', true ],
'User link' =>
[ '[[User:SignatureValidatorTest|Signature]]', true ],
'User talk link' =>
[ '[[User talk:SignatureValidatorTest]]', true ],
'Contributions link' =>
[ '[[Special:Contributions/SignatureValidatorTest]]', true ],
'Silly formatting permitted' =>
[ '[[_uSeR :_signatureValidatorTest_]]', true ],
'Contributions of wrong user' =>
[ '[[Special:Contributions/SignatureValidatorTestNot]]', false ],
'Link to subpage only' =>
[ '[[User:SignatureValidatorTest/blah|Signature]]', false ],
];
}
/**
* @covers \MediaWiki\Preferences\SignatureValidator::checkLintErrors()
* @dataProvider provideCheckLintErrors
*/
public function testCheckLintErrors( $signature, $expected ) {
$errors = $this->validator->checkLintErrors( $signature );
$this->assertSame( $expected, $errors );
}
public static function provideCheckLintErrors() {
yield 'Perfect' => [ '<strong>Foo</strong>', [] ];
yield 'Unclosed tag' => [
'<strong>Foo',
[
[
'type' => 'missing-end-tag',
'dsr' => [ 0, 11, 8, 0 ],
'templateInfo' => null,
'params' => [
'name' => 'strong',
'inTable' => false,
]
]
]
];
}
/**
* @covers \MediaWiki\Preferences\SignatureValidator::validateSignature()
* @dataProvider provideValidateSignature
*/
public function testValidateSignature( string $signature, $expected ) {
$result = $this->validator->validateSignature( $signature );
if ( is_string( $expected ) ) {
// All special cases should report errors here.
$expected = true;
}
$this->assertSame( $expected, $result );
}
/**
* @covers \MediaWiki\Preferences\SignatureValidator::validateSignature()
* @dataProvider provideValidateSignature
*/
public function testValidateSignatureAllowed( string $signature, $expected ) {
$this->overrideConfigValue( MainConfigNames::SignatureAllowedLintErrors, [
'obsolete-tag'
] );
$this->validator = $this->getSignatureValidator();
$result = $this->validator->validateSignature( $signature );
if ( $expected === 'allowed' ) {
$expected = false;
} elseif ( is_string( $expected ) ) {
$expected = true;
}
$this->assertSame( $expected, $result );
}
public function provideValidateSignature() {
yield 'Perfect' => [
'[[User:SignatureValidatorTest|Signature]] ([[User talk:SignatureValidatorTest|talk]])',
// no complaints from lint
false
];
yield 'Missing end tag' => [
'<span>[[User:SignatureValidatorTest|Signature]] ([[User talk:SignatureValidatorTest|talk]])',
// missing-end-tag is never allowed
true
];
yield 'Obsolete tag' => [
'<font color="red">RED</font> [[User:SignatureValidatorTest|Signature]] ([[User talk:SignatureValidatorTest|talk]])',
// This is allowed by SignatureAllowedLintErrors
'allowed'
];
}
/**
* @covers \MediaWiki\Preferences\SignatureValidator::checkLineBreaks()
* @dataProvider provideCheckLineBreaks
*/
public function testCheckLineBreaks( $signature, $expected ) {
$isValid = $this->validator->checkLineBreaks( $signature );
$this->assertSame( $expected, $isValid );
}
public static function provideCheckLineBreaks() {
return [
'Perfect' =>
[ '[[User:SignatureValidatorTest|Signature]] ([[User talk:SignatureValidatorTest|talk]])', true ],
'Line break' =>
[ "[[User:SignatureValidatorTest|Signature]] ([[User talk:SignatureValidatorTest|talk\n]])", false ],
];
}
}
|
