1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
|
<?php
use Wikimedia\Rdbms\IDatabase;
use Wikimedia\Rdbms\LBFactory;
/**
* @covers \MediaWiki\Logging\RightsLogFormatter
*/
class RightsLogFormatterTest extends LogFormatterTestCase {
protected function setUp(): void {
parent::setUp();
$db = $this->createNoOpMock( IDatabase::class, [ 'getInfinity' ] );
$db->method( 'getInfinity' )->willReturn( 'infinity' );
$lbFactory = $this->createMock( LBFactory::class );
$lbFactory->method( 'getReplicaDatabase' )->willReturn( $db );
$this->setService( 'DBLoadBalancerFactory', $lbFactory );
}
/**
* Provide different rows from the logging table to test
* for backward compatibility.
* Do not change the existing data, just add a new database row
*/
public static function provideRightsLogDatabaseRows() {
return [
// Current format
[
[
'type' => 'rights',
'action' => 'rights',
'comment' => 'rights comment',
'user' => 0,
'user_text' => 'Sysop',
'namespace' => NS_USER,
'title' => 'User',
'params' => [
'4::oldgroups' => [],
'5::newgroups' => [ 'sysop', 'bureaucrat' ],
'oldmetadata' => [],
'newmetadata' => [
[ 'expiry' => null ],
[ 'expiry' => '20160101123456' ]
],
],
],
[
'text' => 'Sysop changed group membership for User: granted bureaucrat '
. '(temporary, until 12:34, 1 January 2016) and administrator',
'api' => [
'oldgroups' => [],
'newgroups' => [ 'sysop', 'bureaucrat' ],
'oldmetadata' => [],
'newmetadata' => [
[ 'group' => 'sysop', 'expiry' => 'infinity' ],
[ 'group' => 'bureaucrat', 'expiry' => '2016-01-01T12:34:56Z' ],
],
],
],
],
[
[
'type' => 'rights',
'action' => 'rights',
'comment' => 'rights comment',
'user' => 0,
'user_text' => 'Sysop',
'namespace' => NS_USER,
'title' => 'User',
'params' => [
'4::oldgroups' => [ 'bot', 'sysop', 'interface-admin' ],
'5::newgroups' => [ 'sysop', 'bureaucrat', 'interface-admin' ],
'oldmetadata' => [
[ 'expiry' => null ],
[ 'expiry' => '20160203123456' ],
[ 'expiry' => null ],
],
'newmetadata' => [
[ 'expiry' => null ],
[ 'expiry' => '20160101123456' ],
[ 'expiry' => null ],
],
],
],
[
'text' => 'Sysop changed group membership for User: granted bureaucrat '
. '(temporary, until 12:34, 1 January 2016); revoked bot; changed '
. 'expiration of administrator (permanent, was: until 12:34, '
. '3 February 2016); kept interface administrator unchanged',
'api' => [
'oldgroups' => [ 'bot', 'sysop', 'interface-admin' ],
'newgroups' => [ 'sysop', 'bureaucrat', 'interface-admin' ],
'oldmetadata' => [
[ 'group' => 'bot', 'expiry' => 'infinity' ],
[ 'group' => 'sysop', 'expiry' => '2016-02-03T12:34:56Z' ],
[ 'group' => 'interface-admin', 'expiry' => 'infinity' ],
],
'newmetadata' => [
[ 'group' => 'sysop', 'expiry' => 'infinity' ],
[ 'group' => 'bureaucrat', 'expiry' => '2016-01-01T12:34:56Z' ],
[ 'group' => 'interface-admin', 'expiry' => 'infinity' ],
],
],
],
],
[
[
'type' => 'rights',
'action' => 'rights',
'comment' => 'rights comment',
'user' => 0,
'user_text' => 'Sysop',
'namespace' => NS_USER,
'title' => 'User',
'params' => [
'4::oldgroups' => [ 'bot', 'sysop', 'bureaucrat', 'interface-admin' ],
'5::newgroups' => [ 'bot', 'sysop', 'bureaucrat', 'interface-admin' ],
'oldmetadata' => [
[ 'expiry' => null ],
[ 'expiry' => '20160203123456' ],
[ 'expiry' => '20160304123456' ],
[ 'expiry' => '20160506123456' ],
],
'newmetadata' => [
[ 'expiry' => '20160102123456' ],
[ 'expiry' => null ],
[ 'expiry' => '20160405123456' ],
[ 'expiry' => '20160506123456' ],
],
],
],
[
'text' => 'Sysop changed group membership for User: changed expiration of '
. 'bot (until 12:34, 2 January 2016, was: permanent), administrator '
. '(permanent, was: until 12:34, 3 February 2016) and bureaucrat (until '
. '12:34, 5 April 2016, was: 12:34, 4 March 2016); kept interface '
. 'administrator (temporary, until 12:34, 6 May 2016) unchanged',
'api' => [
'oldgroups' => [ 'bot', 'sysop', 'bureaucrat', 'interface-admin' ],
'newgroups' => [ 'bot', 'sysop', 'bureaucrat', 'interface-admin' ],
'oldmetadata' => [
[ 'group' => 'bot', 'expiry' => 'infinity' ],
[ 'group' => 'sysop', 'expiry' => '2016-02-03T12:34:56Z' ],
[ 'group' => 'bureaucrat', 'expiry' => '2016-03-04T12:34:56Z' ],
[ 'group' => 'interface-admin', 'expiry' => '2016-05-06T12:34:56Z' ],
],
'newmetadata' => [
[ 'group' => 'bot', 'expiry' => '2016-01-02T12:34:56Z' ],
[ 'group' => 'sysop', 'expiry' => 'infinity' ],
[ 'group' => 'bureaucrat', 'expiry' => '2016-04-05T12:34:56Z' ],
[ 'group' => 'interface-admin', 'expiry' => '2016-05-06T12:34:56Z' ],
],
],
],
],
// Previous format (oldgroups and newgroups as arrays, no metadata)
[
[
'type' => 'rights',
'action' => 'rights',
'comment' => 'rights comment',
'user' => 0,
'user_text' => 'Sysop',
'namespace' => NS_USER,
'title' => 'User',
'params' => [
'4::oldgroups' => [],
'5::newgroups' => [ 'sysop', 'bureaucrat' ],
],
],
[
'text' => 'Sysop changed group membership for User: granted '
. 'administrator and bureaucrat',
'api' => [
'oldgroups' => [],
'newgroups' => [ 'sysop', 'bureaucrat' ],
'oldmetadata' => [],
'newmetadata' => [
[ 'group' => 'sysop', 'expiry' => 'infinity' ],
[ 'group' => 'bureaucrat', 'expiry' => 'infinity' ],
],
],
],
],
// Legacy format (oldgroups and newgroups as numeric-keyed strings)
[
[
'type' => 'rights',
'action' => 'rights',
'comment' => 'rights comment',
'user' => 0,
'user_text' => 'Sysop',
'namespace' => NS_USER,
'title' => 'User',
'params' => [
'',
'sysop, bureaucrat',
],
],
[
'legacy' => true,
'text' => 'Sysop changed group membership for User: granted '
. 'administrator and bureaucrat',
'api' => [
'oldgroups' => [],
'newgroups' => [ 'sysop', 'bureaucrat' ],
'oldmetadata' => [],
'newmetadata' => [
[ 'group' => 'sysop', 'expiry' => 'infinity' ],
[ 'group' => 'bureaucrat', 'expiry' => 'infinity' ],
],
],
],
],
// Really old entry
[
[
'type' => 'rights',
'action' => 'rights',
'comment' => 'rights comment',
'user' => 0,
'user_text' => 'Sysop',
'namespace' => NS_USER,
'title' => 'User',
'params' => [],
],
[
'legacy' => true,
'text' => 'Sysop changed group membership for User',
'api' => [],
],
],
];
}
/**
* @dataProvider provideRightsLogDatabaseRows
*/
public function testRightsLogDatabaseRows( $row, $extra ) {
$this->doTestLogFormatter( $row, $extra );
}
/**
* Provide different rows from the logging table to test
* for backward compatibility.
* Do not change the existing data, just add a new database row
*/
public static function provideAutopromoteLogDatabaseRows() {
return [
// Current format
[
[
'type' => 'rights',
'action' => 'autopromote',
'comment' => 'rights comment',
'user' => 0,
'user_text' => 'Sysop',
'namespace' => NS_USER,
'title' => 'Sysop',
'params' => [
'4::oldgroups' => [ 'sysop' ],
'5::newgroups' => [ 'sysop', 'bureaucrat' ],
],
],
[
'text' => 'Sysop automatically changed their group membership: '
. 'got bureaucrat; kept administrator unchanged',
'api' => [
'oldgroups' => [ 'sysop' ],
'newgroups' => [ 'sysop', 'bureaucrat' ],
'oldmetadata' => [
[ 'group' => 'sysop', 'expiry' => 'infinity' ],
],
'newmetadata' => [
[ 'group' => 'sysop', 'expiry' => 'infinity' ],
[ 'group' => 'bureaucrat', 'expiry' => 'infinity' ],
],
],
],
],
[
// At the moment it's impossible to lose a group through autopromotion,
// but it's checked for completeness
[
'type' => 'rights',
'action' => 'autopromote',
'comment' => 'rights comment',
'user' => 0,
'user_text' => 'Sysop',
'namespace' => NS_USER,
'title' => 'User',
'params' => [
'4::oldgroups' => [ 'bot', 'sysop', 'interface-admin' ],
'5::newgroups' => [ 'sysop', 'bureaucrat', 'interface-admin' ],
'oldmetadata' => [
[ 'expiry' => null ],
[ 'expiry' => '20160203123456' ],
[ 'expiry' => null ],
],
'newmetadata' => [
[ 'expiry' => null ],
[ 'expiry' => '20160101123456' ],
[ 'expiry' => null ],
],
],
],
[
'text' => 'Sysop automatically changed their group membership: got bureaucrat '
. '(temporary, until 12:34, 1 January 2016); lost bot; changed '
. 'expiration of administrator (permanent, was: until 12:34, '
. '3 February 2016); kept interface administrator unchanged',
'api' => [
'oldgroups' => [ 'bot', 'sysop', 'interface-admin' ],
'newgroups' => [ 'sysop', 'bureaucrat', 'interface-admin' ],
'oldmetadata' => [
[ 'group' => 'bot', 'expiry' => 'infinity' ],
[ 'group' => 'sysop', 'expiry' => '2016-02-03T12:34:56Z' ],
[ 'group' => 'interface-admin', 'expiry' => 'infinity' ],
],
'newmetadata' => [
[ 'group' => 'sysop', 'expiry' => 'infinity' ],
[ 'group' => 'bureaucrat', 'expiry' => '2016-01-01T12:34:56Z' ],
[ 'group' => 'interface-admin', 'expiry' => 'infinity' ],
],
],
],
],
// Legacy format
[
[
'type' => 'rights',
'action' => 'autopromote',
'comment' => 'rights comment',
'user' => 0,
'user_text' => 'Sysop',
'namespace' => NS_USER,
'title' => 'Sysop',
'params' => [
'sysop',
'sysop, bureaucrat',
],
],
[
'legacy' => true,
'text' => 'Sysop automatically changed their group membership: '
. 'got bureaucrat; kept administrator unchanged',
'api' => [
'oldgroups' => [ 'sysop' ],
'newgroups' => [ 'sysop', 'bureaucrat' ],
'oldmetadata' => [
[ 'group' => 'sysop', 'expiry' => 'infinity' ],
],
'newmetadata' => [
[ 'group' => 'sysop', 'expiry' => 'infinity' ],
[ 'group' => 'bureaucrat', 'expiry' => 'infinity' ],
],
],
],
],
];
}
/**
* @dataProvider provideAutopromoteLogDatabaseRows
*/
public function testAutopromoteLogDatabaseRows( $row, $extra ) {
$this->doTestLogFormatter( $row, $extra );
}
}
|
