1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
|
<?php
use MediaWiki\Context\DerivativeContext;
use MediaWiki\Context\RequestContext;
use MediaWiki\LinkedData\PageDataRequestHandler;
use MediaWiki\Output\OutputPage;
use MediaWiki\Request\FauxRequest;
use MediaWiki\Request\FauxResponse;
use MediaWiki\Title\Title;
use MediaWiki\Title\TitleFactory;
/**
* @covers \MediaWiki\LinkedData\PageDataRequestHandler
* @group PageData
*/
class PageDataRequestHandlerTest extends \MediaWikiLangTestCase {
/**
* @var Title
*/
private $interfaceTitle;
/**
* @var int
*/
private $obLevel;
protected function setUp(): void {
parent::setUp();
$this->interfaceTitle = Title::newFromText( __CLASS__ );
// Force the content model to avoid DB queries.
$this->interfaceTitle->setContentModel( CONTENT_MODEL_WIKITEXT );
$this->obLevel = ob_get_level();
}
protected function assertPostConditions(): void {
$obLevel = ob_get_level();
if ( $obLevel !== $this->obLevel ) {
$this->fail( "Test changed output buffer level: was {$this->obLevel}" .
"before test, but $obLevel after test."
);
}
parent::assertPostConditions();
}
protected function tearDown(): void {
while ( ob_get_level() > $this->obLevel ) {
ob_end_clean();
}
parent::tearDown();
}
/**
* @return PageDataRequestHandler
*/
protected function newHandler() {
return new PageDataRequestHandler();
}
/**
* @param array $params
* @param string[] $headers
*
* @return OutputPage
*/
protected function makeOutputPage( array $params, array $headers ) {
// construct request
$request = new FauxRequest( $params );
$request->response()->header( 'Status: 200 OK', true, 200 ); // init/reset
foreach ( $headers as $name => $value ) {
$request->setHeader( strtoupper( $name ), $value );
}
// construct Context and OutputPage
$context = new DerivativeContext( RequestContext::getMain() );
$context->setRequest( $request );
$output = new OutputPage( $context );
$output->setTitle( $this->interfaceTitle );
$context->setOutput( $output );
return $output;
}
public static function handleRequestProvider() {
$cases = [];
$cases[] = [ '', [], [], 'Invalid title', 400 ];
$cases[] = [
'',
[ 'target' => 'Helsinki' ],
[],
'',
303,
[ 'Location' => '?title=Helsinki&action=raw' ]
];
$subpageCases = [];
foreach ( $cases as $c ) {
$case = $c;
$case[0] = 'main/';
if ( isset( $case[1]['target'] ) ) {
$case[0] .= $case[1]['target'];
unset( $case[1]['target'] );
}
$subpageCases[] = $case;
}
$cases = array_merge( $cases, $subpageCases );
$cases[] = [
'',
[ 'target' => 'Helsinki' ],
[ 'Accept' => 'text/HTML' ],
'',
303,
[ 'Location' => '/wiki/Helsinki' ]
];
$cases[] = [
'',
[
'target' => 'Helsinki',
'revision' => '4242',
],
[ 'Accept' => 'text/HTML' ],
'',
303,
[ 'Location' => '?title=Helsinki&oldid=4242' ]
];
$cases[] = [
'/Helsinki',
[],
[],
'',
303,
[ 'Location' => '?title=Helsinki&action=raw' ]
];
// #31: /Q5 with "Accept: text/foobar" triggers a 406
$cases[] = [
'main/Helsinki',
[],
[ 'Accept' => 'text/foobar' ],
'No matching format found',
406,
];
$cases[] = [
'no slash',
[],
[ 'Accept' => 'text/HTML' ],
'Invalid title',
400,
];
$cases[] = [
'main',
[],
[ 'Accept' => 'text/HTML' ],
'Invalid title',
400,
];
$cases[] = [
'xyz/Helsinki',
[],
[ 'Accept' => 'text/HTML' ],
'Invalid title',
400,
];
$cases[] = [
'main/Helsinki',
[],
[ 'Accept' => 'text/HTML' ],
'',
303,
[ 'Location' => '/wiki/Helsinki' ]
];
$cases[] = [
'/Helsinki',
[],
[ 'Accept' => 'text/HTML' ],
'',
303,
[ 'Location' => '/wiki/Helsinki' ]
];
$cases[] = [
'main/AC/DC',
[],
[ 'Accept' => 'text/HTML' ],
'',
303,
[ 'Location' => '/wiki/AC/DC' ]
];
return $cases;
}
/**
* @dataProvider handleRequestProvider
*
* @param string $subpage The subpage to request (or '')
* @param array $params Request parameters
* @param array $headers Request headers
* @param string $expectedOutput
* @param int $expectedStatusCode Expected HTTP status code.
* @param string[] $expectedHeaders Expected HTTP response headers.
*/
public function testHandleRequest(
$subpage,
array $params,
array $headers,
$expectedOutput = '',
$expectedStatusCode = 200,
array $expectedHeaders = []
) {
$titleFactory = $this->createMock( TitleFactory::class );
$titleFactory->method( 'newFromTextThrow' )->willReturnCallback( static function ( $text, $ns ) {
// Force the content model to avoid DB queries.
$ret = Title::newFromTextThrow( $text, $ns );
$ret->setContentModel( CONTENT_MODEL_WIKITEXT );
return $ret;
} );
$this->setService( 'TitleFactory', $titleFactory );
$output = $this->makeOutputPage( $params, $headers );
$request = $output->getRequest();
/** @var FauxResponse $response */
$response = $request->response();
// construct handler
$handler = $this->newHandler();
try {
ob_start();
$handler->handleRequest( $subpage, $request, $output );
if ( $output->getRedirect() !== '' ) {
// hack to apply redirect to web response
$output->output();
}
$text = ob_get_clean();
$this->assertEquals( $expectedStatusCode, $response->getStatusCode(), 'status code' );
$this->assertSame( $expectedOutput, $text, 'output' );
foreach ( $expectedHeaders as $name => $exp ) {
$value = $response->getHeader( $name );
$this->assertNotNull( $value, "header: $name" );
$this->assertIsString( $value, "header: $name" );
$this->assertStringEndsWith( $exp, $value, "header: $name" );
}
} catch ( HttpError $e ) {
ob_end_clean();
$this->assertEquals( $expectedStatusCode, $e->getStatusCode(), 'status code' );
$this->assertStringContainsString( $expectedOutput, $e->getHTML(), 'error output' );
}
// We always set "Access-Control-Allow-Origin: *"
$this->assertSame( '*', $response->getHeader( 'Access-Control-Allow-Origin' ) );
}
public static function provideHttpContentNegotiation() {
$helsinki = Title::makeTitle( NS_MAIN, 'Helsinki' );
// Force the content model to avoid DB queries.
$helsinki->setContentModel( CONTENT_MODEL_WIKITEXT );
return [
'Accept Header of HTML' => [
$helsinki,
[ 'ACCEPT' => 'text/html' ], // headers
'Helsinki'
],
'Accept Header without weights' => [
$helsinki,
[ 'ACCEPT' => '*/*, text/html, text/x-wiki' ],
'Helsinki&action=raw'
],
'Accept Header with weights' => [
$helsinki,
[ 'ACCEPT' => 'text/*; q=0.5, text/json; q=0.7, application/rdf+xml; q=0.8' ],
'Helsinki&action=raw'
],
'Accept Header accepting evertyhing and HTML' => [
$helsinki,
[ 'ACCEPT' => 'text/html, */*' ],
'Helsinki&action=raw'
],
'No Accept Header' => [
$helsinki,
[],
'Helsinki&action=raw'
],
];
}
/**
* @dataProvider provideHttpContentNegotiation
*
* @param Title $title
* @param array $headers Request headers
* @param string $expectedRedirectSuffix Expected suffix of the HTTP Location header.
*/
public function testHttpContentNegotiation(
Title $title,
array $headers,
$expectedRedirectSuffix
) {
$output = $this->makeOutputPage( [], $headers );
$request = $output->getRequest();
$handler = $this->newHandler();
$handler->httpContentNegotiation( $request, $output, $title );
$this->assertStringEndsWith(
$expectedRedirectSuffix,
$output->getRedirect(),
'redirect target'
);
}
}
|