1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
|
<?php
use MediaWiki\MediaWikiServices;
use MediaWiki\Revision\SlotRecord;
use Wikimedia\TestingAccessWrapper;
/**
* @group Database
* @group Cache
* @covers MessageCache
*/
class MessageCacheTest extends MediaWikiLangTestCase {
protected function setUp(): void {
parent::setUp();
$this->configureLanguages();
MediaWikiServices::getInstance()->getMessageCache()->enable();
}
/**
* Helper function -- setup site language for testing
*/
protected function configureLanguages() {
// for the test, we need the content language to be anything but English,
// let's choose e.g. German (de)
$this->setUserLang( 'de' );
$this->setContentLang( 'de' );
}
public function addDBDataOnce() {
$this->configureLanguages();
// Set up messages and fallbacks ab -> ru -> de
$this->makePage( 'FallbackLanguageTest-Full', 'ab' );
$this->makePage( 'FallbackLanguageTest-Full', 'ru' );
$this->makePage( 'FallbackLanguageTest-Full', 'de' );
// Fallbacks where ab does not exist
$this->makePage( 'FallbackLanguageTest-Partial', 'ru' );
$this->makePage( 'FallbackLanguageTest-Partial', 'de' );
// Fallback to the content language
$this->makePage( 'FallbackLanguageTest-ContLang', 'de' );
// Add customizations for an existing message.
$this->makePage( 'sunday', 'ru' );
// Full key tests -- always want russian
$this->makePage( 'MessageCacheTest-FullKeyTest', 'ab' );
$this->makePage( 'MessageCacheTest-FullKeyTest', 'ru' );
// In content language -- get base if no derivative
$this->makePage( 'FallbackLanguageTest-NoDervContLang', 'de', 'de/none' );
}
/**
* Helper function for addDBData -- adds a simple page to the database
*
* @param string $title Title of page to be created
* @param string $lang Language and content of the created page
* @param string|null $content Content of the created page, or null for a generic string
*
* @return RevisionRecord
*/
private function makePage( $title, $lang, $content = null ) {
if ( $content === null ) {
$content = $lang;
}
if ( $lang !== MediaWikiServices::getInstance()->getContentLanguage()->getCode() ) {
$title = "$title/$lang";
}
$title = Title::newFromText( $title, NS_MEDIAWIKI );
$wikiPage = new WikiPage( $title );
$content = ContentHandler::makeContent( $content, $title );
$updater = $wikiPage->newPageUpdater( $this->getTestSysop()->getUser() );
$updater->setContent(
SlotRecord::MAIN,
$content
);
$summary = CommentStoreComment::newUnsavedComment( "$lang translation test case" );
$inserted = $updater->saveRevision( $summary );
// sanity
$this->assertTrue( $updater->wasSuccessful(), 'Create page ' . $title->getPrefixedDBkey() );
return $inserted;
}
/**
* Test message fallbacks, T3495
*
* @dataProvider provideMessagesForFallback
*/
public function testMessageFallbacks( $message, $lang, $expectedContent ) {
$result = MediaWikiServices::getInstance()->getMessageCache()->get( $message, true, $lang );
$this->assertEquals( $expectedContent, $result, "Message fallback failed." );
}
public function provideMessagesForFallback() {
return [
[ 'FallbackLanguageTest-Full', 'ab', 'ab' ],
[ 'FallbackLanguageTest-Partial', 'ab', 'ru' ],
[ 'FallbackLanguageTest-ContLang', 'ab', 'de' ],
[ 'FallbackLanguageTest-None', 'ab', false ],
// Existing message with customizations on the fallbacks
[ 'sunday', 'ab', 'амҽыш' ],
// T48579
[ 'FallbackLanguageTest-NoDervContLang', 'de', 'de/none' ],
// UI language different from content language should only use de/none as last option
[ 'FallbackLanguageTest-NoDervContLang', 'fit', 'de/none' ],
];
}
public function testReplaceMsg() {
$messageCache = MediaWikiServices::getInstance()->getMessageCache();
$message = 'go';
$uckey = MediaWikiServices::getInstance()->getContentLanguage()->ucfirst( $message );
$oldText = $messageCache->get( $message ); // "Ausführen"
$dbw = wfGetDB( DB_PRIMARY );
$dbw->startAtomic( __METHOD__ ); // simulate request and block deferred updates
$messageCache->replace( $uckey, 'Allez!' );
$this->assertEquals( 'Allez!',
$messageCache->getMsgFromNamespace( $uckey, 'de' ),
'Updates are reflected in-process immediately' );
$this->assertEquals( 'Allez!',
$messageCache->get( $message ),
'Updates are reflected in-process immediately' );
$this->makePage( 'Go', 'de', 'Race!' );
$dbw->endAtomic( __METHOD__ );
$this->assertSame( 0,
DeferredUpdates::pendingUpdatesCount(),
'Post-commit deferred update triggers a run of all updates' );
$this->assertEquals( 'Race!', $messageCache->get( $message ), 'Correct final contents' );
$this->makePage( 'Go', 'de', $oldText );
$messageCache->replace( $uckey, $oldText ); // deferred update runs immediately
$this->assertEquals( $oldText, $messageCache->get( $message ), 'Content restored' );
}
public function testReplaceCache() {
global $wgWANObjectCaches;
// We need a WAN cache for this.
$this->setMwGlobals( [
'wgMainWANCache' => 'hash',
'wgWANObjectCaches' => $wgWANObjectCaches + [
'hash' => [
'class' => WANObjectCache::class,
'cacheId' => 'hash',
'channels' => []
]
]
] );
$messageCache = MediaWikiServices::getInstance()->getMessageCache();
$messageCache->enable();
// Populate one key
$this->makePage( 'Key1', 'de', 'Value1' );
$this->assertSame( 0,
DeferredUpdates::pendingUpdatesCount(),
'Post-commit deferred update triggers a run of all updates' );
$this->assertEquals( 'Value1', $messageCache->get( 'Key1' ), 'Key1 was successfully edited' );
// Screw up the database so MessageCache::loadFromDB() will
// produce the wrong result for reloading Key1
$this->db->delete(
'page', [ 'page_namespace' => NS_MEDIAWIKI, 'page_title' => 'Key1' ], __METHOD__
);
// Populate the second key
$this->makePage( 'Key2', 'de', 'Value2' );
$this->assertSame( 0,
DeferredUpdates::pendingUpdatesCount(),
'Post-commit deferred update triggers a run of all updates' );
$this->assertEquals( 'Value2', $messageCache->get( 'Key2' ), 'Key2 was successfully edited' );
// Now test that the second edit didn't reload Key1
$this->assertEquals( 'Value1', $messageCache->get( 'Key1' ),
'Key1 wasn\'t reloaded by edit of Key2' );
}
/**
* @dataProvider provideNormalizeKey
*/
public function testNormalizeKey( $key, $expected ) {
$actual = MessageCache::normalizeKey( $key );
$this->assertEquals( $expected, $actual );
}
public function provideNormalizeKey() {
return [
[ 'Foo', 'foo' ],
[ 'foo', 'foo' ],
[ 'fOo', 'fOo' ],
[ 'FOO', 'fOO' ],
[ 'Foo bar', 'foo_bar' ],
[ 'Ćab', 'ćab' ],
[ 'Ćab_e 3', 'ćab_e_3' ],
[ 'ĆAB', 'ćAB' ],
[ 'ćab', 'ćab' ],
[ 'ćaB', 'ćaB' ],
];
}
public function testNoDBAccessContentLanguage() {
global $wgLanguageCode;
$dbr = wfGetDB( DB_REPLICA );
$messageCache = MediaWikiServices::getInstance()->getMessageCache();
$messageCache->getMsgFromNamespace( 'allpages', $wgLanguageCode );
$this->assertSame( 0, $dbr->trxLevel() );
$dbr->setFlag( DBO_TRX, $dbr::REMEMBER_PRIOR ); // make queries trigger TRX
$messageCache->getMsgFromNamespace( 'go', $wgLanguageCode );
$dbr->restoreFlags();
$this->assertSame( 0, $dbr->trxLevel(), "No DB read queries (content language)" );
}
public function testNoDBAccessNonContentLanguage() {
$dbr = wfGetDB( DB_REPLICA );
$messageCache = MediaWikiServices::getInstance()->getMessageCache();
$messageCache->getMsgFromNamespace( 'allpages/nl', 'nl' );
$this->assertSame( 0, $dbr->trxLevel() );
$dbr->setFlag( DBO_TRX, $dbr::REMEMBER_PRIOR ); // make queries trigger TRX
$messageCache->getMsgFromNamespace( 'go/nl', 'nl' );
$dbr->restoreFlags();
$this->assertSame( 0, $dbr->trxLevel(), "No DB read queries (non-content language)" );
}
/**
* Regression test for T218918
*/
public function testLoadFromDB_fetchLatestRevision() {
// Create three revisions of the same message page.
// Must be an existing message key.
$key = 'Log';
$this->makePage( $key, 'de', 'Test eins' );
$this->makePage( $key, 'de', 'Test zwei' );
$r3 = $this->makePage( $key, 'de', 'Test drei' );
// Create an out-of-sequence revision by importing a
// revision with an old timestamp. Hacky.
$importRevision = new WikiRevision( new HashConfig() );
$title = Title::newFromLinkTarget( $r3->getPageAsLinkTarget() );
$importRevision->setTitle( $title );
$importRevision->setComment( 'Imported edit' );
$importRevision->setTimestamp( '19991122001122' );
$content = ContentHandler::makeContent( 'IMPORTED OLD TEST', $title );
$importRevision->setContent( SlotRecord::MAIN, $content );
$importRevision->setUsername( 'ext>Alan Smithee' );
$importer = MediaWikiServices::getInstance()->getWikiRevisionOldRevisionImporterNoUpdates();
$importer->import( $importRevision );
// Now, load the message from the wiki page
$messageCache = MediaWikiServices::getInstance()->getMessageCache();
$messageCache->enable();
$messageCache = TestingAccessWrapper::newFromObject( $messageCache );
$cache = $messageCache->loadFromDB( 'de' );
$this->assertArrayHasKey( $key, $cache );
// Text in the cache has an extra space in front!
$this->assertSame( ' ' . 'Test drei', $cache[$key] );
}
/**
* @dataProvider provideIsMainCacheable
* @param string|null $code The language code
* @param string $message The message key
* @param bool $expected
*/
public function testIsMainCacheable( $code, $message, $expected ) {
$messageCache = TestingAccessWrapper::newFromObject(
MediaWikiServices::getInstance()->getMessageCache() );
$this->assertSame( $expected, $messageCache->isMainCacheable( $message, $code ) );
}
public function provideIsMainCacheable() {
$cases = [
// $message $expected
[ 'allpages', true ],
[ 'Allpages', true ],
[ 'Allpages/bat', true ],
[ 'Conversiontable/zh-tw', true ],
[ 'My_special_message', false ],
];
foreach ( [ null, 'en', 'fr' ] as $code ) {
foreach ( $cases as $case ) {
yield array_merge( [ $code ], $case );
}
}
}
}
|