1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
|
<?php
use MediaWiki\Context\RequestContext;
use MediaWiki\Linker\LinkTarget;
use MediaWiki\MainConfigNames;
use MediaWiki\Page\PageIdentity;
use MediaWiki\Page\PageReference;
use MediaWiki\Request\FauxRequest;
use MediaWiki\Tests\Unit\DummyServicesTrait;
use MediaWiki\Title\Title;
use MediaWiki\Title\TitleValue;
use Wikimedia\TestingAccessWrapper;
/**
* @group API
* @group medium
* @group Database
* @covers \ApiPageSet
*/
class ApiPageSetTest extends ApiTestCase {
use DummyServicesTrait;
public static function provideRedirectMergePolicy() {
return [
'By default nothing is merged' => [
null,
[]
],
'A simple merge policy adds the redirect data in' => [
static function ( $current, $new ) {
if ( !isset( $current['index'] ) || $new['index'] < $current['index'] ) {
$current['index'] = $new['index'];
}
return $current;
},
[ 'index' => 1 ],
],
];
}
/**
* @dataProvider provideRedirectMergePolicy
*/
public function testRedirectMergePolicyWithArrayResult( $mergePolicy, $expect ) {
[ $target, $pageSet ] = $this->createPageSetWithRedirect();
$pageSet->setRedirectMergePolicy( $mergePolicy );
$result = [
$target->getArticleID() => []
];
$pageSet->populateGeneratorData( $result );
$this->assertEquals( $expect, $result[$target->getArticleID()] );
}
/**
* @dataProvider provideRedirectMergePolicy
*/
public function testRedirectMergePolicyWithApiResult( $mergePolicy, $expect ) {
[ $target, $pageSet ] = $this->createPageSetWithRedirect();
$pageSet->setRedirectMergePolicy( $mergePolicy );
$result = new ApiResult( false );
$result->addValue( null, 'pages', [
$target->getArticleID() => []
] );
$pageSet->populateGeneratorData( $result, [ 'pages' ] );
$this->assertEquals(
$expect,
$result->getResultData( [ 'pages', $target->getArticleID() ] )
);
}
private function newApiPageSet( $reqParams = [] ) {
$request = new FauxRequest( $reqParams );
$context = new RequestContext();
$context->setRequest( $request );
$main = new ApiMain( $context );
$pageSet = new ApiPageSet( $main );
return $pageSet;
}
protected function createPageSetWithRedirect( $targetContent = 'api page set test' ) {
$target = Title::makeTitle( NS_MAIN, 'UTRedirectTarget' );
$sourceA = Title::makeTitle( NS_MAIN, 'UTRedirectSourceA' );
$sourceB = Title::makeTitle( NS_MAIN, 'UTRedirectSourceB' );
$this->editPage( 'UTRedirectTarget', $targetContent );
$this->editPage( 'UTRedirectSourceA', '#REDIRECT [[UTRedirectTarget]]' );
$this->editPage( 'UTRedirectSourceB', '#REDIRECT [[UTRedirectTarget]]' );
$pageSet = $this->newApiPageSet( [ 'redirects' => 1 ] );
$pageSet->setGeneratorData( $sourceA, [ 'index' => 1 ] );
$pageSet->setGeneratorData( $sourceB, [ 'index' => 3 ] );
$pageSet->populateFromTitles( [ $sourceA, $sourceB ] );
return [ $target, $pageSet ];
}
public function testRedirectMergePolicyRedirectLoop() {
$redirectOneTitle = 'ApiPageSetTestRedirectOne';
$redirectTwoTitle = 'ApiPageSetTestRedirectTwo';
$this->editPage( $redirectOneTitle, "#REDIRECT [[$redirectTwoTitle]]" );
$this->editPage( $redirectTwoTitle, "#REDIRECT [[$redirectOneTitle]]" );
[ $target, $pageSet ] = $this->createPageSetWithRedirect(
"#REDIRECT [[$redirectOneTitle]]"
);
$pageSet->setRedirectMergePolicy( static function ( $cur, $new ) {
throw new \RuntimeException( 'unreachable, no merge when target is redirect loop' );
} );
// This could infinite loop in a bugged impl, but php doesn't offer
// a great way to time constrain this.
$result = new ApiResult( false );
$pageSet->populateGeneratorData( $result );
// Assert something, mostly we care that the above didn't infinite loop.
// This verifies the page set followed our redirect chain and saw the loop.
$this->assertEqualsCanonicalizing(
[
'UTRedirectSourceA', 'UTRedirectSourceB', 'UTRedirectTarget',
$redirectOneTitle, $redirectTwoTitle,
],
array_map( static function ( $x ) {
return $x->getPrefixedText();
}, $pageSet->getTitles() )
);
}
public function testHandleNormalization() {
$pageSet = $this->newApiPageSet( [ 'titles' => "a|B|a\xcc\x8a" ] );
$pageSet->execute();
$this->assertSame(
[ 0 => [ 'A' => -1, 'B' => -2, 'Å' => -3 ] ],
$pageSet->getAllTitlesByNamespace()
);
$this->assertSame(
[
[ 'fromencoded' => true, 'from' => 'a%CC%8A', 'to' => 'å' ],
[ 'fromencoded' => false, 'from' => 'a', 'to' => 'A' ],
[ 'fromencoded' => false, 'from' => 'å', 'to' => 'Å' ],
],
$pageSet->getNormalizedTitlesAsResult()
);
}
public static function provideConversionWithRedirects() {
return [
'convert, redirect, convert' => [
[
'Esttay 1' => '#REDIRECT [[Test 2]]',
'Esttay 2' => '',
],
[ 'titles' => 'Test 1', 'converttitles' => 1, 'redirects' => 1 ],
[
[ 'from' => 'Test 1', 'to' => 'Esttay 1' ],
[ 'from' => 'Test 2', 'to' => 'Esttay 2' ]
],
[ [ 'from' => 'Esttay 1', 'to' => 'Test 2' ] ],
],
'redirect, convert, redirect' => [
[
'Esttay 1' => '#REDIRECT [[Test 2]]',
'Esttay 2' => '#REDIRECT [[Esttay 3]]',
],
[ 'titles' => 'Esttay 1', 'converttitles' => 1, 'redirects' => 1 ],
[ [ 'from' => 'Test 2', 'to' => 'Esttay 2' ] ],
[
[ 'from' => 'Esttay 1', 'to' => 'Test 2' ],
[ 'from' => 'Esttay 2', 'to' => 'Esttay 3' ]
],
],
'self-redirect to variant, with converttitles' => [
[ 'Esttay' => '#REDIRECT [[Test]]' ],
[ 'titles' => 'Esttay', 'converttitles' => 1, 'redirects' => 1 ],
[ [ 'from' => 'Test', 'to' => 'Esttay' ] ],
[ [ 'from' => 'Esttay', 'to' => 'Test' ] ],
],
'self-redirect to variant, without converttitles' => [
[ 'Esttay' => '#REDIRECT [[Test]]' ],
[ 'titles' => 'Esttay', 'redirects' => 1 ],
[],
[ [ 'from' => 'Esttay', 'to' => 'Test' ] ],
],
];
}
/**
* @dataProvider provideConversionWithRedirects
*/
public function testHandleConversionWithRedirects( $pages, $params, $expectedConversion, $expectedRedirects ) {
$this->overrideConfigValue( MainConfigNames::UsePigLatinVariant, true );
foreach ( $pages as $title => $content ) {
$this->editPage( $title, $content );
}
$pageSet = $this->newApiPageSet( $params );
$pageSet->execute();
$this->assertSame( $expectedConversion, $pageSet->getConvertedTitlesAsResult() );
$this->assertSame( $expectedRedirects, $pageSet->getRedirectTitlesAsResult() );
}
public function testSpecialRedirects() {
$id1 = $this->editPage( 'UTApiPageSet', 'UTApiPageSet in the default language' )
->getNewRevision()->getPageId();
$id2 = $this->editPage( 'UTApiPageSet/de', 'UTApiPageSet in German' )
->getNewRevision()->getPageId();
$user = $this->getTestUser()->getUser();
$userName = $user->getName();
$userDbkey = str_replace( ' ', '_', $userName );
$request = new FauxRequest( [
'titles' => implode( '|', [
'Special:MyContributions',
'Special:MyPage',
'Special:MyTalk/subpage',
'Special:MyLanguage/UTApiPageSet',
] ),
] );
$context = new RequestContext();
$context->setRequest( $request );
$context->setUser( $user );
$main = new ApiMain( $context );
$pageSet = new ApiPageSet( $main );
$pageSet->execute();
$this->assertEquals( [
], $pageSet->getRedirectTitlesAsResult() );
$this->assertEquals( [
[ 'ns' => NS_SPECIAL, 'title' => 'Special:MyContributions', 'special' => true ],
[ 'ns' => NS_SPECIAL, 'title' => 'Special:MyPage', 'special' => true ],
[ 'ns' => NS_SPECIAL, 'title' => 'Special:MyTalk/subpage', 'special' => true ],
[ 'ns' => NS_SPECIAL, 'title' => 'Special:MyLanguage/UTApiPageSet', 'special' => true ],
], $pageSet->getInvalidTitlesAndRevisions() );
$this->assertEquals( [
], $pageSet->getAllTitlesByNamespace() );
$request->setVal( 'redirects', 1 );
$main = new ApiMain( $context );
$pageSet = new ApiPageSet( $main );
$pageSet->execute();
$this->assertEquals( [
[ 'from' => 'Special:MyPage', 'to' => "User:$userName" ],
[ 'from' => 'Special:MyTalk/subpage', 'to' => "User talk:$userName/subpage" ],
[ 'from' => 'Special:MyLanguage/UTApiPageSet', 'to' => 'UTApiPageSet' ],
], $pageSet->getRedirectTitlesAsResult() );
$this->assertEquals( [
[ 'ns' => NS_SPECIAL, 'title' => 'Special:MyContributions', 'special' => true ],
[ 'ns' => NS_USER, 'title' => "User:$userName", 'missing' => true ],
[ 'ns' => NS_USER_TALK, 'title' => "User talk:$userName/subpage", 'missing' => true ],
], $pageSet->getInvalidTitlesAndRevisions() );
$this->assertEquals( [
NS_MAIN => [ 'UTApiPageSet' => $id1 ],
NS_USER => [ $userDbkey => -2 ],
NS_USER_TALK => [ "$userDbkey/subpage" => -3 ],
], $pageSet->getAllTitlesByNamespace() );
$context->setLanguage( 'de' );
$main = new ApiMain( $context );
$pageSet = new ApiPageSet( $main );
$pageSet->execute();
$this->assertEquals( [
[ 'from' => 'Special:MyPage', 'to' => "User:$userName" ],
[ 'from' => 'Special:MyTalk/subpage', 'to' => "User talk:$userName/subpage" ],
[ 'from' => 'Special:MyLanguage/UTApiPageSet', 'to' => 'UTApiPageSet/de' ],
], $pageSet->getRedirectTitlesAsResult() );
$this->assertEquals( [
[ 'ns' => NS_SPECIAL, 'title' => 'Special:MyContributions', 'special' => true ],
[ 'ns' => NS_USER, 'title' => "User:$userName", 'missing' => true ],
[ 'ns' => NS_USER_TALK, 'title' => "User talk:$userName/subpage", 'missing' => true ],
], $pageSet->getInvalidTitlesAndRevisions() );
$this->assertEquals( [
NS_MAIN => [ 'UTApiPageSet/de' => $id2 ],
NS_USER => [ $userDbkey => -2 ],
NS_USER_TALK => [ "$userDbkey/subpage" => -3 ],
], $pageSet->getAllTitlesByNamespace() );
}
/**
* Test that ApiPageSet is calling GenderCache for provided user names to prefill the
* GenderCache and avoid a performance issue when loading each users' gender on its own.
* The test is setting the "missLimit" to 0 on the GenderCache to trigger misses logic.
* When the "misses" property is no longer 0 at the end of the test,
* something was requested which is not part of the cache. Than the test is failing.
*/
public function testGenderCaching() {
// Create the test user now so that the cache will be empty later
$this->getTestSysop()->getUser();
// Set up the user namespace to have gender aliases to trigger the gender cache
$this->overrideConfigValue(
MainConfigNames::ExtraGenderNamespaces,
[ NS_USER => [ 'male' => 'Male', 'female' => 'Female' ] ]
);
$this->overrideMwServices();
// User names to test with - it is not needed that the user exists in the database
// to trigger gender cache
$userNames = [
'Female',
'Unknown',
'Male',
];
// Prepare the gender cache for testing - this is a fresh instance due to service override
$genderCache = TestingAccessWrapper::newFromObject(
$this->getServiceContainer()->getGenderCache()
);
$genderCache->missLimit = 0;
// Do an api request to trigger ApiPageSet code
$this->doApiRequest( [
'action' => 'query',
'titles' => 'User:' . implode( '|User:', $userNames ),
] );
$this->assertSame( 0, $genderCache->misses,
'ApiPageSet does not prefill the gender cache correctly' );
$this->assertEquals( $userNames, array_keys( $genderCache->cache ),
'ApiPageSet does not prefill all users into the gender cache' );
}
public function testPopulateFromTitles() {
$interwikiLookup = $this->getDummyInterwikiLookup( [ 'acme' ] );
$this->setService( 'InterwikiLookup', $interwikiLookup );
$this->getExistingTestPage( 'ApiPageSetTest_existing' )->getTitle();
$this->getExistingTestPage( 'ApiPageSetTest_redirect_target' )->getTitle();
$this->getNonexistingTestPage( 'ApiPageSetTest_missing' )->getTitle();
$redirectTitle = $this->getExistingTestPage( 'ApiPageSetTest_redirect' )->getTitle();
$this->editPage( $redirectTitle, '#REDIRECT [[ApiPageSetTest_redirect_target]]' );
$input = [
'existing' => 'ApiPageSetTest_existing',
'missing' => 'ApiPageSetTest_missing',
'invalid' => 'ApiPageSetTest|invalid',
'redirect' => 'ApiPageSetTest_redirect',
'special' => 'Special:BlankPage',
'interwiki' => 'acme:ApiPageSetTest',
];
$pageSet = $this->newApiPageSet( [ 'redirects' => 1 ] );
$pageSet->populateFromTitles( $input );
$expectedPages = [
new TitleValue( NS_MAIN, 'ApiPageSetTest_existing' ),
new TitleValue( NS_MAIN, 'ApiPageSetTest_redirect' ),
new TitleValue( NS_MAIN, 'ApiPageSetTest_missing' ),
// the redirect page and the target are included!
new TitleValue( NS_MAIN, 'ApiPageSetTest_redirect_target' ),
];
$this->assertLinkTargets( Title::class, $expectedPages, $pageSet->getTitles() );
$this->assertLinkTargets( PageIdentity::class, $expectedPages, $pageSet->getPages() );
$expectedGood = [
new TitleValue( NS_MAIN, 'ApiPageSetTest_existing' ),
new TitleValue( NS_MAIN, 'ApiPageSetTest_redirect_target' )
];
$this->assertLinkTargets( Title::class, $expectedGood, $pageSet->getGoodTitles() );
$this->assertLinkTargets( PageIdentity::class, $expectedGood, $pageSet->getGoodPages() );
$expectedMissing = [ new TitleValue( NS_MAIN, 'ApiPageSetTest_missing' ) ];
$this->assertLinkTargets(
Title::class,
$expectedMissing,
$pageSet->getMissingTitles()
);
$this->assertLinkTargets(
PageIdentity::class,
$expectedMissing,
$pageSet->getMissingPages()
);
$this->assertSame(
[ NS_MAIN => [ 'ApiPageSetTest_missing' => -3 ] ],
$pageSet->getMissingTitlesByNamespace()
);
$expectedGoodAndMissing = array_merge( $expectedGood, $expectedMissing );
$this->assertLinkTargets(
Title::class,
$expectedGoodAndMissing,
$pageSet->getGoodAndMissingTitles()
);
$this->assertLinkTargets(
PageIdentity::class,
$expectedGoodAndMissing,
$pageSet->getGoodAndMissingPages()
);
$expectedSpecial = [ new TitleValue( NS_SPECIAL, 'BlankPage' ) ];
$this->assertLinkTargets( Title::class, $expectedSpecial, $pageSet->getSpecialTitles() );
$this->assertLinkTargets( PageReference::class, $expectedSpecial, $pageSet->getSpecialPages() );
$expectedRedirects = [
'ApiPageSetTest redirect' => new TitleValue(
NS_MAIN, 'ApiPageSetTest_redirect_target'
)
];
$this->assertLinkTargets( Title::class, $expectedRedirects, $pageSet->getRedirectTitles() );
$this->assertLinkTargets( LinkTarget::class, $expectedRedirects, $pageSet->getRedirectTargets() );
$this->assertSame( [ 'acme:ApiPageSetTest' => 'acme' ], $pageSet->getInterwikiTitles() );
$this->assertSame(
[ [ 'title' => 'acme:ApiPageSetTest', 'iw' => 'acme' ] ],
$pageSet->getInterwikiTitlesAsResult()
);
$this->assertSame(
[ -1 => [
'title' => 'ApiPageSetTest|invalid',
'invalidreason' => 'The requested page title contains invalid characters: "|".'
] ],
$pageSet->getInvalidTitlesAndReasons()
);
}
/**
* @param string $type
* @param LinkTarget[] $expected
* @param LinkTarget[]|PageReference[] $actual
*/
private function assertLinkTargets( $type, $expected, $actual ) {
reset( $actual );
foreach ( $expected as $expKey => $exp ) {
$act = current( $actual );
$this->assertNotFalse( $act, 'missing entry at key $expKey: ' . $exp );
$actKey = key( $actual );
next( $actual );
if ( !is_int( $expKey ) ) {
$this->assertSame( $expKey, $actKey );
}
$this->assertSame( $exp->getNamespace(), $act->getNamespace() );
$this->assertSame( $exp->getDBkey(), $act->getDBkey() );
$this->assertInstanceOf( $type, $act );
if ( $actual instanceof LinkTarget ) {
$this->assertSame( $exp->getFragment(), $act->getFragment() );
$this->assertSame( $exp->getInterwiki(), $act->getInterwiki() );
}
}
$act = current( $actual );
$this->assertFalse( $act, 'extra entry: ' . $act );
}
}
|