1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
|
<?php
namespace MediaWiki\HookContainer {
use ExtensionRegistry;
use Wikimedia\ScopedCallback;
class HookContainerIntegrationTest extends \MediaWikiIntegrationTestCase {
/**
* @covers \MediaWiki\HookContainer\HookContainer::run
*/
public function testHookRunsWhenExtensionRegistered() {
$hookContainer = $this->getServiceContainer()->getHookContainer();
$extensionRegistry = ExtensionRegistry::getInstance();
$numHandlersExecuted = 0;
$handlers = [ 'FooHook' => [ [
'handler' => [
'class' => 'FooExtension\\FooExtensionHooks',
'name' => 'FooExtension-FooHandler',
] ] ]
];
$reset = $extensionRegistry->setAttributeForTest( 'Hooks', $handlers );
$this->assertSame( 0, $numHandlersExecuted );
$hookContainer->run( 'FooHook', [ &$numHandlersExecuted ] );
$this->assertSame( 1, $numHandlersExecuted );
ScopedCallback::consume( $reset );
}
/**
* @covers \MediaWiki\HookContainer\HookContainer::run
* @covers \MediaWiki\HookContainer\HookContainer::scopedRegister
*/
public function testPreviouslyRegisteredHooksAreReAppliedAfterScopedRegisterRemovesThem() {
$hookContainer = $this->getServiceContainer()->getHookContainer();
// Some handlers for FooHook have been previously set
$reset = $hookContainer->register( 'FooHook', static function () {
return true;
} );
$reset1 = $hookContainer->register( 'FooHook', static function () {
return true;
} );
$handlersBeforeScopedRegister = $hookContainer->getLegacyHandlers( 'FooHook' );
$this->assertCount( 2, $handlersBeforeScopedRegister );
// Wipe out the 2 existing handlers and add a new scoped handler
$reset2 = $hookContainer->scopedRegister( 'FooHook', static function () {
return true;
}, true );
$handlersAfterScopedRegister = $hookContainer->getLegacyHandlers( 'FooHook' );
$this->assertCount( 1, $handlersAfterScopedRegister );
ScopedCallback::consume( $reset2 );
// Teardown causes the original handlers to be re-applied
$this->mediaWikiTearDown();
$handlersAfterTearDown = $hookContainer->getLegacyHandlers( 'FooHook' );
$this->assertCount( 2, $handlersAfterTearDown );
}
/**
* @covers \MediaWiki\HookContainer\HookContainer::run
* @covers \MediaWiki\HookContainer\HookContainer::scopedRegister
*/
public function testHookRunsWithMultipleMixedHandlerTypes() {
$hookContainer = $this->getServiceContainer()->getHookContainer();
$numHandlersExecuted = 0;
$reset = $hookContainer->scopedRegister( 'FooHook', static function ( &$numHandlersRun ) {
$numHandlersRun++;
}, false );
$reset2 = $hookContainer->scopedRegister( 'FooHook', static function ( &$numHandlersRun ) {
$numHandlersRun++;
}, false );
$handlerThree = [
'FooHook' => [
[ 'handler' => [
'class' => 'FooExtension\\FooExtensionHooks',
'name' => 'FooExtension-FooHandler',
]
]
]
];
$reset3 = ExtensionRegistry::getInstance()->setAttributeForTest( 'Hooks', $handlerThree );
$hookContainer->run( 'FooHook', [ &$numHandlersExecuted ] );
$this->assertEquals( 3, $numHandlersExecuted );
ScopedCallback::consume( $reset );
ScopedCallback::consume( $reset2 );
ScopedCallback::consume( $reset3 );
}
/**
* @covers \MediaWiki\HookContainer\HookContainer
*/
public function testValidServiceInjection() {
$handler = [
'handler' => [
'name' => 'FooExtension-Mash',
'class' => 'FooExtension\\ServiceHooks',
'services' => [ 'ReadOnlyMode' ]
],
'extensionPath' => '/path/to/extension.json'
];
$hooks = [ 'Mash' => [ $handler ] ];
$hookContainer = $this->getServiceContainer()->getHookContainer();
$reset = ExtensionRegistry::getInstance()->setAttributeForTest( 'Hooks', $hooks );
$arg = 0;
$ret = $hookContainer->run( 'Mash', [ &$arg ] );
$this->assertTrue( $ret );
$this->assertSame( 1, $arg );
}
/**
* @covers \MediaWiki\HookContainer\HookContainer
*/
public function testInvalidServiceInjection() {
$handler = [
'handler' => [
'name' => 'FooExtension-Mash',
'class' => 'FooExtension\\ServiceHooks',
'services' => [ 'ReadOnlyMode' ]
],
'extensionPath' => '/path/to/extension.json'
];
$hooks = [ 'Mash' => [ $handler ] ];
$hookContainer = $this->getServiceContainer()->getHookContainer();
$reset = ExtensionRegistry::getInstance()->setAttributeForTest( 'Hooks', $hooks );
$this->expectException( \UnexpectedValueException::class );
$arg = 0;
$hookContainer->run( 'Mash', [ &$arg ], [ 'noServices' => true ] );
}
}
}
namespace FooExtension {
class FooExtensionHooks {
public function onFooHook( &$numHandlersRun ) {
$numHandlersRun++;
}
}
class ServiceHooks {
public function __construct( \ReadOnlyMode $readOnlyMode ) {
}
public function onMash( &$arg ) {
$arg++;
return true;
}
}
}
|
