1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
|
<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
*/
use MediaWiki\Logger\LoggerFactory;
use MediaWiki\MediaWikiServices;
use MediaWiki\Status\Status;
use MediaWiki\Title\Title;
use Psr\Log\LoggerInterface;
use Wikimedia\Rdbms\IDatabase;
use Wikimedia\Rdbms\RawSQLValue;
use Wikimedia\ScopedCallback;
/**
* Helper class for file movement
*
* @ingroup FileAbstraction
*/
class LocalFileMoveBatch {
/** @var LocalFile */
protected $file;
/** @var Title */
protected $target;
/** @var string[] */
protected $cur;
/** @var string[][] */
protected $olds;
/** @var int */
protected $oldCount;
/** @var IDatabase */
protected $db;
/** @var string */
protected $oldHash;
/** @var string */
protected $newHash;
/** @var string */
protected $oldName;
/** @var string */
protected $newName;
/** @var string */
protected $oldRel;
/** @var string */
protected $newRel;
/** @var LoggerInterface */
private $logger;
/** @var bool */
private $haveSourceLock = false;
/** @var bool */
private $haveTargetLock = false;
/** @var LocalFile|null */
private $targetFile;
/**
* @param LocalFile $file
* @param Title $target
*/
public function __construct( LocalFile $file, Title $target ) {
$this->file = $file;
$this->target = $target;
$this->oldHash = $this->file->repo->getHashPath( $this->file->getName() );
$this->newHash = $this->file->repo->getHashPath( $this->target->getDBkey() );
$this->oldName = $this->file->getName();
$this->newName = $this->file->repo->getNameFromTitle( $this->target );
$this->oldRel = $this->oldHash . $this->oldName;
$this->newRel = $this->newHash . $this->newName;
$this->db = $file->getRepo()->getPrimaryDB();
$this->logger = LoggerFactory::getInstance( 'imagemove' );
}
/**
* Add the current image to the batch
*
* @return Status
*/
public function addCurrent() {
$status = $this->acquireSourceLock();
if ( $status->isOK() ) {
$this->cur = [ $this->oldRel, $this->newRel ];
}
return $status;
}
/**
* Add the old versions of the image to the batch
* @return string[] List of archive names from old versions
*/
public function addOlds() {
$archiveBase = 'archive';
$this->olds = [];
$this->oldCount = 0;
$archiveNames = [];
$result = $this->db->newSelectQueryBuilder()
->select( [ 'oi_archive_name', 'oi_deleted' ] )
->forUpdate() // ignore snapshot
->from( 'oldimage' )
->where( [ 'oi_name' => $this->oldName ] )
->caller( __METHOD__ )->fetchResultSet();
foreach ( $result as $row ) {
$archiveNames[] = $row->oi_archive_name;
$oldName = $row->oi_archive_name;
$bits = explode( '!', $oldName, 2 );
if ( count( $bits ) != 2 ) {
$this->logger->debug(
'Old file name missing !: {oldName}',
[ 'oldName' => $oldName ]
);
continue;
}
[ $timestamp, $filename ] = $bits;
if ( $this->oldName != $filename ) {
$this->logger->debug(
'Old file name does not match: {oldName}',
[ 'oldName' => $oldName ]
);
continue;
}
$this->oldCount++;
// Do we want to add those to oldCount?
if ( $row->oi_deleted & File::DELETED_FILE ) {
continue;
}
$this->olds[] = [
"{$archiveBase}/{$this->oldHash}{$oldName}",
"{$archiveBase}/{$this->newHash}{$timestamp}!{$this->newName}"
];
}
return $archiveNames;
}
/**
* Acquire the source file lock, if it has not been acquired already
*
* @return Status
*/
protected function acquireSourceLock() {
if ( $this->haveSourceLock ) {
return Status::newGood();
}
$status = $this->file->acquireFileLock();
if ( $status->isOK() ) {
$this->haveSourceLock = true;
}
return $status;
}
/**
* Acquire the target file lock, if it has not been acquired already
*
* @return Status
*/
protected function acquireTargetLock() {
if ( $this->haveTargetLock ) {
return Status::newGood();
}
$status = $this->getTargetFile()->acquireFileLock();
if ( $status->isOK() ) {
$this->haveTargetLock = true;
}
return $status;
}
/**
* Release both file locks
*/
protected function releaseLocks() {
if ( $this->haveSourceLock ) {
$this->file->releaseFileLock();
$this->haveSourceLock = false;
}
if ( $this->haveTargetLock ) {
$this->getTargetFile()->releaseFileLock();
$this->haveTargetLock = false;
}
}
/**
* Get the target file
*
* @return LocalFile
*/
protected function getTargetFile() {
if ( $this->targetFile === null ) {
$this->targetFile = MediaWikiServices::getInstance()->getRepoGroup()->getLocalRepo()
->newFile( $this->target );
}
return $this->targetFile;
}
/**
* Perform the move.
* @return Status
*/
public function execute() {
$repo = $this->file->repo;
$status = $repo->newGood();
$status->merge( $this->acquireSourceLock() );
if ( !$status->isOK() ) {
return $status;
}
$status->merge( $this->acquireTargetLock() );
if ( !$status->isOK() ) {
$this->releaseLocks();
return $status;
}
$unlockScope = new ScopedCallback( function () {
$this->releaseLocks();
} );
$triplets = $this->getMoveTriplets();
$checkStatus = $this->removeNonexistentFiles( $triplets );
if ( !$checkStatus->isGood() ) {
$status->merge( $checkStatus ); // couldn't talk to file backend
return $status;
}
$triplets = $checkStatus->value;
// Verify the file versions metadata in the DB.
$statusDb = $this->verifyDBUpdates();
if ( !$statusDb->isGood() ) {
$statusDb->setOK( false );
return $statusDb;
}
if ( !$repo->hasSha1Storage() ) {
// Copy the files into their new location.
// If a prior process fataled copying or cleaning up files we tolerate any
// of the existing files if they are identical to the ones being stored.
$statusMove = $repo->storeBatch( $triplets, FileRepo::OVERWRITE_SAME );
$this->logger->debug(
'Moved files for {fileName}: {successCount} successes, {failCount} failures',
[
'fileName' => $this->file->getName(),
'successCount' => $statusMove->successCount,
'failCount' => $statusMove->failCount,
]
);
if ( !$statusMove->isGood() ) {
// Delete any files copied over (while the destination is still locked)
$this->cleanupTarget( $triplets );
$this->logger->debug(
'Error in moving files: {error}',
[ 'error' => $statusMove->getWikiText( false, false, 'en' ) ]
);
$statusMove->setOK( false );
return $statusMove;
}
$status->merge( $statusMove );
}
// Rename the file versions metadata in the DB.
$this->doDBUpdates();
$this->logger->debug(
'Renamed {fileName} in database: {successCount} successes, {failCount} failures',
[
'fileName' => $this->file->getName(),
'successCount' => $statusDb->successCount,
'failCount' => $statusDb->failCount,
]
);
// Everything went ok, remove the source files
$this->cleanupSource( $triplets );
// Defer lock release until the transaction is committed.
if ( $this->db->trxLevel() ) {
ScopedCallback::cancel( $unlockScope );
$this->db->onTransactionResolution( function () {
$this->releaseLocks();
}, __METHOD__ );
} else {
ScopedCallback::consume( $unlockScope );
}
$status->merge( $statusDb );
return $status;
}
/**
* Verify the database updates and return a new Status indicating how
* many rows would be updated.
*
* @return Status
*/
protected function verifyDBUpdates() {
$repo = $this->file->repo;
$status = $repo->newGood();
$dbw = $this->db;
// Lock the image row
$hasCurrent = $dbw->newSelectQueryBuilder()
->from( 'image' )
->where( [ 'img_name' => $this->oldName ] )
->forUpdate()
->caller( __METHOD__ )
->fetchRowCount();
// Lock the oldimage rows
$oldRowCount = $dbw->newSelectQueryBuilder()
->from( 'oldimage' )
->where( [ 'oi_name' => $this->oldName ] )
->forUpdate()
->caller( __METHOD__ )
->fetchRowCount();
if ( $hasCurrent ) {
$status->successCount++;
} else {
$status->failCount++;
}
$status->successCount += $oldRowCount;
// T36934: oldCount is based on files that actually exist.
// There may be more DB rows than such files, in which case $affected
// can be greater than $total. We use max() to avoid negatives here.
$status->failCount += max( 0, $this->oldCount - $oldRowCount );
if ( $status->failCount ) {
$status->error( 'imageinvalidfilename' );
}
return $status;
}
/**
* Do the database updates and return a new Status indicating how
* many rows where updated.
*/
protected function doDBUpdates() {
$dbw = $this->db;
// Update current image
$dbw->newUpdateQueryBuilder()
->update( 'image' )
->set( [ 'img_name' => $this->newName ] )
->where( [ 'img_name' => $this->oldName ] )
->caller( __METHOD__ )->execute();
// Update old images
$dbw->newUpdateQueryBuilder()
->update( 'oldimage' )
->set( [
'oi_name' => $this->newName,
'oi_archive_name' => new RawSQLValue( $dbw->strreplace(
'oi_archive_name',
$dbw->addQuotes( $this->oldName ),
$dbw->addQuotes( $this->newName )
) ),
] )
->where( [ 'oi_name' => $this->oldName ] )
->caller( __METHOD__ )->execute();
}
/**
* Generate triplets for FileRepo::storeBatch().
* @return array[]
*/
protected function getMoveTriplets() {
$moves = array_merge( [ $this->cur ], $this->olds );
$triplets = []; // The format is: (srcUrl, destZone, destUrl)
foreach ( $moves as $move ) {
// $move: (oldRelativePath, newRelativePath)
$srcUrl = $this->file->repo->getVirtualUrl() . '/public/' . rawurlencode( $move[0] );
$triplets[] = [ $srcUrl, 'public', $move[1] ];
$this->logger->debug(
'Generated move triplet for {fileName}: {srcUrl} :: public :: {move1}',
[
'fileName' => $this->file->getName(),
'srcUrl' => $srcUrl,
'move1' => $move[1],
]
);
}
return $triplets;
}
/**
* Removes non-existent files from move batch.
* @param array[] $triplets
* @return Status
*/
protected function removeNonexistentFiles( $triplets ) {
$files = [];
foreach ( $triplets as $file ) {
$files[$file[0]] = $file[0];
}
$result = $this->file->repo->fileExistsBatch( $files );
if ( in_array( null, $result, true ) ) {
return Status::newFatal( 'backend-fail-internal',
$this->file->repo->getBackend()->getName() );
}
$filteredTriplets = [];
foreach ( $triplets as $file ) {
if ( $result[$file[0]] ) {
$filteredTriplets[] = $file;
} else {
$this->logger->debug(
'File {file} does not exist',
[ 'file' => $file[0] ]
);
}
}
return Status::newGood( $filteredTriplets );
}
/**
* Cleanup a partially moved array of triplets by deleting the target
* files. Called if something went wrong half way.
* @param array[] $triplets
*/
protected function cleanupTarget( $triplets ) {
// Create dest pairs from the triplets
$pairs = [];
foreach ( $triplets as $triplet ) {
// $triplet: (old source virtual URL, dst zone, dest rel)
$pairs[] = [ $triplet[1], $triplet[2] ];
}
$this->file->repo->cleanupBatch( $pairs );
}
/**
* Cleanup a fully moved array of triplets by deleting the source files.
* Called at the end of the move process if everything else went ok.
* @param array[] $triplets
*/
protected function cleanupSource( $triplets ) {
// Create source file names from the triplets
$files = [];
foreach ( $triplets as $triplet ) {
$files[] = $triplet[0];
}
$this->file->repo->cleanupBatch( $files );
}
}
|