1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
|
<?php
/**
* Methods to help with the actor table migration
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
*/
use MediaWiki\User\ActorStoreFactory;
use MediaWiki\User\UserIdentity;
use Wikimedia\IPUtils;
use Wikimedia\Rdbms\IDatabase;
/**
* This abstract base class helps migrate core and extension code to use the
* actor table.
*
* @stable to extend
* @since 1.37
*/
class ActorMigrationBase {
/** @var array[] Cache for `self::getJoin()` */
private $joinCache = [];
/** @var int Combination of SCHEMA_COMPAT_* constants */
private $stage;
/** @var ActorStoreFactory */
private $actorStoreFactory;
/** @var array */
private $fieldInfos;
/** @var bool */
private $allowUnknown;
/**
* @param array $fieldInfos An array of associative arrays, giving configuration
* information about fields which are being migrated. Subkeys are:
* - removedVersion: The version in which the field was removed
* - deprecatedVersion: The version in which the field was deprecated
* - component: The component for removedVersion and deprecatedVersion.
* Default: MediaWiki.
* - textField: Override the old text field name. Default {$key}_text.
* - actorField: Override the actor field name. Default {$key}_actor.
* - tempTable: An array of information about the temp table linking
* the old table to the actor table. Default: no temp table is used.
* If set, the following subkeys must be present:
* - table: Temporary table name
* - pk: Temporary table column referring to the main table's primary key
* - field: Temporary table column referring actor.actor_id
* - joinPK: Main table's primary key
* - extra: An array of extra field names to be copied into the
* temp table for indexing. The key is the field name in the temp
* table, and the value is the field name in the main table.
* - formerTempTableVersion: The version of the component in which this
* field used a temp table. If present, getInsertValuesWithTempTable()
* still works, but issues a deprecation warning.
* All subkeys are optional.
*
* @stable to override
* @stable to call
*
* @param int $stage The migration stage
* @param ActorStoreFactory $actorStoreFactory
* @param array $options Array of other options. May contain:
* - allowUnknown: Allow fields not present in $fieldInfos. True by default.
*/
public function __construct(
$fieldInfos,
$stage,
ActorStoreFactory $actorStoreFactory,
$options = []
) {
$this->fieldInfos = $fieldInfos;
$this->allowUnknown = $options['allowUnknown'] ?? true;
if ( ( $stage & SCHEMA_COMPAT_WRITE_BOTH ) === 0 ) {
throw new InvalidArgumentException( '$stage must include a write mode' );
}
if ( ( $stage & SCHEMA_COMPAT_READ_BOTH ) === 0 ) {
throw new InvalidArgumentException( '$stage must include a read mode' );
}
if ( ( $stage & SCHEMA_COMPAT_READ_BOTH ) === SCHEMA_COMPAT_READ_BOTH ) {
throw new InvalidArgumentException( 'Cannot read both schemas' );
}
if ( ( $stage & SCHEMA_COMPAT_READ_OLD ) && !( $stage & SCHEMA_COMPAT_WRITE_OLD ) ) {
throw new InvalidArgumentException( 'Cannot read the old schema without also writing it' );
}
if ( ( $stage & SCHEMA_COMPAT_READ_NEW ) && !( $stage & SCHEMA_COMPAT_WRITE_NEW ) ) {
throw new InvalidArgumentException( 'Cannot read the new schema without also writing it' );
}
$this->stage = $stage;
$this->actorStoreFactory = $actorStoreFactory;
}
/**
* Get config information about a field.
*
* @stable to override
*
* @param string $key
* @return array
*/
protected function getFieldInfo( $key ) {
if ( isset( $this->fieldInfos[$key] ) ) {
return $this->fieldInfos[$key];
} elseif ( $this->allowUnknown ) {
return [];
} else {
throw new InvalidArgumentException( $this->getInstanceName() . ": unknown key $key" );
}
}
/**
* Get a name for this instance to use in error messages
*
* @stable to override
*
* @return string
* @throws ReflectionException
*/
protected function getInstanceName() {
if ( ( new ReflectionClass( $this ) )->isAnonymous() ) {
// Mostly for PHPUnit
return self::class;
} else {
return static::class;
}
}
/**
* Issue deprecation warning/error as appropriate.
*
* @internal
*
* @param string $key
*/
protected function checkDeprecation( $key ) {
$fieldInfo = $this->getFieldInfo( $key );
if ( isset( $fieldInfo['removedVersion'] ) ) {
$removedVersion = $fieldInfo['removedVersion'];
$component = $fieldInfo['component'] ?? 'MediaWiki';
throw new InvalidArgumentException(
"Use of {$this->getInstanceName()} for '$key' was removed in $component $removedVersion"
);
}
if ( isset( $fieldInfo['deprecatedVersion'] ) ) {
$deprecatedVersion = $fieldInfo['deprecatedVersion'];
$component = $fieldInfo['component'] ?? 'MediaWiki';
wfDeprecated( "{$this->getInstanceName()} for '$key'", $deprecatedVersion, $component, 3 );
}
}
/**
* Return an SQL condition to test if a user field is anonymous
* @param string $field Field name or SQL fragment
* @return string
*/
public function isAnon( $field ) {
return ( $this->stage & SCHEMA_COMPAT_READ_NEW ) ? "$field IS NULL" : "$field = 0";
}
/**
* Return an SQL condition to test if a user field is non-anonymous
* @param string $field Field name or SQL fragment
* @return string
*/
public function isNotAnon( $field ) {
return ( $this->stage & SCHEMA_COMPAT_READ_NEW ) ? "$field IS NOT NULL" : "$field != 0";
}
/**
* @param string $key A key such as "rev_user" identifying the actor
* field being fetched.
* @return string[] [ $text, $actor ]
*/
private function getFieldNames( $key ) {
$fieldInfo = $this->getFieldInfo( $key );
$textField = $fieldInfo['textField'] ?? $key . '_text';
$actorField = $fieldInfo['actorField'] ?? substr( $key, 0, -5 ) . '_actor';
return [ $textField, $actorField ];
}
/**
* Convenience function for getting temp table config
*
* @param string $key
* @return array|null
*/
private function getTempTableInfo( $key ) {
$fieldInfo = $this->getFieldInfo( $key );
return $fieldInfo['tempTable'] ?? null;
}
/**
* Get SELECT fields and joins for the actor key
*
* @param string $key A key such as "rev_user" identifying the actor
* field being fetched.
* @return array[] With three keys:
* - tables: (string[]) to include in the `$table` to `IDatabase->select()`
* - fields: (string[]) to include in the `$vars` to `IDatabase->select()`
* - joins: (array) to include in the `$join_conds` to `IDatabase->select()`
* All tables, fields, and joins are aliased, so `+` is safe to use.
* @phan-return array{tables:string[],fields:string[],joins:array}
*/
public function getJoin( $key ) {
$this->checkDeprecation( $key );
if ( !isset( $this->joinCache[$key] ) ) {
$tables = [];
$fields = [];
$joins = [];
list( $text, $actor ) = $this->getFieldNames( $key );
if ( $this->stage & SCHEMA_COMPAT_READ_OLD ) {
$fields[$key] = $key;
$fields[$text] = $text;
$fields[$actor] = 'NULL';
} else {
$tempTableInfo = $this->getTempTableInfo( $key );
if ( $tempTableInfo ) {
$alias = "temp_$key";
$tables[$alias] = $tempTableInfo['table'];
$joins[$alias] = [ 'JOIN',
"{$alias}.{$tempTableInfo['pk']} = {$tempTableInfo['joinPK']}" ];
$joinField = "{$alias}.{$tempTableInfo['field']}";
} else {
$joinField = $actor;
}
$alias = "actor_$key";
$tables[$alias] = 'actor';
$joins[$alias] = [ 'JOIN', "{$alias}.actor_id = {$joinField}" ];
$fields[$key] = "{$alias}.actor_user";
$fields[$text] = "{$alias}.actor_name";
$fields[$actor] = $joinField;
}
$this->joinCache[$key] = [
'tables' => $tables,
'fields' => $fields,
'joins' => $joins,
];
}
return $this->joinCache[$key];
}
/**
* Get actor ID from UserIdentity, if it exists
*
* @since 1.35.0
* @deprecated since 1.36. Use ActorStore::findActorId instead.
*
* @param IDatabase $db
* @param UserIdentity $user
* @return int|false
*/
public function getExistingActorId( IDatabase $db, UserIdentity $user ) {
wfDeprecated( __METHOD__, '1.36' );
// Get the correct ActorStore based on the DB passed,
// and not on the passed $user wiki ID, since before all
// User object are LOCAL, but the databased passed here can be
// foreign.
return $this->actorStoreFactory
->getActorNormalization( $db->getDomainID() )
->findActorId( $user, $db );
}
/**
* Attempt to assign an actor ID to the given user.
* If it is already assigned, return the existing ID.
*
* @since 1.35.0
* @deprecated since 1.36. Use ActorStore::acquireActorId instead.
*
* @param IDatabase $dbw
* @param UserIdentity $user
*
* @return int The new actor ID
*/
public function getNewActorId( IDatabase $dbw, UserIdentity $user ) {
wfDeprecated( __METHOD__, '1.36' );
// Get the correct ActorStore based on the DB passed,
// and not on the passed $user wiki ID, since before all
// User object are LOCAL, but the databased passed here can be
// foreign.
return $this->actorStoreFactory
->getActorNormalization( $dbw->getDomainID() )
->acquireActorId( $user, $dbw );
}
/**
* Get UPDATE fields for the actor
*
* @param IDatabase $dbw Database to use for creating an actor ID, if necessary
* @param string $key A key such as "rev_user" identifying the actor
* field being fetched.
* @param UserIdentity $user User to set in the update
* @return array to merge into `$values` to `IDatabase->update()` or `$a` to `IDatabase->insert()`
*/
public function getInsertValues( IDatabase $dbw, $key, UserIdentity $user ) {
$this->checkDeprecation( $key );
if ( $this->getTempTableInfo( $key ) ) {
throw new InvalidArgumentException( "Must use getInsertValuesWithTempTable() for $key" );
}
list( $text, $actor ) = $this->getFieldNames( $key );
$ret = [];
if ( $this->stage & SCHEMA_COMPAT_WRITE_OLD ) {
$ret[$key] = $user->getId();
$ret[$text] = $user->getName();
}
if ( $this->stage & SCHEMA_COMPAT_WRITE_NEW ) {
$ret[$actor] = $this->actorStoreFactory
->getActorNormalization( $dbw->getDomainID() )
->acquireActorId( $user, $dbw );
}
return $ret;
}
/**
* Get UPDATE fields for the actor
*
* @param IDatabase $dbw Database to use for creating an actor ID, if necessary
* @param string $key A key such as "rev_user" identifying the actor
* field being fetched.
* @param UserIdentity $user User to set in the update
* @return array with two values:
* - array to merge into `$values` to `IDatabase->update()` or `$a` to `IDatabase->insert()`
* - callback to call with the primary key for the main table insert
* and extra fields needed for the temp table.
*/
public function getInsertValuesWithTempTable( IDatabase $dbw, $key, UserIdentity $user ) {
$this->checkDeprecation( $key );
$fieldInfo = $this->getFieldInfo( $key );
$tempTableInfo = $fieldInfo['tempTable'] ?? null;
if ( isset( $fieldInfo['formerTempTableVersion'] ) ) {
wfDeprecated( __METHOD__ . " for $key",
$fieldInfo['formerTempTableVersion'],
$fieldInfo['component'] ?? 'MediaWiki' );
} elseif ( !$tempTableInfo ) {
throw new InvalidArgumentException( "Must use getInsertValues() for $key" );
}
list( $text, $actor ) = $this->getFieldNames( $key );
$ret = [];
$callback = null;
if ( $this->stage & SCHEMA_COMPAT_WRITE_OLD ) {
$ret[$key] = $user->getId();
$ret[$text] = $user->getName();
}
if ( $this->stage & SCHEMA_COMPAT_WRITE_NEW ) {
$id = $this->actorStoreFactory
->getActorNormalization( $dbw->getDomainID() )
->acquireActorId( $user, $dbw );
if ( $tempTableInfo ) {
$func = __METHOD__;
$callback = static function ( $pk, array $extra ) use ( $tempTableInfo, $dbw, $id, $func ) {
$set = [ $tempTableInfo['field'] => $id ];
foreach ( $tempTableInfo['extra'] as $to => $from ) {
if ( !array_key_exists( $from, $extra ) ) {
throw new InvalidArgumentException( "$func callback: \$extra[$from] is not provided" );
}
$set[$to] = $extra[$from];
}
$dbw->upsert(
$tempTableInfo['table'],
[ $tempTableInfo['pk'] => $pk ] + $set,
[ [ $tempTableInfo['pk'] ] ],
$set,
$func
);
};
} else {
$ret[$actor] = $id;
$callback = static function ( $pk, array $extra ) {
};
}
} elseif ( $tempTableInfo ) {
$func = __METHOD__;
$callback = static function ( $pk, array $extra ) use ( $tempTableInfo, $func ) {
foreach ( $tempTableInfo['extra'] as $to => $from ) {
if ( !array_key_exists( $from, $extra ) ) {
throw new InvalidArgumentException( "$func callback: \$extra[$from] is not provided" );
}
}
};
} else {
$callback = static function ( $pk, array $extra ) {
};
}
return [ $ret, $callback ];
}
/**
* Get WHERE condition for the actor
*
* @param IDatabase $db Database to use for quoting and list-making
* @param string $key A key such as "rev_user" identifying the actor
* field being fetched.
* @param UserIdentity|UserIdentity[]|null|false $users Users to test for.
* Passing null, false, or the empty array will return 'conds' that never match,
* and an empty array for 'orconds'.
* @param bool $useId If false, don't try to query by the user ID.
* Intended for use with rc_user since it has an index on
* (rc_user_text,rc_timestamp) but not (rc_user,rc_timestamp).
* @return array With three keys:
* - tables: (string[]) to include in the `$table` to `IDatabase->select()`
* - conds: (string) to include in the `$cond` to `IDatabase->select()`
* - orconds: (array[]) array of alternatives in case a union of multiple
* queries would be more efficient than a query with OR. May have keys
* 'actor', 'userid', 'username'.
* Since 1.32, this is guaranteed to contain just one alternative if
* $users contains a single user.
* - joins: (array) to include in the `$join_conds` to `IDatabase->select()`
* All tables and joins are aliased, so `+` is safe to use.
*/
public function getWhere( IDatabase $db, $key, $users, $useId = true ) {
$this->checkDeprecation( $key );
$tables = [];
$conds = [];
$joins = [];
if ( $users instanceof UserIdentity ) {
$users = [ $users ];
} elseif ( $users === null || $users === false ) {
// DWIM
$users = [];
} elseif ( !is_array( $users ) ) {
$what = is_object( $users ) ? get_class( $users ) : gettype( $users );
throw new InvalidArgumentException(
__METHOD__ . ": Value for \$users must be a UserIdentity or array, got $what"
);
}
// Get information about all the passed users
$ids = [];
$names = [];
$actors = [];
foreach ( $users as $user ) {
if ( $useId && $user->getId() ) {
$ids[] = $user->getId();
} else {
// make sure to use normalized form of IP for anonymous users
$names[] = IPUtils::sanitizeIP( $user->getName() );
}
$actorId = $this->actorStoreFactory
->getActorNormalization( $db->getDomainID() )
->findActorId( $user, $db );
if ( $actorId ) {
$actors[] = $actorId;
}
}
list( $text, $actor ) = $this->getFieldNames( $key );
// Combine data into conditions to be ORed together
if ( $this->stage & SCHEMA_COMPAT_READ_NEW ) {
if ( $actors ) {
$tempTableInfo = $this->getTempTableInfo( $key );
if ( $tempTableInfo ) {
$alias = "temp_$key";
$tables[$alias] = $tempTableInfo['table'];
$joins[$alias] = [ 'JOIN',
"{$alias}.{$tempTableInfo['pk']} = {$tempTableInfo['joinPK']}" ];
$joinField = "{$alias}.{$tempTableInfo['field']}";
} else {
$joinField = $actor;
}
$conds['actor'] = $db->makeList( [ $joinField => $actors ], IDatabase::LIST_AND );
}
} else {
if ( $ids ) {
$conds['userid'] = $db->makeList( [ $key => $ids ], IDatabase::LIST_AND );
}
if ( $names ) {
$conds['username'] = $db->makeList( [ $text => $names ], IDatabase::LIST_AND );
}
}
return [
'tables' => $tables,
'conds' => $conds ? $db->makeList( array_values( $conds ), IDatabase::LIST_OR ) : '1=0',
'orconds' => $conds,
'joins' => $joins,
];
}
}
|