aboutsummaryrefslogtreecommitdiffstats
path: root/tests/phpunit/includes/content/FallbackContentHandlerTest.php
Commit message (Collapse)AuthorAgeFilesLines
* tests: Use namespaced classesUmherirrender2024-10-211-1/+2
| | | | | | | | Changes to the use statements and some additions are done automatically via script This also updates @covers tag for the namespaced classes Change-Id: I859ba6d05018c99710b744e2becab432410d3bca
* Remove ParserOutput::getText() calls from core (runOutputPipeline)Isabelle Hurbain-Palatin2024-09-061-2/+4
| | | | | | | | | | | | | | | | | This is the fourth patch of a series of patches to remove ParserOutput::getText() calls from core. This series of patches should be functionally equivalent to I2b4bcddb234f10fd8592570cb0496adf3271328e. Here we replace calls to getText where a ContentRenderer is available close by by temporary ParserOutput::runOutputPipeline that will eventually be replaced by a call to (probably) ContentRenderer (T371004). Doing this work in stages allows us to separate the work of "bring ParserOptions to the call site" from the work of "bringing ContentRenderer(ish) to the call site", since both need to be done for to make ParserOutput a value object (T293512). Change-Id: Ib4f9357293dc230df6e0ca2379a1e2a4cc1b91b7 Bug: T293512
* content: Widen `@covers` tags in phpunit testsTimo Tijhof2024-07-211-13/+3
| | | | | | | | | | | | | | | | | | | | | | | | | https://gerrit.wikimedia.org/r/q/owner:Krinkle+is:merged+message:Widen > Given all called methods are de-facto and liberally claimed, and > that we keep the coverage limited to the subject class, it maintains > the spirit and intent by listing the class explicitly instead. > > PHPUnit offers a more precise tool when you need it (i.e. when testing > legacy monster/god classes), but for well-written code, the > class-wide tag is exactly what you want. > > We lose useful coverage and waste valuable time on keeping tags > accurate through refactors (or worse, forget to do so). > Tracking tiny per-method details wastes time in realizing (and > fixing) when people inevitably don't keep them in sync, and time > lost in finding uncovered code to write tests to realize it was > already covered but "not yet claimed". While at it, also fix PHPUnit warnings in CssContentHandlerIntegrationTest and JavaScriptContentHandlerIntegrationTest about not having any `@covers` annotations. Change-Id: I5afd9fe0bca0fa86cc096f6e5e79f2ba1cfbfa77
* Add MediaWiki\Content namespace to FallbackContent{,Handler}Ebrahim Byagowi2024-05-211-1/+3
| | | | | | | | | This adds MediaWiki\Content namespace to FallbackContent and FallbackContentHandler and declares the unnamespaced version as deprecated since version 1.43. Bug: T353458 Change-Id: I3ee80aea379788b71539cc1c7a4ec216b753e042
* HtmlOutputRendererHelper: fall back to page languagedaniel2024-03-061-1/+4
| | | | | | | | | | | | | | | | HtmlOutputRendererHelper should not crash hard if the ParserOutput has no language set. ParserOutput may come from a variety of places, we should be lenient about it not having a language. However, we should try harder to actually set a language on ParserOutput if we have one available. So this also updates PageBundleParserOutputConverter to keep the ParserOutput's language in sync wit the language header in the PageBundle. Bug: T349868 Bug: T353689 Bug: T359426 Change-Id: I2edf20dc3b199e22cda2f32bc858c21ca7d8f4bd
* tests: Fix @covers and @coversDefaultClass to have leading \Reedy2024-02-161-2/+2
| | | | Change-Id: I5629f91387f2ac453ee4341bfe4bba310bd52f03
* Namespace includes/contextJames D. Forrester2024-02-081-0/+1
| | | | | Bug: T353458 Change-Id: I4dbef138fd0110c14c70214282519189d70c94fb
* ContentHandler: Hard-deprecate getSlotDiffRendererInternalJames D. Forrester2023-08-251-0/+1
| | | | | | | | Deprecated since 1.35, but still used by ProofreadPage until the listed dependency is merged. Depends-On: I1c180521b831d8e6896679c8bfed6cb64260d40d Change-Id: I39a1bf5b6e5d14b07be84a0a139a1abb5b289368
* Fix DB usage in non-database tests (part 2)Daimona Eaytoy2023-08-061-0/+2
| | | | | | | | Mock the relevant services that need the DB instead, when possible. When not possible, e.g. because DB access is needed for the test to make sense, add the test to the Database group instead. Change-Id: Iefbfe00bedc243906c6b860572568343268646cc
* tests: Use Title::makeTitle instead of Title::newFromTextUmherirrender2023-06-191-1/+1
| | | | | | Avoid parsing known titles in tests to improve performance Change-Id: Iddefe62c3d85281642f17e60cbc27aff47b85a67
* Reorg: Namespace the Title classJames D. Forrester2023-03-021-0/+1
| | | | | | | | | | | | | | | | | | | This is moderately messy. Process was principally: * xargs rg --files-with-matches '^use Title;' | grep 'php$' | \ xargs -P 1 -n 1 sed -i -z 's/use Title;/use MediaWiki\\Title\\Title;/1' * rg --files-without-match 'MediaWiki\\Title\\Title;' . | grep 'php$' | \ xargs rg --files-with-matches 'Title\b' | \ xargs -P 1 -n 1 sed -i -z 's/\nuse /\nuse MediaWiki\\Title\\Title;\nuse /1' * composer fix Then manual fix-ups for a few files that don't have any use statements. Bug: T166010 Follows-Up: Ia5d8cb759dc3bc9e9bbe217d0fb109e2f8c4101a Change-Id: If8fc9d0d95fc1a114021e282a706fc3e7da3524b
* Reorg: Move some of request related classes to MediaWiki/RequestAmir Sarabadani2022-10-281-0/+2
| | | | | | | | | | | | | | | Redoing I5ea70120d74 but without moving WebRequest that caused issues with phan-taint-plugin. Moving: - DerivativeRequest - FauxRequest - FauxRequestUpload - PathRouter - WebRequestUpload Bug: T321882 Change-Id: I832b133aaf61ee9f6190b0227d2f3de99bd1717b
* Revert "Reorg: Move some of request related classes to MediaWiki/Request"Zabe2022-10-271-2/+0
| | | | | | | | | This reverts commit 2bdc0b2b7209441a42a784157633a8a01b321922. Reason for revert: T166010#8349431 Bug: T166010 Change-Id: Idcd3025647aec99532f5d69b9c1718c531761283
* Reorg: Move some of request related classes to MediaWiki/RequestAmir Sarabadani2022-10-261-0/+2
| | | | | | | | | | | | | Moving: - DerivativeRequest - FauxRequest - FauxRequestUpload - PathRouter - WebRequest - WebRequestUpload Bug: T166010 Change-Id: I5ea70120d745f2876ae31d039f3f8a51e49e9ad8
* Replace Content::getParserOutput call to ContentRenderer::getParserOutputRoman Stolar2021-10-201-0/+37
| | | | | Bug: T287158 Change-Id: I8a13f45027e08e2d8ddefa140dd47a0c55094934
* Split FallbackContentHandlerTest into separate unit testsDannyS7122021-03-301-95/+3
| | | | | | | | Only testGetSlotDiffRenderer() requires integration Clean up the code that is being moved, and fix the remaining covers in the integration test Change-Id: Ic5926b23daf6738c44d9a5aacb75276f81c51f7a
* Create fallback for undefined content models.daniel2020-07-221-0/+119
This causes RevisionStore to use FallbackContent instances to represent content for which no content handler is defined. This may happen when loading revisions using a model that was defined by an extension that has since been uninstalled. Bug: T220594 Bug: T220793 Bug: T228921 Change-Id: I5cc9e61223ab22406091479617b077512aa6ae2d
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-30 23:56:11 +0000