| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This gives us a solid baseline to use for automated tests. Whitespace
differences will be ignored by the test, but regenerate these anyway
because they're much more readable now, and it's generally nice to have
a clean baseline.
Differences are due to:
- JSON files being moved in T382030
- JSON paths in the autogenerated comment are now standardized
(I358cc24798f518d7)
- Whitespace changes from Ib2f60b492ced8ff
- Actual SQL changes from newer versions of doctrine/dbal
There's also one important exception: the SQLite schema change for
patch-page-rename-name_title-index no longer matches the JSON file since
I17e73d5ef1. There doesn't seem to be a super-simple way around this,
because we don't know the state of the database pre-update. On top of
that, I believe that removing the field from the .sql file as done in
I17e73d5ef1 could've caused data loss when upgrading from old versions:
the column could be silently dropped before running the DB update that
correctly migrates and drop the column. This is something to keep in
mind going forwards, and T381981 will prevent it from happening that
easily. But for the update in question, it's probably too late, so just
update the JSON file to match the .sql files.
Bug: T381981
Bug: T382030
Change-Id: I3a3acc0935409d4601eb172664580b13d5fe2340
|
|
|
This is the standard in every extension. DB schema changes are not
maintenance scripts, and therefore there's no apparent reason to have
the two things together, besides historical reasons.
Also, put each DB type in a separate directory, which wasn't the case
for MySQL before. For SQLite and Postgres schema changes, we now
follow the convention (used everywhere else, including the
generateSchemaChangeSql script) of having the DB type as the last part
of the path. This lets us generate schema changes for all DB types at
once, and without specifying the full file path.
Most files are just being renamed, the exceptions being to update
references to the old location (sometimes still referencing tables.sql).
Note that the old path is still referenced in the autogenerated comment
of schema changes SQL files. These will be regenerated in another
commit. Instead, the schema files are done now, because they're covered
by DatabaseIntegrationTest that would otherwise fail.
Bug: T382030
Change-Id: I3b4a614366d0bc629523ac40ce97d001f3b6bcf8
|
