| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Change-Id: I52fdc5e5bc64bbe7ea895b9d7106dd3c99b0a908
|
|
|
|
| |
Change-Id: Ic9f254b55d3936f351ba9c7cc3b553544fc63a58
|
|
|
|
|
|
|
| |
Temporarily disable no-var & prefer-const as resulting errors
need to be fixed manually.
Change-Id: I6cb62a2c70a4c1fc265a00b1f18af127ac9d5029
|
|
|
|
|
|
|
|
|
| |
With the previous $.extend()-based implementation, `undefined`
parameters were not added to the URI, and some gadgets relied on this.
Restore that behavior.
Bug: T372742
Change-Id: Ib6203b08a29880176f7add15548585586434d7c2
|
|
|
|
|
|
|
|
|
| |
I looked through all of Ic6330fcb116e99d5827b4877e094e3073e2b7b72
(commit 2af1c3c) and there were the ones where I could not quickly
convince myself that the first argument is an object in all
circumstances.
Change-Id: I5c744f04cd91e3a4328fb1dc86294aa1905f62a5
|
|
|
|
| |
Change-Id: Iddfa574e42e569ac5e2a2b098ad2f11ca80c5955
|
|
|
|
|
|
|
| |
Also remove temporary explicit dependency on eslint-plugin-vue
introduced in Ibd616750f046a.
Change-Id: Ic6330fcb116e99d5827b4877e094e3073e2b7b72
|
|
|
|
|
| |
Bug: T363545
Change-Id: I50df14cf6fc74707c15ff659b7a85ea412c5e7eb
|
|
|
|
|
|
|
|
|
| |
* Uses class descriptions for classes and descriptions
for constructors.
* Switch out deprecated "done" function for Promise compatible "then"
Bug: T357164
Change-Id: I6071851a2519638d67954bba5d74260d99237863
|
|
|
|
|
| |
Bug: T360241
Change-Id: Ie99d3b3989d4a5f150e2b7bd36450a5d085c0a34
|
|
|
|
|
| |
Bug: T360241
Change-Id: I90d7a58ca9385d7380472883b5bb7f1e7cacf785
|
|
|
|
|
|
|
|
| |
Use Markdown syntax to format code samples within JSDoc
descriptions.
Bug: T352233
Change-Id: I89476931ec836813fd3999fe5eb8143c3df50068
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Mark @events as @ignore and move description to top of block
* Replace @cfg with @param
* Add additional OOUI classes
* Add full stops to ends of sentences
* @ignore various functions
Bug: T352308
Change-Id: Id68733a2283f3a61f913ee1eb7b32f9a8911ca3d
|
|/
|
|
|
|
|
| |
@property doesn't work for this, so use a combination of @type and
@name.
Change-Id: I4518f61fc61f41632e297361f8b53a23c21c03f7
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
JSDoc mangles dots in '@module <name>' and '@exports <name>'
annotations: https://github.com/jsdoc/jsdoc/issues/1157
Work around this bug with a small plugin.
Update '@link', '@memberof' etc. annotations that had to be written
using incorrect names to work. (Those annotations are not affected by
the bug, so we had to mangle them by hand.)
Bug: T356913
Change-Id: I68bfb7be0f7d1d49901a1d5ceebc618771380b35
|
|
|
|
|
|
|
|
|
|
|
|
| |
* mw.UriRelative was being documented on global.html
* Api was missing a summary line on mw namespace
* Add summary for mw.user.options and mw.user.tokens and
summary for mw.user
* Documents mw.Uri class (missing summary) and methods
(missing from docs)
Bug: T352308
Change-Id: Ieb87b94e4d5f6f83f025a94da242c05622c01aca
|
|
|
|
|
|
|
|
|
| |
mw.UriRelative was documented as `mw` itself rather than a member of
`mw`, not only making the actual name not appear, but also hiding all
other members (classes, subnamespaces, properties, functions) of `mw`.
Bug: T352308
Change-Id: Ib7ee760f63186fe71fb17c76dd0154a124acd991
|
|
|
|
|
| |
Bug: T352308
Change-Id: If780d42c77ac270046ac19a534c758ef2e6f7215
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These all concern iterating through objects
Replace $.each( obj, function ( key, value ) {} )
with
for ( var key in obj ) {
var value = arr[key];
..
}
OR
Object.keys( obj ).forEach( ( key ) {
var value = arr[key];
..
} );
Note I've not cleaned up all instances in this patch as I exhausted
the timebox I set myself
Additional change: Document second parameter to mw.jqueryMsg.HtmlEmitter
as optional which became obvious from this change.
Bug: T334853
Change-Id: I1ca870246e54648912ef2d0ea370e48058761b50
|
|
|
|
| |
Change-Id: I70d4e311d369bd160e0cb9411d1b074e22104006
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mw.Uri uses encodeURIComponent() for encoding the fragment, which
percent-encodes more characters than it should, including the /
character which is often used in routes the fragment is matched
agains. This means that URL manipulation using mw.Uri with and
something like history.replace might break routing.
Mention this in the documentation of mw.Uri.toString() and refer
to URL which handles fragment roundtripping according to the
WHATWG URL spec.
Change-Id: Ib17349308359665b1ed2c28b91e15207f6fa966c
|
|
|
|
|
|
| |
Also some minor version updates to karma dependencies as required.
Change-Id: I2740faca2d28ad2b2896a3b0222678115d11a166
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces the client-side compiler for 'mediawiki.template.regexp',
with a simple PHP callback.
The regexp temple compiler is not used anywhere after this and will be
removed in a follow-up commit.
Bug: T233676
Change-Id: I1baa1465d88293d03975cadf2efdd57283427722
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the new 'arrayParams' option is set, query strings like
`&foo[0]=a&foo[1]=b` will be parsed as a single parameter `foo`
containing an array, rather than two separate parameters.
The new option also affects the behavior of array parameters like
`&foo[]=a&foo[]=b`, which will be parsed as a parameter named `foo`
rather than `foo[]`, and disables array handling for parameters that
don't contain an array index at the end.
Unlike in PHP, this does not handle associative or multi-dimensional
arrays, but that may be improved in the future.
Bug: T231382
Change-Id: I48d4bb3fdf0ea7f5eb133c59bf63651ba356fc42
|
|
|
|
| |
Change-Id: I8e53d7a0e0b89909a5c3798a819a0690c757a060
|
|
|
|
| |
Change-Id: Iee025a518962e68c5ec2c07d952f402cd2a7f69b
|
|
|
|
|
|
|
|
|
|
| |
I, personally, think the fact an empty `new Uri()` call can fail with
an Error being thrown is a bug. But it seems others think this is a
feature (see Ib4dc568). Can we at least document it then? And then
somehow (not sure how) tell everybody who ever used this class to fix
their code?
Change-Id: I86ef1ccf90f9be9c61bc6a8312369ae09d622b0c
|
|
|
|
| |
Change-Id: I7b5d228a3de4b3006751a427dec907a5bebf2f51
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Follows-up Id6d13bbea6:
- '$': mw.loader.implement does this already.
- 'mw': Use the canonical name directly.
This replaces the following patterns:
File closures (common):
- `( function ( $, mw ) {` => `( function () {`
- `( function ( $ ) {` => `( function () {`
- `( function ( mw ) {` => `( function () {`
- `( function ( mw, $ ) {` => `( function () {`
File closures (rare):
- `( function ( mw, $, OO ) {` => `( function () {`
- `( function ( mw, OO, $ ) {` => `( function () {`
- `( function ( mw, document ) {` => `( function () {`
Combined dom-ready and file closure (rare):
- `jQuery( function ( $ ) {` => `$( function () {
- `jQuery( function () {` => `$( function () {
Remaining references in files without a closure, as found by
the new ESLint setting (rare):
- `jQuery` => `$`
- `mediaWiki` => `mw`
Change-Id: I7cf2426cde597259e8c6f3f6f615a1a81a0ca82b
|
|
|
|
|
|
|
|
|
|
|
| |
Even though Array.prototype.forEach only works on arrays, and
$.each is more generic, I think it makes sense to begin discouraging
the usage of $.each now. This can be overriden by ignore lines or
by Array.prototype.forEach compatible lines. This doesn't seem too
much of an ask of engineers and helps future migrations
Bug: T200877
Change-Id: I339cff311a830699c8e32f07cec338a39870c53f
|
|
|
|
| |
Change-Id: I26a98be16c005c1c864ec592e1a41b44943f8f29
|
|
|
|
|
|
|
|
|
|
| |
mediawiki.js: Reorder setGlobalMapValue() to avoid a forward reference.
mediawiki.action.edit.stash.js: Reorder two functions without to avoid
forward references.
In all other cases add eslint-disable-next-line no-use-before-define.
Change-Id: Ic8b2f8cf61dcfb1a215ad3d3dddfd40282e3e836
|
|
Single-file modules to src/, the remaining as sub directories.
A few highlights:
* mediawiki.Upload.BookletLayout. (stylesheet: no image references)
* mediawiki.feedback - Also move the image to its own images/ subdir.
* mediawiki.searchSuggest. (stylesheet: no image references)
* mediawiki.toc. (stylesheet: no image references)
Also updated any other references to 'src/mediawiki/' that I could find
in core:
* Fixed references in docs/uidesign/*.html
* Remove redundant exclude from jsduck.json.
After this, there are 4 files remaining in src/mediawiki,
which are the 4 files used by the actual 'mediawiki' base module.
Bug: T193826
Change-Id: I8058652892a78b3f5976397bd850741dd5c92427
|