aboutsummaryrefslogtreecommitdiffstats
path: root/includes/watchlist/WatchedItemStore.php
Commit message (Collapse)AuthorAgeFilesLines
* Namespace all remaining files in includes/jobqueueJames D. Forrester2025-03-201-1/+1
| | | | | Bug: T353458 Change-Id: I95690a312e356c45dbeed607d32fb0e4626690cf
* Replace call_user_func with dynamic function callUmherirrender2025-02-131-4/+2
| | | | | | | | Use modern php syntax to call a callable. Reduce the stack trace to improve performance and better IDE and static analyzer support Change-Id: I9ef131032a662a3b8db69aa7079dbd51f88f575a
* Remove 2-line PHPDocs that just repeat the types from the codethiemowmde2025-01-171-8/+0
| | | | | | | | | | | | | | | | Same as Ia294bf4 did for 1-line comments. This patch removes slightly more complex 2-line PHPDoc comments that don't add any new information to the code, but literally repeat what the code already says. They say "don't document the code, code the documentation", and we are doing this more and more. We just tend to forget to remove the obsolete comments. Note I'm also removing a line of text in a few cases when it's very short and literally says the same as the method name. Again, such comments add zero new information. Change-Id: I01535404bab458c6c47e48e5456403b7a64198ed
* Remove trivial 1-line PHPDocs that just repeat the codethiemowmde2025-01-161-9/+0
| | | | | | | | | | | | | I assume these are all either auto-generated by an IDE or the language-level type declarations have been added later. In any case the comments don't add any new information to what the code already says. This is just extra clutter that makes the code harder to read, I would argue. There are many, many more comments like this. In this patch I intentionally focus on the most trivial 1-line comments. Change-Id: Ia294bf4ce0d8a77036842fe25884bc175c2b0e7d
* Make use of the ??= and ?? operators where it makes sensethiemowmde2024-08-261-4/+1
| | | | | | | | This touches various production classes and maintenance scripts. The code should do the exact same as before. The main benefit is that the syntax avoids any repetition. Change-Id: I5c552125469f4d7fb5b0fe494d198951b05eb35f
* deferred: pass $fname to MWCallableUpdate callbacks and improve commentsAaron Schulz2024-08-081-4/+4
| | | | | | | | | | This is more convenient for callers since they can avoid the pattern of setting $fname to __METHOD__ and needing $fname in the "use" clause. This is also more consistent with AutoCommitUpdate/AtomicSectionUpdate. Remove @since tags from @internal MWCallableUpdate class. Change-Id: I67c58897dc366a55f43e0a61d56064b26d520c17
* watchlist: Use expression builder to avoid IDatabase::addQuotesUmherirrender2024-07-181-13/+10
| | | | | | | | | Many unit tests needs adjust, because the ->with() call no longer matched and using expression objects for the matching repeats the same code between test and real implementation. Bug: T361023 Change-Id: I6f8dbd12d7135ee28ad5b1eabb58d1354d1591d3
* Add namespace to the root classes of ObjectCacheEbrahim Byagowi2024-07-101-2/+2
| | | | | | | | | And deprecated aliases for the the no namespaced classes. ReplicatedBagOStuff that already is deprecated isn't moved. Bug: T353458 Change-Id: Ie01962517e5b53e59b9721e9996d4f1ea95abb51
* Add MediaWiki\Watchlist namespace to the related classesEbrahim Byagowi2024-05-221-3/+0
| | | | | | | | | This adds MediaWiki\Watchlist namespace to the classes of watchlist directory and adds deprecation notice since 1.43 to the just created unnamespaced aliases of the classes. Bug: T353458 Change-Id: I4234f8fe62bb3bde6f5271c7ba31a2420b0f4b90
* Add namespace and deprecation alias to WatchedItemStoreEbrahim Byagowi2024-05-201-5/+16
| | | | | | | | | This patch introduces a namespace declaration for the MediaWiki\Watchlist to WatchedItemStore and establishes a class alias marked as deprecated since version 1.43. Bug: T353458 Change-Id: I820a3512440ba5a1de13e8470ccf5845918f3198
* Add namespace and deprecation alias to ActivityUpdateJobEbrahim Byagowi2024-05-191-0/+1
| | | | | | | | | This patch introduces a namespace declaration for the Wikimedia\Watchlist to ActivityUpdateJob and establishes a class alias marked as deprecated since version 1.43. Bug: T353458 Change-Id: I34342bb01c8f6c9657f1b2f05de1de64a107665f
* Add namespace and deprecation alias to WatchedItemEbrahim Byagowi2024-05-171-0/+1
| | | | | | | | | This patch introduces a namespace declaration for the MediaWiki\Watchlist to WatchedItem and establishes a class alias marked as deprecated since version 1.43. Bug: T353458 Change-Id: Id2a582b624f21867240def2541c98ce5b1bd12b4
* Add namespace and deprecation alias to WatchlistExpiryJobEbrahim Byagowi2024-05-171-0/+1
| | | | | | | | | This patch introduces a namespace declaration for the MediaWiki\Watchlist to WatchlistExpiryJob and establishes a class alias marked as deprecated since version 1.43. Bug: T353458 Change-Id: Ia0a85c9d7550edc972ea512606dfcf272c71a6cd
* watchlist: Move un-namespaced watcheditem classes to /includes/watchlist/Timo Tijhof2024-05-101-0/+1858
Bug: T364652 Change-Id: I264024784e8147fa421c8a13e8ae4541d8735f78