aboutsummaryrefslogtreecommitdiffstats
path: root/includes/utils
Commit message (Collapse)AuthorAgeFilesLines
* Namespace all remaining files in includes/filerepoJames D. Forrester2025-03-191-0/+1
| | | | | Bug: T353458 Change-Id: I35864ad9bd48701703c51367d62f8ebde963c52d
* Replace call_user_func with dynamic function callUmherirrender2025-02-131-1/+1
| | | | | | | | Use modern php syntax to call a callable. Reduce the stack trace to improve performance and better IDE and static analyzer support Change-Id: I9ef131032a662a3b8db69aa7079dbd51f88f575a
* Remove 2-line PHPDocs that just repeat the types from the codethiemowmde2025-01-172-4/+0
| | | | | | | | | | | | | | | | Same as Ia294bf4 did for 1-line comments. This patch removes slightly more complex 2-line PHPDoc comments that don't add any new information to the code, but literally repeat what the code already says. They say "don't document the code, code the documentation", and we are doing this more and more. We just tend to forget to remove the obsolete comments. Note I'm also removing a line of text in a few cases when it's very short and literally says the same as the method name. Again, such comments add zero new information. Change-Id: I01535404bab458c6c47e48e5456403b7a64198ed
* Remove trivial 1-line PHPDocs that just repeat the codethiemowmde2025-01-161-3/+0
| | | | | | | | | | | | | I assume these are all either auto-generated by an IDE or the language-level type declarations have been added later. In any case the comments don't add any new information to what the code already says. This is just extra clutter that makes the code harder to read, I would argue. There are many, many more comments like this. In this patch I intentionally focus on the most trivial 1-line comments. Change-Id: Ia294bf4ce0d8a77036842fe25884bc175c2b0e7d
* BatchRowIterator: Use SelectQueryBuilder directlyBartosz Dziewoński2025-01-071-66/+32
| | | | | | | | | | | Allow passing a SelectQueryBuilder to BatchRowIterator, instead of passing only table names and then setting all other query info using custom methods. Hopefully offering this more familiar interface will make BatchRowIterator easier to use. Change-Id: I87f81ba693e0a74d414342fa5ffc2eac0bcfdf11
* MimeAnalyzer: move ZipDirectoryReader to librarydaniel2025-01-032-741/+0
| | | | | | | | | | | | | | | | | Why: - MimeAnalyzer needs ZipDirectoryReader, but it was not part of libs. This was a problem because libs code must note depend on MediaWiki code. Since there seem to be no other users of ZipDirectoryReader, the simplest solution seems to be to move ZipDirectoryReader into the Wikimedia\Mime library. What: - Moved ZipDirectoryReader and ZipDirectoryReaderError into the Wikimedia\Mime namespace under includes/libs/mime. Bug: T382910 Bug: T364652 Change-Id: Iccdade8dcd3211b7e2df2e50694da8d97c82b59e
* Remove CryptHKDF and MWCryptHKDFKevin Israel2024-11-111-103/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MWCryptHKDF was added ten years ago (in af66c04d39ad96a0), and as far as I can tell, it was never used anywhere. It seems unlikely that CryptHKDF will be used in the future, at least in its current form, for several reasons: * PHP 7.1.2+ has hash_hkdf(), so HKDF() would not be needed. * At the time MWCryptHKDF was created, access to a CSPRNG was dependent on server configuration: operating system, enabled PHP extensions, open_basedir, etc. The "clock drift" RNG used as a last resort was not considered to be secure or fast enough for generating large amounts of output.[1] random_bytes(), added in PHP 7, changed the situation. * Depleting the input pool of Linux's RNG is no longer a concern; there is no more blocking output pool for /dev/random.[2][3] In 2022, this change and others, including some that improved performance,[4] were backported to stable kernels as old as 4.9.[5] * $wgAuthenticationTokenVersion obviated the primary use case of quickly resetting the user_token field for all users, assuming all the existing tokens are unique. * CryptHKDF seems to perform much slower than random_bytes(), at least on Linux, making it pointless to use given that the other reasons for its existence no longer apply. [1]: https://bots.wmflabs.org/logs/%23mediawiki-core/20161004.txt [2]: https://lwn.net/Articles/808575/ [3]: https://lore.kernel.org/all/cover.1577088521.git.luto@kernel.org/ [4]: https://www.zx2c4.com/projects/linux-rng-5.17-5.18/ [5]: https://lore.kernel.org/all/Yo3pmh9hiUFtQz77@zx2c4.com/T/ Change-Id: I29136fad826341d21728671aa30285d5551f1162
* Use ++ and -- rather than += 1 and -= 1Reedy2024-10-171-2/+2
| | | | Change-Id: I27b9a19ab952ede1267921bd042af0fe1c89e228
* Use explicit nullable type on parameter argumentsUmherirrender2024-10-162-4/+4
| | | | | | | | | | | Implicitly marking parameter $... as nullable is deprecated in php8.4, the explicit nullable type must be used instead Created with autofix from Ide15839e98a6229c22584d1c1c88c690982e1d7a Break one long line in SpecialPage.php Bug: T376276 Change-Id: I807257b2ba1ab2744ab74d9572c9c3d3ac2a968e
* Add namespace to remaining parts of Wikimedia\FileBackendJames D. Forrester2024-10-031-0/+1
| | | | | Bug: T353458 Change-Id: I49c843c9d8f6459c0fbf774afeea7a82fa564b59
* Add namespace to remaining parts of Wikimedia\Mime and Wikimedia\StatsJames D. Forrester2024-09-271-0/+1
| | | | | Bug: T353458 Change-Id: If0137003ab625017d322d57870448a02569668c3
* Remove unchecked exception annotationsAdam Wight2024-09-171-1/+0
| | | | | | | | | | | | | | | Callers should not catch an unchecked exception, so it doesn't belong in a function signature. Unchecked exceptions indicate a coding error, which by definition the code will not be able to handle correctly. If any of these exceptions were supposed to be in response to an edge case, user input, or initial conditions, then they should be changed to a runtime error. If the exception class cannot be changed, then the annotation should include a comment explaining its purpose and prognosis. Bug: T240672 Change-Id: I2e640b9737cb68090a8e1cb70067d1b74037d647
* Remove UIDGenerator, deprecated since 1.35Ebrahim Byagowi2024-09-041-177/+0
| | | | Change-Id: I5e47ecd560218df7e48af68e6aee351bc2a57823
* Merge "utils: Add missing documentation to class properties"jenkins-bot2024-09-014-14/+19
|\
| * utils: Add missing documentation to class propertiesUmherirrender2024-09-014-14/+19
| | | | | | | | | | | | | | | | | | | | | | | | Add doc-typehints to class properties found by the PropertyDocumentation sniff to improve the documentation. Once the sniff is enabled it avoids that new code is missing type declarations. This is focused on documentation and does not change code. Improve a mixed type to string Change-Id: Id994553eaeac181775ac782423ff53928ad45466
* | utils: Remove unused ZipDirectoryReader::$data class propertyUmherirrender2024-09-011-3/+0
|/ | | | | | | Unused since addition of class property in 6906724935 (r100779) Unused since dynamic creation in 0a21e2de12 (r82783) Change-Id: I72c7dab67ef12d229fb232311e404467260d742d
* Make use of the ??= and ?? operators where it makes sensethiemowmde2024-08-261-3/+1
| | | | | | | | This touches various production classes and maintenance scripts. The code should do the exact same as before. The main benefit is that the syntax avoids any repetition. Change-Id: I5c552125469f4d7fb5b0fe494d198951b05eb35f
* Move Language and friends into Language namespaceJames D. Forrester2024-08-101-1/+1
| | | | | Bug: T353458 Change-Id: Id3202c0c4f4a2043bf97b7caee081acab684155c
* Add namespace to the root classes of ObjectCacheEbrahim Byagowi2024-07-101-0/+5
| | | | | | | | | And deprecated aliases for the the no namespaced classes. ReplicatedBagOStuff that already is deprecated isn't moved. Bug: T353458 Change-Id: Ie01962517e5b53e59b9721e9996d4f1ea95abb51
* Use namespaced classes (1)Umherirrender2024-06-161-0/+1
| | | | | | | Changes to the use statements done automatically via script Addition of missing use statement done manually Change-Id: Ic4d4dd61de5ab896fb6173eb579c81f164a1e4a3
* Add "implements Stringable" to every class with "function __toString()"Bartosz Dziewoński2024-06-131-1/+1
| | | | | | | | | | | | | In PHP 8, but not in PHP 7.4, every class with a __toString() function implicitly implements the Stringable interface. Therefore, the behavior of checks like "instanceof Stringable" differs between these PHP versions when such classes are involved. Make every such class implement the interface so that the behavior will be consistent. The PHP 7.4 fallback for the Stringable interface is provided by symfony/polyfill-php80. Change-Id: I3f0330c2555c7d3bf99b654ed3c0b0303e257ea1
* Add namespace and deprecation alias to FileBackendEbrahim Byagowi2024-05-191-0/+2
| | | | | | | | | This patch introduces a namespace declaration for the Wikimedia\FileBackend to FileBackend and establishes a class alias marked as deprecated since version 1.43. Bug: T353458 Change-Id: Id897687b1d679fd7d179e3a32e617aae10ebff33
* Add namespace and deprecation alias to FormatJsonEbrahim Byagowi2024-05-163-1/+4
| | | | | | | | | This patch introduces a namespace declaration for the MediaWiki\Json to FormatJson and establishes a class alias marked as deprecated since version 1.43. Bug: T353458 Change-Id: I5e1311e4eb7a878a7db319b725ae262f40671c32
* Migrate to IReadableDatabase::newSelectQueryBuilderUmherirrender2024-05-051-11/+10
| | | | | | | | | This cases cannot benefit from the SelectQueryBuilder as each argument get processed by hooks with fix signature or coming from abstract functions providing the arguments separate. Bug: T344971 Change-Id: I6490caae3984efaae81bd2583220a7dd1c3b371d
* namespace MWDebugAmir Sarabadani2024-05-031-1/+1
| | | | | Bug: T353458 Change-Id: I99d728bd111ff882220cd175ff09d4da20b81eae
* Ignore/fix MediaWiki.Commenting.PropertyDocumentation.WrongStyleTaavi Väänänen2024-04-221-4/+4
| | | | | | | | Fix the real issues found by this sniff, and convert the remaining false positive ignores to per-line ignores so that any more real issues won't be added. Change-Id: I18e75d59df327e2d93a3a487c115e92b9f268722
* utils: zip: Fix PSR2.Classes.PropertyDeclaration.Multiple errorsTaavi Väänänen2024-04-221-1/+3
| | | | Change-Id: I228f4d6fbf8195ca50b770e916dc09a40383ca1b
* utils: Improve documentation of UrlUtils protocol methodsthiemowmde2024-04-151-10/+4
| | | | | | As well as make use of the ??= operator where it makes sense. Change-Id: I7d9aea8c4b985613016a918b7e0c87d2e0ffd01b
* GitInfo: Fix Phan warning on WindowsBartosz Dziewoński2024-04-051-2/+2
| | | | | | | | | | | | | | | | | | On my Windows machine, I was getting the following Phan warning: includes\utils\GitInfo.php:159 UnusedPluginSuppression Plugin BuiltinSuppressionPlugin suppresses issue PhanPluginDuplicateArrayKey on this line but this suppression is unused or suppressed elsewhere Indeed, this isn't a PhanPluginDuplicateArrayKey issue on Windows, since DIRECTORY_SEPARATOR is `\`; but it is a legitimate warning on other systems where DIRECTORY_SEPARATOR is `/`. Refactor the code slightly so as to not create an array with potentially duplicate keys. Change-Id: I4be38aa9fefde26d58139d74a85359961229baec
* Standardise all our class alias deprecation comments for ease of greppingJames D. Forrester2024-03-193-9/+3
| | | | Change-Id: I7f85d931d3b79da23e87b4e5692b2e14be8fcaa0
* Namespace Message, move to appropriate directoryJames D. Forrester2024-02-141-1/+1
| | | | | Bug: T353458 Change-Id: I088cbc53fbcdb974e5b05b45a62e91709dacc024
* build: Upgrade mediawiki/mediawiki-phan-config from 0.13.0 to 0.14.0 manuallyJames D. Forrester2024-02-102-7/+6
| | | | | | | | | | | * Switch out raw Exceptions, mostly for InvalidArgumentExceptions. * Fake exceptions triggered to give Monolog a backtrace are for some reason "traditionally" RuntimeExceptions, instead, so we continue to use that pattern in remaining locations. * Just entirely give up on PostgresResultWrapper's resource vs. object mess. * Drop now-unneeded false positive hits. Change-Id: Id183ab60994cd9c6dc80401d4ce4de0ddf2b3da0
* Namespace includes/contextJames D. Forrester2024-02-081-1/+1
| | | | | Bug: T353458 Change-Id: I4dbef138fd0110c14c70214282519189d70c94fb
* Merge "Use native str_contains/str_starts_with in a few more places"jenkins-bot2024-01-251-2/+2
|\
| * Use native str_contains/str_starts_with in a few more placesthiemowmde2024-01-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes the code quit a bit more readable, I believe. strpos is especially confusing because it can return false when a string doesn't contain the needle, as well as 0 when the string starts with the needle. This is sometimes used as a feature (i.e. to check if a string contains the needle, but doesn't start with it), but that's not the case here. A slightly more complicated change is made in TitleTest. But this is only in a test and should verify itself when the test still succeeds. Change-Id: I355ad1dc8e1725ae7a1eb652ec047ce7ff589cdf
* | Change more uses of getDBLoadBalancerFactory() to getConnectionProvider()Bartosz Dziewoński2024-01-231-3/+3
| | | | | | | | | | | | | | | | | | | | | | Some less trivial cases. Also update variable names. This doesn't really change anything, but I hope it helps promote getConnectionProvider() as the common way to do this. Follow-up to 8604c384f624273f46b653ec252ffaed30e6ff89. Change-Id: I6657d783375fac5c7fa856b884ff1fb09285e94c
* | Replace deprecated MWExceptionDaimona Eaytoy2024-01-161-1/+1
|/ | | | | Bug: T328220 Change-Id: Ic45438d9e6bbf127f1415add81ab902044765840
* Allow setting page restrictions on BotPassword grantsSiddharth VP2023-12-051-3/+51
| | | | | | | | | | | | | | | Helps bot operators adhere to the principle of least privileges. Grants can now be restricted to allow editing (and other write operations) for upto 25 listed pages. The page IDs are persisted within the bp_restrictions field of bot_passwords table, and in the session metadata. This restriction is checked only as part of expensive checks in PermissionManager, since they are not applicable for UI actions. Bug: T349957 Change-Id: I3d228eb97664d040a160c5b742d9176fdfae9a43
* Refactor HTMLRestrictionsField to allow more restrictions to be addedSiddharth VP2023-11-231-8/+4
| | | | | | | | | | | Earlier, loadDataFromRequest() returned MWRestrictions object only in case of valid input, and the original string if invalid. Now, an MWRestrictions object is returned in all cases, on which we now have a validity field. This also de-duplicates the check to find the invalid IP address(es). Bug: T349957 Change-Id: Iadb762b572cf0e7d2b92dbc4912804a3ddb48e74
* [UrlUtils] Update documentation to refer to new location of wfRemoveDotSegmentsC. Scott Ananian2023-11-161-1/+1
| | | | Change-Id: I44ad0e48835bbe963bfc921b71dd8a1b48eaced1
* GitInfo: Update use of SpecialVersion utility methodsTimo Tijhof2023-10-191-42/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Avoid calling the SpecialPage code directly in e.g. an API module. * Remove unused method "getGitCurrentBranch" on internal class without deprecation. * Mark "getGitHeadSha1" as hard-deprecation first, as there are (unfortunately) two direct callers in Codesearch. * Reduce indirection of non-configurable $IP and $wgBaseDirectory variables in favour of MW_INSTALL_PATH or GitInfo::repo(). * Move potentially duplicate brief and ingroup from file doc to class doc. See also <https://gerrit.wikimedia.org/r/q/message:ingroup+owner:Krinkle> Add example of LocalSettings.php use case, based on the original 36b1172147 (I2a76662bb4) commit message. * Remove use of AtEase (T253461). * Fix potential Windows bug where only backslash was replaced, since that is the canonical path separator, but for this use case, regular slash should (also) be substituted since most contexts on Windows nowadays support that as well, e.g. \foo/bar and \foo\bar are equivalent on Windows. Change-Id: Ib2c89461edc358404544e4236a7a2dc5699b8d4e
* Merge "Improve performance of trivial encoding/decoding regexes"jenkins-bot2023-10-171-4/+2
|\
| * Improve performance of trivial encoding/decoding regexesthiemowmde2023-10-041-4/+2
| | | | | | | | | | | | | | | | | | | | Instead of replacing 1 character at a time the functions used here can replace sequences of any length. This can dramatically reduce the function call overhead. Also make use of the `fn ()` syntax because we can. Change-Id: I2dbc2271aa7847d9b687703f837cb0d850596ef0
* | Use the expression assignment operator to simplify codeUmherirrender2023-10-141-1/+1
|/ | | | | | Suggested by phan, available since php7.4 Change-Id: Ic372ba9abb14de1196b89fca079e99168464eb06
* Merge "Follow RFC 3986 on what is path in mailto URLs"jenkins-bot2023-09-201-19/+4
|\
| * Follow RFC 3986 on what is path in mailto URLsPetr Pchelko2023-09-041-19/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This hack was originally added to wfParseUrl as a fix for T10324 specifically for LinkFilter, however according to the RFC 3986 this is wrong. RFC defines that in URLs the authority component must start with //, so in urls without //, e.g. news: or mailto: there is no authority component, and thus no host component, everything after : is actually a path, so default PHP parse_url is correct. RFC even has an example: > For example, the URI <mailto:fred@example.com> has a path of "fred@example.com". It's fairly ugly to just copy-paste the hack into LinkFilter, but I didn't find an easy and elegant way to rewrite it without making any changes to the link indexes values stored in the DB. See https://datatracker.ietf.org/doc/html/rfc3986 Co-Authored-by: 沈澄心 <dringsim@qq.com> Change-Id: I3dd04495db9c7a66f62c3914c0eff06754b7d560
* | Namespace User under \MediaWiki\UserJames D. Forrester2023-09-191-1/+1
| | | | | | | | | | Bug: T166010 Change-Id: I7257302b485588af31384d4f7fc8e30551f161f1
* | Reorg: Move WebRequest to includes\RequestAmir Sarabadani2023-09-111-0/+1
|/ | | | | | | This has been approved as part of RFC T166010 Bug: T321882 Change-Id: I6bbdbbe6ea48cc1f50bc568bb8780fc7c5361a6f
* Follow-up 15a2781: Add in-code comment on alias for when it was addedJames D. Forrester2023-08-291-0/+3
| | | | Change-Id: I7fd16236c60cb5e1f2d09b9bdb09df130d345c71
* Follow-up cb73518: Add in-code comment on alias for when it was addedJames D. Forrester2023-08-291-0/+3
| | | | Change-Id: I5ffbe7fc4bd1fec1ff4e4e86b8e11f69b11c1b6d
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-23 00:37:49 +0000