aboutsummaryrefslogtreecommitdiffstats
path: root/includes/ZipDirectoryReader.php
Commit message (Collapse)AuthorAgeFilesLines
* Introduce includes/utils directoryTim Starling2013-11-041-712/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | These are classes that provide facilities for use by any caller, are independent of user interface, and have a limited set of dependencies on the rest of MediaWiki. See the README file for a more precise definition. These classes cannot go in includes/libs because of a dependency on the MediaWiki framework, such as wfDebug() or MWException, but they are otherwise similar. I thought it would be useful to put them in their own directory, to make them more discoverable, and as part of a general program of reducing clutter in the base includes/ directory. I've probably missed a few classes which could be included here, but the following classes were considered and were rejected for now: * Fallback: single caller only * GitInfo: getViewers() has inappropriate dependencies * HttpFunctions: depends on configuration, $wgTitle * PoolCounter: depends on configuration * CacheHelper: depends on IContextSource, wfMemc() Also moved a couple of classes into libs/ instead, where that seemed to be more appropriate. Change-Id: I274cff805b7d694b728a89b764a049cd62d320fe
* Added/Removed spaces around string concatenationumherirrender2013-04-131-1/+1
| | | | | | | | | And added/removed spaces around some other tokens, like +, -, *, /, <, >, =, ! Fixed windows newline style Change-Id: I0b9c8c408f3f6bfc0d685a074d7ec468fb848fc8
* Spellchecked /includes directoryYuri Astrakhan2013-03-131-1/+1
| | | | | | | | | * Ran spell-checker over code comments in /includes/ * A few spellchecking fixes for wfDebug() calls Found one very strange (NOOP?) line in Linker.php - see "TODO: BUG?" Change-Id: Ibb86b51073b980eda9ecce2cf0b8dd33f058adbf
* Fixed @param tags to conform with Doxygen format.Tyler Anthony Romeo2013-03-111-9/+9
| | | | | | | | | | | Doxygen expects parameter types to come before the parameter name in @param tags. Used a quick regex to switch everything around where possible. This only fixes cases where a primitve variable (or a primitive followed by other types) is the variable type. Other cases will need to be fixed manually. Change-Id: Ic59fd20856eb0489d70f3469a56ebce0efb3db13
* Kill off numerous unused variablesReedy2013-03-081-1/+1
| | | | Change-Id: I7039f1328f37ee669b694f73ee282602186bffd1
* Use American English spelling for behaviorSiebrand Mazeland2013-03-041-1/+1
| | | | | | Spotted in ipbreason-dropdown by Shirayuki. Change-Id: I576ed4bc0abe5ab980aaee3fb9f9e4b43087311f
* fix some spacingumherirrender2013-02-041-7/+7
| | | | Change-Id: I8f976013f33c5818e4402604fe8610aa3f43b0c6
* Update docs for return and exception infoSiebrand Mazeland2012-10-091-0/+1
| | | | | | | * Removed some inline tabs in the process. * IDE fixed some incorrect leading spaces, too. Change-Id: Ic9303eff6db4424ac3f1fa2816839692b43e6190
* Remove some unused local variables.Siebrand Mazeland2012-10-081-1/+0
| | | | | | Also add a FIXME for a weird case. Change-Id: I1f7f8a522fc49be85051a467455796c3f564584b
* Fix ZipDirectoryReader under Hiphopjeroendedauw2012-08-271-3/+3
| | | | | | | | | | | | | | | | | | | | ZipDirectoryReaderError subclasses Exception, and sets the code property as a string. Php's documentation says this should be an int, so this is already a little bit weird. Under Hiphop, calling the parent constructor without the second parameter will set the code property to 0, because the parameter defaults to 0. This leads to uploads breaking, because calls to getErrorCode return 0 rather than the code that was passed in. The change renames the code property to errorCode, so it can't be confused with exception's code property, which should be an int. https://bugzilla.wikimedia.org/show_bug.cgi?id=39346 Patch by Chris Keeline <ckeeline@fb.com> Change-Id: I9b07a5f7f8ba7c980c0cb0da7b65816dc3b97c4c
* Added missing GPLv2 headers in some places.Alexandre Emsenhuber2012-05-091-0/+20
| | | | | | Also made file/class documentation more consistent. Change-Id: Ib46e50da4ec649a6a06cbeed00752effb79ed06e
* More return documentationSam Reed2012-02-091-0/+3
| | | | Notes: http://mediawiki.org/wiki/Special:Code/MediaWiki/111103
* Fixing some of the "@return true" or "@return false", need to be "@return ↵Sam Reed2012-02-091-8/+9
| | | | | | | | | bool" and then the metadata can say true if foo, false if bar Other documentation improvements Notes: http://mediawiki.org/wiki/Special:Code/MediaWiki/111072
* Add, update, tweak documentationSam Reed2011-10-261-60/+64
| | | | | | | | | Fix document comment blocks Tweak some returns Notes: http://mediawiki.org/wiki/Special:Code/MediaWiki/100779
* Fix unused variablesSam Reed2011-05-131-4/+6
| | | | | | | Decapitalise False Notes: http://mediawiki.org/wiki/Special:Code/MediaWiki/88003
* Tidy up some unused variables and suchSam Reed2011-04-231-1/+1
| | | | Notes: http://mediawiki.org/wiki/Special:Code/MediaWiki/86800
* Minor fix in ZIP64 code from r82783. Note that this code is, before and ↵Tim Starling2011-02-281-1/+0
| | | | | | | after this fix, untested and unused. I only committed it because I thought it might be a helpful starting point for future development. Notes: http://mediawiki.org/wiki/Special:Code/MediaWiki/82924
* * (bug 24230) Added JAR detection. ZIP archives containing a .class file ↵Tim Starling2011-02-251-0/+683
will be rejected by default. Malformed ZIP archives will be rejected due to the danger of ambiguous parsing on the client side. * Removed the ZIP subtypes from $wgMimeTypeBlacklist, they no longer need to be there. * Added ZipDirectoryReader. Added some small ZIP files which are used to test its various error cases. Most were constructed with a hex editor. * Fixed getStatusArray() to return a consistent type regardless of whether the error message has parameters. This allows error messages with no parameters to work with the Status object conversion code in UploadBase::verifyFile(). Notes: http://mediawiki.org/wiki/Special:Code/MediaWiki/82783
generated by cgit v1.2.3 (git 2.25.1) at 2025-05-06 09:58:09 +0000